From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.49 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795296666; b=sGkNqZLOegKqTGnTEK6Bh31WThSwqBTiMtWX/gzC+bODHY7nnAvNod+Q03NRxiOjmUg9 AVgNJHRjn8qlV8Y9bikJJ7wHGpuPkRznVaTqUu748priWIbvVFAy4ivhxSPBncmxcM9jE XqtmK/rhI6hTfhaiOgnefyhYsQPjRbP9rRZ0FFZxtBlsstFZJXensQ3mn+01P5dWng0TR 2lqV80mEXup4v0aqatoeFbXAv0g6sDrZfbR008lmDn9er78iJXkhPC/1ZCePUzkxkBEq3 UITvXmIO5t8DMkHbkJ13h2+igBqKNmRvdljihG9X1Iut0fMrfuffuaOQ5W0O8aKCDRg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795296666; h=DMARC-Filter:Received:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:Received:From:To:Cc:Subject: Date:Message-ID:X-Mailer:MIME-Version:Content-Transfer-Encoding; bh=C93fQcPXxnOGbGKaXQAkMtOoh58jzuHpLH1rCb798RU=; b=i/611mA0Vh7scTdpFeW5PAx6HgnRqKnoA6pRnRh0l+q9wS5FZtlyMis4yBXiAdB0PAA/ x+wMYz1ShWKfLPPcTyHzkx9kafLlVSdIZzFT0vCmysYkrJS/zFtlQvFwVPa6NlmUL5A1q hJPgr+/FgOHEdRt+Tc1Pz2HOn+YrkowLd43h5/C984IKpx5g/hcAwKkpb1ZhO4xQFgkVO 22EYlw4selZDJvFvsC59BdBq3N2r1c7s+l5DU/U1tmAo18NJyl4F+zRkKEX25jcvfwjb8 dNOC24j74RTG1DPqlEl+BECtIaXaIapyAEt6DS3Eo/hNXdCE8X2/XjkDG3kDAoH/1Fg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail header.from=linux.com; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.remote-ip=209.85.128.49 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A01F606A32A for ; Sat, 21 Nov 2026 21:31:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 3A01F606A32A Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4a214c5c4c0so18783815e9.3 for ; Sat, 21 Nov 2026 13:31:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795296665; x=1795901465; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=C93fQcPXxnOGbGKaXQAkMtOoh58jzuHpLH1rCb798RU=; b=dg09BIB8OfRTACu0r9/oEvMM7MhRrUaRQSPcVY6G7t/hwpjHTpvAaNC7TaFhnzq5ys yOykuMMRncOQxD0HlAmrEDtibuH58IaImdnULutoGOhkX5RWEFjSkNmfISLBvC6Uux2g Sa3573rAY5/V2RSFUNJxiQwqT7FYtqpbJQFzHVqhmZAG3SRMNJ69JaDkMcqqALayVZgO J8h/cBA1c3GhHWLSaLPmXT9P/6Qp/vqolrtCGxhqmH57bYdzsuDapF6/COg61MJ9B3MZ +RNN5r4ecdphW0afEtjHYoxDULx9e265yDJ0v5Je0UBKHlkN9P02Kvn4smEKveKv9QVy aDdg== X-Forwarded-Encrypted: i=1; AL+hErFVCsUe/aolfj1C1K3x38jdPL1qrHbKN2y5FV+3LxCU0cns7uK1J1aDVm524jQxRefAngSX3FfIgjoh@vger.kernel.org X-Gm-Message-State: APuU4Z9HozxfAj4zGlMPJj54x43swVfAJr9m/P8Fbt94xBbFNv3BNNm1 VunWqWb1IP9D3Nj4gnE0YtrRpO2STNUlB+/F3M6BkelmJY06vDgm8zN6 X-Gm-Gg: AZFdTZdtzBhzjC2OHvDDkHoRbliBc0Juw5LP2iQDlDq2IB+j6kWq2Al7XNHEraQeyjb C0NidNET94SV/n+8MHIlGRZh7N1a3j5H2e2Jc6epSTu9ehS73LGTp4RmZvX8baoyvx2VzeCkV/4 ObISIWx9z8XSYL87G6CV4PIdB6OphhOWKrLVo67U7V5ashcrAJY9Vew4VHmr56JBlMg1wE6KhbE RERQkjzSI12HHa6tF+FnEwzaK7dfr3wezmioPFCY/qKlCEMKysowMpjiskLVAP5IPHE7DOdEo1t G0uP0qA/mECb8K9SLMMijPS8G92jidHqWUYvTO+wLB7cT4pPULQpN8QEL2Y30s2yjzPC2H2Yjla 1tqRRvK/lV+YbLET4fgYjcVD2fu1rx4gpfBOeUef+ZNtU+243mdShtvwBczYMzjVm+es34D/mdL fD3V/nKsVq3yQG7m1l7xT6xlKMzus2rwSwxEqqi4x9l39sNfyUIPxq7tjHXhbhOs6wY1PFSBlnS UWwapEbkvTNYIPx3IWlf5mMj5/2yDW54EEHGRAPFwMQmRoogmgAd0v6r1LmBIPj5G6Vog8omL88 EJguyOOX3X0bNuO6VhrBok+/xqGfMkpxdwKvOw5g+Zkqf04JljJ51WlhPnBMRGDknRLbtxHU9mw NFxKpulXMwjqyzATciE7XGyo= X-Received: by 2002:a05:600c:5246:b0:4bb:60ba:49e0 with SMTP id 5b1f17b1804b1-4bb88930707mr167527095e9.26.1795296664478; Sat, 21 Nov 2026 13:31:04 -0800 (PST) Received: from threads.localdomain ([84.70.136.3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4ab6a67fec7sm12445954f8f.26.2026.11.21.13.31.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Nov 2026 13:31:03 -0800 (PST) From: Lucas Tanure To: xianwei.zhao@amlogic.com, Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Maxime Chevallier , Maxime Coquelin , Alexandre Torgue Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v8 0/4] Add ethernet support for the Amlogic T7 Date: Sat, 21 Nov 2026 21:30:58 +0000 Message-ID: <20261121213102.143130-1-tanure@linux.com> X-Mailer: git-send-email 2.56.1 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Patches 1 to 4 of v7, the bindings and the driver, are in net-next: 2297f88ce0b8 dt-bindings: net: amlogic,meson-dwmac: list the compatible combinations 18029931478b dt-bindings: net: add amlogic,t7-dwmac c4c851a3325e net: stmmac: dwmac-meson8b: add support for the Amlogic T7 4fdc7da7e13d net: stmmac: dwmac-meson8b: follow the generic RGMII delay rules on the T7 This version carries the rest: a new binding patch for the MDIO multiplexer, and the three device tree patches. Patch 1 is for netdev, patches 2 to 4 for the Amlogic tree; the device tree patches build without the driver part. The T7 has the same ethernet glue as the G12A. The glue registers sit in a block gated by sys_ethphy, so the controller node lists that clock as "pclk", and the pipeline stage between the controller and the DRAM has a gate of its own, listed as well. The MDIO multiplexer gets a T7 compatible with the G12A one as fallback. The VIM4 is plain rgmii-id, with the PHY at the address its pins strap. Tested on v7.4-rc2 on the Khadas VIM4 with the PHY at address 1: 941/944Mbit/s with iperf3, no error. A scan of the bus shows the PHY at 0 and at 1 and nothing else. Overlaps with Xianwei Zhao's "[PATCH v2 0/3] t7: add some nodes for Amlogc t7."; I will drop or rebase whatever overlaps once we agree. Changes since v7: - patches 1 to 4 of v7 are in net-next and are not resent; the numbers below are the new ones - new patch 1: the MDIO multiplexer binding gets "amlogic,t7-mdio-mux" with the G12A compatible as fallback, and patch 3 uses it in the multiplexer node (Martin) - patch 4: the VIM4 PHY node uses address 1, where the PHY is strapped; address 0 only worked through the RTL8211F broadcast address (Martin) - patch 2: Martin's Reviewed-by Changes since v6: - no Assisted-by trailer (Krzysztof) - patch 2: the T7 gets a binding file of its own (Rob, Sashiko); the pclk description names the glue registers (Krzysztof); rx-internal-delay-ps as constraints, default 0, maximum 3000, multipleOf 200 (Rob); tx-internal-delay-ps stays false, the meta-schema refuses "not" on a top-level property, so the reason is a comment above it (Rob); "snps,dwmac" dropped from the compatible list (Rob) - patch 6: "snps,dwmac" dropped from the node (Rob) - patch 4: Andrew's Reviewed-by Changes since v5: - patch 2: the T7 block follows the Meson8b..G12A block instead of splitting it in two; default: 0 for rx-internal-delay-ps on the T7 (Sashiko). The explicit false lines stay, as asked in review. Changes since v4: - patch 4: the old delay code is left untouched; the T7 only gets a callback of its own, and the probe parsing it shares validates the RX value (Andrew); no NULL check on the callback (Martin) - 0 accepted for rx-internal-delay-ps, the T7 joins the G12A list (Andrew) - comment on the deprecated vendor delay properties (Andrew) - the MDIO mux and the on-chip PHY bus start disabled in the dtsi; the VIM4 enables the mux (Sashiko) Changes since v3: - phy-mode untouched, the PHY adds the 2ns, rx-internal-delay-ps is tuning only, tx-internal-delay-ps not valid for the T7 (Andrew) - 0 dropped from rx-internal-delay-ps (Martin); vendor delay properties explicitly false for the T7 (Andrew) - init_delays callback; patch 4 renamed (Martin, Andrew) - VIM4 without tx-internal-delay-ps, the PHY TX delay works (Martin) - Meson8m2 moved to the dwmac-3.70a list; its boards warn in dtbs_check until Martin's dtsi patch lands (Martin, Conor) - the delay table in ethernet-controller.yaml dropped - Martin's Reviewed-by on patch 3 Changes since v2: - T7-only delay path (Andrew), PHY mode from phy_fix_phy_mode_for_mac_delays() (Maxime) - tx-internal-delay-ps checked against the hardware values (Sashiko) - vendor delay properties not valid for the T7 (Neil, Andrew) - no max-speed on either PHY (Andrew); VIM4 PHY interrupt on GPIOH_6 (Sashiko) - the T7 node owns sys_ethphy as "pclk" - no longer RFC; Conor's Ack dropped from patch 2 and Neil's R-b from patch 6 Changes since v1: - the driver honours the generic delay properties; VIM4 moved to rgmii-id with tx-internal-delay-ps = <2000>, Neil's R-b dropped Lucas Tanure (4): dt-bindings: net: amlogic,g12a-mdio-mux: add the T7 compatible arm64: dts: amlogic: t7: add the ethernet pinctrl nodes arm64: dts: amlogic: t7: add the ethernet controller arm64: dts: amlogic: t7: khadas-vim4: enable the ethernet port .../bindings/net/amlogic,g12a-mdio-mux.yaml | 6 +- .../amlogic/amlogic-t7-a311d2-khadas-vim4.dts | 23 +++++ arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi | 88 +++++++++++++++++++ 3 files changed, 116 insertions(+), 1 deletion(-) base-commit: 7e1392a42ea288d70a266f6553fe06f57f8647ea -- 2.56.1