From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D9F8211494; Tue, 18 Mar 2025 16:21:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742314872; cv=none; b=no33t2NUigypgeIad1LJ3/Nc5vQpkNSiYnc3aczZJgwNV8NKhMLW1EhrLODsC8DpQPcElsDy8sS8ZVwI0HmSrh/oDmtuXWW0AIOFk80VXMcrFtqWN5Vii/Au0S3fkWHw/U5F4ZJKh1zNhV3VvlnfBLFpHHfzfwPor0CtKhL27xg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742314872; c=relaxed/simple; bh=Bu9pqe3Bbm1zR6uodKxbBB2RFuhWJQoXfPrg+m14H28=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ttqpVTUpmqyHvGR7g67v2i0tG9EMSc9xizGgx27OLFgvyIGGRXGt3er0H8+nqpPlmjUMez5th2Z8JY7kz0NzNolNoSWZWamYdbmOyfKBWkCTUu6WM1wgCYgNX1zggVFV4GZueLjF+ABOYFnU5aBD65aKfOVAQ2MmmhoEFefX/Jk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mK7kWhbr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mK7kWhbr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94A5CC4AF0D; Tue, 18 Mar 2025 16:21:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742314871; bh=Bu9pqe3Bbm1zR6uodKxbBB2RFuhWJQoXfPrg+m14H28=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=mK7kWhbrwexLd0AcZH8DK4E6tKOCujoKlSaieXZS6END2BFPwxB5x+ZX7VrWJDG3M TIATQE0hC0kQOFKTZxV3yfPUBg0qZeiAqnzkajjdFoifCB8HCbvG3BkF6yVcjh+pRZ Zawnywm+npJyXLzwASQUteCUhGbb6J6RFcP3vDwAnxjaqEsW9UtG4y+3Mu2yHoPzMt BjZrEfqt8douV0QrMak6FtBqqFVpO5dkykbbFjqQHb3HCoW3q4C5qXBC1Ir51Ry8Vp 8dxSmJfgUNug2d/9hoI9gNY3VMB3uz6I/5Bz2+lkPanGWSYGLWKtWd4LpExXvxV/f1 HPdyEMs8+2MAg== Message-ID: <202b4446-0ce4-4288-8588-6edfc32125d1@kernel.org> Date: Tue, 18 Mar 2025 17:21:02 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] iio: light: bh1750: Add hardware reset support via GPIO To: =?UTF-8?Q?Sergio_P=C3=A9rez?= , linux-iio@vger.kernel.org Cc: tduszyns@gmail.com, jic23@kernel.org, lars@metafoo.de, robh@kernel.org, conor+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20250316145514.627-1-sergio@pereznus.es> <01f48f6d-55a4-4dbe-b1ae-ef8c54dcc1ff@kernel.org> <8992a79d-0859-4d7f-9b47-52e20b11260a@kernel.org> <144b5c43-f8c6-44d1-bcff-83158ac29781@pereznus.es> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <144b5c43-f8c6-44d1-bcff-83158ac29781@pereznus.es> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 18/03/2025 17:06, Sergio Pérez wrote: > > El 18/03/2025 a las 16:16, Krzysztof Kozlowski escribió: >> On 18/03/2025 15:16, Sergio Pérez wrote: >>> Hello, >>> >>> El 17/03/2025 a las 8:24, Krzysztof Kozlowski escribió: >>>> On 16/03/2025 15:55, Sergio Perez wrote: >>>>> Some BH1750 sensors require a hardware reset before they can be >>>>> detected on the I2C bus. This patch adds support for an optional >>>>> reset GPIO that can be specified in the device tree. >>>>> >>>>> The reset sequence pulls the GPIO low and then high before >>>>> initializing the sensor, which enables proper detection with >>>>> tools like i2cdetect. >>>>> >>>>> Update the devicetree binding documentation to include the new >>>>> reset-gpios property with examples. >>>>> >>>>> Signed-off-by: Sergio Perez >>>> Please run scripts/checkpatch.pl and fix reported warnings. After that, >>>> run also `scripts/checkpatch.pl --strict` and (probably) fix more >>>> warnings. Some warnings can be ignored, especially from --strict run, >>>> but the code here looks like it needs a fix. Feel free to get in touch >>>> if the warning is not clear. >> You keep ignoring paragraphs. Did you read this? > > I pass this check several times and every time I do any step to make > sure I am well. > > scripts/checkpatch.pl -f drivers/iio/light/bh1750.c > total: 0 errors, 0 warnings, 354 lines checked That's not how you run checkpatch. Read the submitting patches. Just like the name tells you, check the patch, you run it on the patch. Best regards, Krzysztof