From: Neil Armstrong <neil.armstrong@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
linux-arm-msm@vger.kernel.org, andersson@kernel.org,
agross@kernel.org, krzysztof.kozlowski+dt@linaro.org
Cc: marijn.suijten@somainline.org, Rob Herring <robh+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sm8450: Add missing RPMhPD OPP levels
Date: Tue, 16 May 2023 09:00:13 +0200 [thread overview]
Message-ID: <202dd8d6-363d-e73d-8c91-a0bba411de5b@linaro.org> (raw)
In-Reply-To: <20230516005306.952821-1-konrad.dybcio@linaro.org>
On 16/05/2023 02:53, Konrad Dybcio wrote:
> We need more granularity for things like the GPU. Add the missing levels.
>
> This unfortunately requires some re-indexing, resulting in an ugly diff.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sm8450.dtsi | 26 +++++++++++++++++++-------
> 1 file changed, 19 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> index b4fc6abf8d8a..d3ac5644232b 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> @@ -4195,31 +4195,43 @@ rpmhpd_opp_low_svs: opp4 {
> opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS>;
> };
>
> - rpmhpd_opp_svs: opp5 {
> + rpmhpd_opp_low_svs_l1: opp5 {
> + opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS_L1>;
> + };
> +
> + rpmhpd_opp_svs: opp6 {
> opp-level = <RPMH_REGULATOR_LEVEL_SVS>;
> };
>
> - rpmhpd_opp_svs_l1: opp6 {
> + rpmhpd_opp_svs_l0: opp7 {
> + opp-level = <RPMH_REGULATOR_LEVEL_SVS_L0>;
> + };
> +
> + rpmhpd_opp_svs_l1: opp8 {
> opp-level = <RPMH_REGULATOR_LEVEL_SVS_L1>;
> };
>
> - rpmhpd_opp_nom: opp7 {
> + rpmhpd_opp_svs_l2: opp9 {
> + opp-level = <RPMH_REGULATOR_LEVEL_SVS_L2>;
> + };
> +
> + rpmhpd_opp_nom: opp10 {
> opp-level = <RPMH_REGULATOR_LEVEL_NOM>;
> };
>
> - rpmhpd_opp_nom_l1: opp8 {
> + rpmhpd_opp_nom_l1: opp11 {
> opp-level = <RPMH_REGULATOR_LEVEL_NOM_L1>;
> };
>
> - rpmhpd_opp_nom_l2: opp9 {
> + rpmhpd_opp_nom_l2: opp12 {
> opp-level = <RPMH_REGULATOR_LEVEL_NOM_L2>;
> };
>
> - rpmhpd_opp_turbo: opp10 {
> + rpmhpd_opp_turbo: opp13 {
> opp-level = <RPMH_REGULATOR_LEVEL_TURBO>;
> };
>
> - rpmhpd_opp_turbo_l1: opp11 {
> + rpmhpd_opp_turbo_l1: opp14 {
> opp-level = <RPMH_REGULATOR_LEVEL_TURBO_L1>;
> };
> };
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
next prev parent reply other threads:[~2023-05-16 7:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 0:53 [PATCH] arm64: dts: qcom: sm8450: Add missing RPMhPD OPP levels Konrad Dybcio
2023-05-16 7:00 ` Neil Armstrong [this message]
2023-05-25 4:53 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202dd8d6-363d-e73d-8c91-a0bba411de5b@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).