From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-b3-smtp.messagingengine.com (fhigh-b3-smtp.messagingengine.com [202.12.124.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05890388393; Wed, 16 Sep 2026 13:16:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.154 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789564612; cv=none; b=EdSUhbs3vrg5BhPcSYtntBhw78ZxGo8sQrF3VyQ6/tpbXB5GFXkMduyvTMFv7V82QNlojoIYEMJH072BrM1v3uYUMWledQC83d7rDPPZhDcPmWa4hOkqgRVAjpeO/EyA7ed6N6gVQBBXHUGS+bDiVbm3POdXOTCmJzelwumWhok= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789564612; c=relaxed/simple; bh=AxW40EfCF8iZErYl8W5+AI0CzKP1ft3cVU4kgfc4iNw=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=awCwM6aC8k22Hu/Uug7Wh7Bc2zrHtnvKqCUVZVMOiWvxu/aOd1+rCfdg715FUqJsxiORKX+UenbTUK06jwM1jsUdz+0H5LDn5xU22qQgLHqSNj5Gy/nyd3VQlPsRcvoB+58QVUpYk6UlAbQwI+71y7TuI2fhhBUvvGKd94SIBIw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b=Ap2Qh3ls; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=lEjeA3Ih; arc=none smtp.client-ip=202.12.124.154 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="Ap2Qh3ls"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="lEjeA3Ih" Received: from ams-compute-01.internal (ams-compute-01.internal [10.64.2.61]) by mailfhigh.stl.internal (Postfix) with ESMTP id 6A1867A0100; Wed, 16 Sep 2026 09:16:48 -0400 (EDT) Received: from ams-imap-03 ([10.64.2.23]) by ams-compute-01.internal (MEProxy); Wed, 16 Sep 2026 09:16:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1789564607; x=1789651007; bh=jKavffle4neT9GMaTZ2rSYi6SqO6U6tssCdaO32SjGg=; b= Ap2Qh3lsL4M3EfUXfTW7gVuBEpKnY3dKxMp9Z+iqyQvb4pOksZY6Z58FU6gqKOCJ QWBVy2OkVnPeYuQ6V3xOe2qyL7YbAiIE9rmUMP98oQ2O79qBKDmfru8MbT4RPqLr LyrzLEUUVIWfIY167OqwFgKjiCmpCBBYLvbjfUR8KJJXSW7mCgY9YnQj+cH7Wp3C QkdkZiw0fwch2mBMIYSmWNX2v/ZJ/04OvS582CUIa4JNpje7DoZnQFkxsvFsFWXt t1dVHoHkesB2+v+HfUtw7LiBFyhds3jBlJ2l7hXAn++Qij8jXaPAhEM/CBHKSdTW w/47aBOnx0CmHMdfkwhc6w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1789564607; x= 1789651007; bh=jKavffle4neT9GMaTZ2rSYi6SqO6U6tssCdaO32SjGg=; b=l EjeA3IhxJxD4GtJ78eF/7QPZTqfE89I0Ik7Up/wEXFwjD7Evb6a1G0CXJbX2/hd0 pJPu1JqCjsZO9S3hfux7iJ/dUak3WjYV5z2IVU2dPrtk14UXaFyvxH/FiaDKjdQv aPa5L+T6yQdXMabLfX9t3en+BnnuaDl7Tx0FEnAQWGxuHMFDAai0kB90PRg5mkp2 d67UVdhgcZxb7HmjrGIrlUFjJ66bMZxrQ+aKkcTE4QxuboK00cY1O2wErtd1uSD6 sWLmynMWKzbRiZVjpX86SJ3sKL+iDAqXdJQmo9m5TfzrFxtWF6vlaR/oPCnpGIRl l1C5ZaBms3TIyPTAvkpAw== X-ME-Sender: X-ME-Proxy-Cause: dmFkZTFnplgyCo8M36BD8SpLaZmp7STqRcXPok5KtM5tUgC1ZV7i/mvJqoZoGQWaQj7pMw 0nWk/oGrv9BgYuiSHl1wpjttdvYQ/Emrd3tM8Q/TAa4EECiIC+uIQb6kmQUm3849C0kuBn o8h981T+Al4QsogzbVxkXZxhOtfKS8sC8+DxyEdhnEQ8RmknuGVsYuIz9DkMGD2N4T7zxS c09z2RVKAeD+VuXdhAJObk+oAxJBBp1o5bXRH23PPvWlLQw176ixJEiA5O838te8cIiRjB OQa+0bLw/hqvqkB5RZsa5cHTrDUpjkgRPQCGH29/Re0FaZgGDkXClrr64kLzWTuVHtzxJ9 gd7Qdja1y8K25wWnQQK6ErNwxrFwNmCvvRSlIHTrPN+XHGUOp2nQwOz+5WK6l0Ye2+tXby Ll2U9gqjjb/yn/Jo1ZUpz62Nc+5FXiXb+9GByAeRmxrZowwsLJ2AsTATTJPiqvLoHj5KWF SvH+BRdTbkRPz+pkHDfIpSZvYFqHhqhnD5acBq0cq7cuJzKY5tU5ZwxF2BXfssS0yEaA27 DtEra7+7UaGjyabi/du39U+Brvp1woct6HCRh17BHE9NBuEqg9Wy0TGiYU3PIsbq88Y9/n X0y5qNnIsDd8W0xwF4DHegggig6nRRJ1+5EMXvr6h9EWgcnrFNizH6HXuBSQ X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.ams.internal (Postfix, from userid 501) id BBF9D32A0084; Wed, 16 Sep 2026 09:16:41 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: AcI4sQW32jCJ Date: Wed, 16 Sep 2026 15:16:13 +0200 From: "Arnd Bergmann" To: pankaj.gupta@oss.nxp.com, "Jonathan Corbet" , "Shuah Khan" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Frank Li" , "Sascha Hauer" , "Pengutronix Kernel Team" , "Fabio Estevam" , "Pankaj Gupta" , "Randy Dunlap" Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Message-Id: <2034fb2f-f169-46a5-85e8-fa723ddb0360@app.fastmail.com> In-Reply-To: <20260915-imx-se-if-v51-5-4a7dac612cb5@nxp.com> References: <20260915-imx-se-if-v51-0-4a7dac612cb5@nxp.com> <20260915-imx-se-if-v51-5-4a7dac612cb5@nxp.com> Subject: Re: [PATCH v51 5/7] firmware: imx: adds miscdev Content-Type: text/plain Content-Transfer-Encoding: 7bit On Mon, Sep 14, 2026, at 21:40, pankaj.gupta@oss.nxp.com wrote: > From: Pankaj Gupta > > Adds the driver for communication interface to secure-enclave, that > enables exchanging messages with NXP secure enclave HW IP(s) > like EdgeLock Enclave, from: > - User-Space Applications via character driver. > > ABI documentation for the NXP secure-enclave driver. I just saw this in linux-next, where it has caused a build failure for a missing include of linux/slab.h. I hadn't see the series before (even though it is a v51, which seems crazy), but I am curious about it now. > User-space library using this driver: > - i.MX Secure Enclave library: > -- URL: https://github.com/nxp-imx/imx-secure-enclave.git, > - i.MX Secure Middle-Ware: > -- URL: https://github.com/nxp-imx/imx-smw.git I assume this will hit the soc tree eventually, so I want to make sure the reviews have covered all the important aspects here, and I don't see the answers in the cover letter: - Who has reviewed the user interface from outside of NXP? Since this is not a vendor-independent API, I think we have to be extra careful and make sure this does not duplicate anything that is already in the standard firmware interfaces. - Why is there a low-level passthrough to the firmware from userspace? This looks rather irregular, since it is the kernel's job to abstract the platform and provide vendor-independent interfaces. In particular the bit about shared memory and the generic send/receiv ioctl look like they should not be there, as those would allow side-channels from userspace. Arnd