From: Heiko Stuebner <heiko@sntech.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
zhengyang@rock-chips.com, linux-arm-kernel@lists.infradead.org,
kishon@ti.com
Subject: Re: [PATCH v4 2/2] phy: add Rockchip Innosilicon hdmi phy
Date: Fri, 07 Sep 2018 12:35:24 +0200 [thread overview]
Message-ID: <2035629.dANnXaNfxq@phil> (raw)
In-Reply-To: <81c527fc-5837-658f-5c57-60acd909ed2e@arm.com>
Am Freitag, 7. September 2018, 10:58:04 CEST schrieb Robin Murphy:
> On 2018-09-06 2:50 PM, Heiko Stuebner wrote:
> > From: Zheng Yang <zhengyang@rock-chips.com>
> >
> > Add a driver for the Innosilicon hdmi phy used on rk3228/rk3229
> > and rk3328 socs from Rockchip.
> >
> > Signed-off-by: Zheng Yang <zhengyang@rock-chips.com>
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > Tested-by: Robin Murphy <robin.murphy@arm.com>
>
> That reminds me, I really must dig out that box again and finish
> figuring out the GPIOs and regulators... :)
>
> [...]
> > +static int inno_hdmi_phy_probe(struct platform_device *pdev)
> > +{
> > + struct inno_hdmi_phy *inno;
> > + const struct of_device_id *match;
> > + struct phy_provider *phy_provider;
> > + struct resource *res;
> > + void __iomem *regs;
> > + int ret;
> > +
> > + inno = devm_kzalloc(&pdev->dev, sizeof(*inno), GFP_KERNEL);
> > + if (!inno)
> > + return -ENOMEM;
> > +
> > + inno->dev = &pdev->dev;
> > +
> > + match = of_match_device(inno->dev->driver->of_match_table, inno->dev);
> > + inno->plat_data = (struct inno_hdmi_phy_drv_data *)match->data;
>
> Nit: if there's cause to do another respin anyway, you could simplify
> this part with of_device_get_match_data().
done in v6 ... I found your mail directly after sending v5 ;-) .
next prev parent reply other threads:[~2018-09-07 10:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 13:50 [PATCH v4 1/2] dt-bindings: add binding for Rockchip hdmi phy using an Innosilicon IP Heiko Stuebner
2018-09-06 13:50 ` [PATCH v4 2/2] phy: add Rockchip Innosilicon hdmi phy Heiko Stuebner
2018-09-07 8:18 ` Kishon Vijay Abraham I
2018-09-07 8:58 ` Robin Murphy
2018-09-07 10:35 ` Heiko Stuebner [this message]
2018-09-07 10:38 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2035629.dANnXaNfxq@phil \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robin.murphy@arm.com \
--cc=zhengyang@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).