From mboxrd@z Thu Jan 1 00:00:00 1970 From: saiprakash.ranjan@codeaurora.org Subject: Re: [PATCH 2/3] coresight: etm4x: Add support to enable ETMv4.2 Date: Sat, 12 Jan 2019 18:03:57 +0530 Message-ID: <2039d8fcb6c09efeeb5df3f373a4d6dd@codeaurora.org> References: <4cb23e3bc414f3a1cac555d27b93e7e8cfeb68c9.1547054308.git.saiprakash.ranjan@codeaurora.org> <20190111185242.GB22691@xps15> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190111185242.GB22691@xps15> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Mathieu Poirier Cc: Mark Rutland , devicetree@vger.kernel.org, Rajendra Nayak , Suzuki K Poulose , Alexander Shishkin , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, David Brown , Rob Herring , Sibi Sankar , Vivek Gautam , Leo Yan , Andy Gross , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org Hi Mathieu, > I think it would be better to simply mask out the minor version number > bits in > function etm4_arch_supported(). That way we can add more intelligence > in there > in the future if we have to and we don't have to touch the calling code > again. > Thanks for the review. Yes it seems good, I will make this change in next version of the patch. - Sai