Re: [PATCH 2/4] dt-bindings: leds: Add YAML bindings for Virtual Color LED Group driver

[Krzysztof Kozlowski <krzk@kernel.org>]

On 09/10/2025 17:43, Jonathan Brophy wrote:
> From: Jonathan Brophy <professor_jonny@hotmail.com>
> 
> Document Virtual Color device tree bindings.
> 
> Co Signed-off-by: Radoslav Tsvetkov <rtsvetkov@gradotech.eu>

Messed SoB chain... plus corrupted tag. Please look at submitting
patches what should be written here.

> Signed-off-by: Jonathan Brophy <professor_jonny@hotmail.com>
> ---
>  .../leds/leds-group-virtualcolor.yaml         | 88 +++++++++++++++++++
>  1 file changed, 88 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/leds/leds-group-virtualcolor.yaml
> 
> diff --git a/Documentation/devicetree/bindings/leds/leds-group-virtualcolor.yaml b/Documentation/devicetree/bindings/leds/leds-group-virtualcolor.yaml
> new file mode 100644
> index 000000000..945058415
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-group-virtualcolor.yaml
> @@ -0,0 +1,88 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/leds-group-virtualcolor.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +title: Virtual LED Group with Priority Control


Bindings describe real hardware, not virtual arrangements. At least
usually. You need to make a case in the commit msg why we want exception
from standard rule.

> +
> +maintainers:
> +  - Radoslav Tsvetkov <rtsvetkov@gradotech.eu>
> +
> +description: |
> +  Virtual LED group driver that combines multiple monochromatic LEDs into


For sure we do not describe drivers here. Describe hardware or
system/board-level concept.

> +  logical groups with priority-based control. The driver ensures only the
> +  highest-priority LED state is active at any given time.
> +
> +allOf:
> +  - $ref: common.yaml#
> +
> +properties:
> +  compatible:
> +    const: leds-group-virtualcolor
> +
> +  '#address-cells':
> +    const: 1
> +
> +  '#size-cells':
> +    const: 0
> +
> +required:
> +  - compatible
> +
> +patternProperties:
> +  '^led@[0-9a-f]$':
> +    type: object
> +    $ref: common.yaml#
> +    properties:
> +      reg:
> +        maxItems: 1
> +        description: Virtual LED number
> +
> +      monochromatic-leds:
> +        $ref: /schemas/types.yaml#/definitions/phandle
> +        description: List of phandles to the monochromatic LEDs to group

You allow only one phandle, not list, so this is confusing.

> +
> +      priority:
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        description: Priority level for LED activation
> +                     (higher value means higher priority)
> +
> +      blink-delay-on:
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        description: Time in milliseconds the LED is on during blink

Time in ms is expressed with proper unit suffix.

Isn't there standard property for this?

> +
> +      blink-delay-off:
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        description: Time in milliseconds the LED is off during blink
> +
> +    required:
> +      - reg
> +      - monochromatic-leds
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    led-controller {
> +        compatible = "leds-group-virtualcolor";
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        led@0 {
> +            reg = <0>;
> +            label = "status:red";

Use color and function instead.

> +            monochromatic-leds = <&led_red>;
> +            priority = <2>;
> +            blink-delay-on = <500>;
> +            blink-delay-off = <500>;
> +        };
> +
> +        led@1 {
> +            reg = <1>;
> +            label = "status:green";
> +            monochromatic-leds = <&led_green>;
> +            priority = <1>;
> +        };
> +    };
> +
> \ No newline at end of file

You have patch warnings.

Best regards,
Krzysztof