From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86CE54A0C; Thu, 20 Mar 2025 12:40:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742474412; cv=none; b=IT0UIv1RwympUkMlSuzmCHwtzDR1e3B3Z2gkWBPyasbxUqEBEr+ufvzIjnQHG0iv7euwI4xALmI+l7T4Waw84KEpS5NbYEn+iXafIQ+yqLafZDDP2D/eMi8gv/Y/hhG3yrNk+8OuPPYvU8SOSTALJXiEmcjYSO1V2Wvpoo/zig4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742474412; c=relaxed/simple; bh=dSb1rGkUWH+O9PKTS5kcXjpzSzAoMTGvjKFlYsZAbIU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Q375/fEo8rUrj1Ze4bBcnmjmpdzAV728Wz+oqyehg0BI+YieuRUw1PL5ag5tzYKm6i6Km5Ad69xUms0DqbIOcRs9zT1p1xai4nX1H7QGdc3eFfOF+Amz+kMPJbwC+HWJldSoJ7NvmV2yEn7IDRdQkFkMOe233EYGFM643haopXQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=cDZSPhtQ; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="cDZSPhtQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1742474408; bh=dSb1rGkUWH+O9PKTS5kcXjpzSzAoMTGvjKFlYsZAbIU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=cDZSPhtQdKCk9SSLCW0czIQ9yP7K095pjew+9ZpZDJDKONmX5x2jONkHAlQJtx4uQ o9rfqITPbXCkGRMBj5CPsl9zPbzVAFNf5J51mFB6gXfQEC7CsBSJuzqDFEJ1eG7/zc S2UrL16vN+bnhKwO8Aw19KtICy+DvbAixpJV9bTxx8MhMn94/lGhyKUIybjqBfXAbM sS1tXxCwunamUN2EYuHcvT8TPTAauxN+LIoRdkFVi3h+NPOdSoivheZMvA6k0lveEF 3oQp00h1eyvJ+wXw689tq3XyK7UJ5xcEqhMUpk9X3o7m2R78dQEG8NfaGj3znYDaSb n+wIi0IOQ2rRg== Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id 4A62B17E0607; Thu, 20 Mar 2025 13:40:07 +0100 (CET) Message-ID: <204c40d5-de0f-42d0-bc86-d17606c4929f@collabora.com> Date: Thu, 20 Mar 2025 13:40:06 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] ASoC: SOF: MediaTek: Add mt8196 hardware support To: Krzysztof Kozlowski , "hailong.fan" Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Daniel Baluta , Kai Vehmanen , Pierre-Louis Bossart , Mark Brown , Jaroslav Kysela , Takashi Iwai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, sound-open-firmware@alsa-project.org, linux-sound@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com, Jjian.Zhou@mediatek.com, Xiangzhi.Tang@mediatek.com References: <20250320031753.13669-1-hailong.fan@mediatek.com> <20250320031753.13669-2-hailong.fan@mediatek.com> <20250320-cocky-adventurous-rooster-be2abd@krzk-bin> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20250320-cocky-adventurous-rooster-be2abd@krzk-bin> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Il 20/03/25 08:52, Krzysztof Kozlowski ha scritto: > On Thu, Mar 20, 2025 at 11:17:24AM +0800, hailong.fan wrote: >> + >> +void mt8196_sof_hifixdsp_shutdown(struct snd_sof_dev *sdev) >> +{ >> + /* set RUNSTALL to stop core */ >> + snd_sof_dsp_update_bits(sdev, DSP_REG_BAR, ADSP_HIFI_RUNSTALL, >> + RUNSTALL, RUNSTALL); >> + >> + /* assert core reset */ >> + snd_sof_dsp_update_bits(sdev, DSP_REG_BAR, ADSP_CFGREG_SW_RSTN, >> + SW_RSTN_C0 | SW_DBG_RSTN_C0, >> + SW_RSTN_C0 | SW_DBG_RSTN_C0); >> +} >> + > > Drop stray blank line. > >> diff --git a/sound/soc/sof/mediatek/mt8196/mt8196.c b/sound/soc/sof/mediatek/mt8196/mt8196.c >> new file mode 100644 >> index 000000000000..364069ce9954 >> --- /dev/null >> +++ b/sound/soc/sof/mediatek/mt8196/mt8196.c >> @@ -0,0 +1,650 @@ >> +// SPDX-License-Identifier: GPL-2.0 > > Look here > >> +/* >> + * Copyright (c) 2025 MediaTek Inc. >> + * Author: Hailong Fan >> + */ > > ... > >> + >> +static const struct of_device_id sof_of_mt8196_ids[] = { >> + { .compatible = "mediatek,mt8196-dsp", .data = &sof_of_mt8196_desc}, > > Bindings are before users. > >> + { } >> +}; >> +MODULE_DEVICE_TABLE(of, sof_of_mt8196_ids); >> + >> +/* DT driver definition */ >> +static struct platform_driver snd_sof_of_mt8196_driver = { >> + .probe = sof_of_probe, >> + .remove = sof_of_remove, >> + .shutdown = sof_of_shutdown, >> + .driver = { >> + .name = "sof-audio-of-mt8196", >> + .pm = &sof_of_pm, >> + .of_match_table = sof_of_mt8196_ids, >> + }, >> +}; >> +module_platform_driver(snd_sof_of_mt8196_driver); >> + >> +MODULE_LICENSE("Dual BSD/GPL"); > > And here Hm? Don't fake the licensing. > >> +MODULE_DESCRIPTION("SOF support for MT8196 platforms"); >> +MODULE_IMPORT_NS("SND_SOC_SOF_XTENSA"); > > Is this correct? > The import namespace you mean? yes, that's for sof_xtensa_arch_ops :-) Cheers > > Best regards, > Krzysztof >