public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Shaohui Xie <shaohui.xie@nxp.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Mihai Emilian Bantea <mihai.bantea@nxp.com>,
	"pawel.moll@arm.com" <pawel.moll@arm.com>,
	"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	Zhiqiang Hou <zhiqiang.hou@nxp.com>,
	"will.deacon@arm.com" <will.deacon@arm.com>,
	Minghuan Lian <minghuan.lian@nxp.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	Mingkai Hu <mingkai.hu@nxp.com>,
	"galak@codeaurora.org" <galak@codeaurora.org>,
	Qianyu Gong <qianyu.gong@nxp.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/5] arm64: dts: add QorIQ LS1046A SoC support
Date: Tue, 23 Aug 2016 12:04:00 +0200	[thread overview]
Message-ID: <2061455.WN6nWWqTiZ@wuerfel> (raw)
In-Reply-To: <DB5PR0401MB21834BD67F0EA86B3A22E9D6E8150@DB5PR0401MB2183.eurprd04.prod.outlook.com>

On Thursday, August 18, 2016 10:27:36 AM CEST Shaohui Xie wrote:
> Hello Arnd,
> 
> Thank you for reviewing!
> 
> I'm seriously Sorry for the late response! I was on business travel on a project and had been very busy for a  long time.

No worries.

> > -----Original Message-----
> > From: Arnd Bergmann [mailto:arnd@arndb.de]
> > Sent: Friday, July 08, 2016 8:00 PM
> > On Friday, July 8, 2016 6:15:40 PM CEST shh.xie@gmail.com wrote:
> > > +
> > > +   memory@80000000 {
> > > +           device_type = "memory";
> > > +           reg = <0x0 0x80000000 0 0x80000000>;
> > > +                 /* DRAM space 1, size: 2GiB DRAM */
> > > +   };
> > 
> > The memory size is usually in the .dts file, unless this is on-chip eDRAM.
> [S.H] The memory size will be fixup by U-boot, if it's not proper to have it in .dtsti,
> How about remove it?
> 

Sounds fine to me. A lot of board specific files have a memory node
regardless of the override, but I don't see a reason to require it.

	Arnd

  reply	other threads:[~2016-08-23 10:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-08 10:15 [PATCH 0/5] arm64: dts: add QorIQ LS1046A SoC and boards support shh.xie
2016-07-08 10:15 ` [PATCH 1/5] arm64: dts: add QorIQ LS1046A SoC support shh.xie
     [not found]   ` <1467972944-12293-2-git-send-email-shh.xie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-07-08 12:00     ` Arnd Bergmann
2016-08-18 10:27       ` Shaohui Xie
2016-08-23 10:04         ` Arnd Bergmann [this message]
2016-07-08 10:15 ` [PATCH 2/5] Documentation: DT: Add entry for QorIQ LS1046A-RDB board shh.xie
     [not found]   ` <1467972944-12293-3-git-send-email-shh.xie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-07-16  0:08     ` Rob Herring
2016-07-08 10:15 ` [PATCH 3/5] arm64: dts: add LS1046A-RDB board support shh.xie
2016-07-08 10:15 ` [PATCH 4/5] Documentation: DT: Add entry for QorIQ LS1046A-QDS board shh.xie
     [not found]   ` <1467972944-12293-5-git-send-email-shh.xie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-07-16  0:09     ` Rob Herring
2016-07-08 10:15 ` [PATCH 5/5] arm64: dts: add LS1046A-QDS board support shh.xie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2061455.WN6nWWqTiZ@wuerfel \
    --to=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=mihai.bantea@nxp.com \
    --cc=minghuan.lian@nxp.com \
    --cc=mingkai.hu@nxp.com \
    --cc=pawel.moll@arm.com \
    --cc=qianyu.gong@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=shaohui.xie@nxp.com \
    --cc=will.deacon@arm.com \
    --cc=zhiqiang.hou@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox