From: Tomasz Figa <tomasz.figa@gmail.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
"lee.jones@linaro.org" <lee.jones@linaro.org>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
Pawel Moll <Pawel.Moll@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ian.campbell@citrix.com>,
Rob Landley <rob@landley.net>,
Samuel Ortiz <sameo@linux.intel.com>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Jonghwa Lee <jonghwa3.lee@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
"open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] max77693: added device tree support
Date: Fri, 23 Aug 2013 22:36:10 +0200 [thread overview]
Message-ID: <2068495.b8bxEK36PI@flatron> (raw)
In-Reply-To: <20130823141433.GI25856@e106331-lin.cambridge.arm.com>
Hi Mark,
On Friday 23 of August 2013 15:14:33 Mark Rutland wrote:
> On Wed, Aug 21, 2013 at 05:53:34PM +0100, Andrzej Hajda wrote:
> > This patch adds only of_match_table.
> > There are no device specific properties.
>
> Could you clarify what functionality this enables and what it doesn't,
> please?
This patch simply adds explicit OF match table for this device. Before,
the driver could be matched only by a fallback to i2c_device_id table.
> This doesn't seem to enable support for the regulators described in the
> binding [1] (which from the looks of it needs proof-reading and possibly
> rework).
>
> Are there any changes we might need in future to either support new
> functionality or to generalise the binding. e.g. do we need a regulator
> for the LED?
>
> Given the binding has never been supported, are we happy now that it
> best represents the hardware, or are there avenues of improvement
> *before* it becomes ABI?
Well, documentation of the binding has been present in kernel tree since
June, but I too think that we should review it and make sure it makes
sense. I'll try to get some information on this chip at work, on Monday.
Best regards,
Tomasz
next prev parent reply other threads:[~2013-08-23 20:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 16:53 [PATCH v3 0/2] max77693: added device tree support Andrzej Hajda
2013-08-21 16:53 ` [PATCH v3 1/2] max77693: remove device wakeup from driver Andrzej Hajda
2013-09-26 12:00 ` Andrzej Hajda
[not found] ` <1377104014-21910-2-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-09-27 7:29 ` Lee Jones
2013-08-21 16:53 ` [PATCH v3 2/2] max77693: added device tree support Andrzej Hajda
2013-08-23 14:14 ` Mark Rutland
2013-08-23 20:36 ` Tomasz Figa [this message]
2013-08-23 20:08 ` Tomasz Figa
2013-09-06 10:50 ` Mark Brown
2013-09-26 12:05 ` Andrzej Hajda
[not found] ` <1377104014-21910-3-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-09-27 7:17 ` Lee Jones
2013-09-27 7:27 ` [PATCH v4 " Andrzej Hajda
[not found] ` <1380266866-32103-1-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-09-27 8:11 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2068495.b8bxEK36PI@flatron \
--to=tomasz.figa@gmail.com \
--cc=Pawel.Moll@arm.com \
--cc=a.hajda@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=jonghwa3.lee@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=s.nawrocki@samsung.com \
--cc=sameo@linux.intel.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).