From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v2 1/2] Documentation: DT: bindings: Add Broadcom STB PCIe bindings Date: Mon, 09 May 2016 15:12:12 +0200 Message-ID: <20692845.Ts1cTL7t9V@wuerfel> References: <1462475700-1654-1-git-send-email-f.fainelli@gmail.com> <4513390.VWu0VVAxOl@wuerfel> <572BBF2E.5010606@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <572BBF2E.5010606@broadcom.com> Sender: linux-pci-owner@vger.kernel.org To: Florian Fainelli Cc: Florian Fainelli , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, bhelgaas@google.com List-Id: devicetree@vger.kernel.org On Thursday 05 May 2016 14:46:22 Florian Fainelli wrote: > > > > >> +- brcm,gen: integer that indicates desired forced generation of link: 1 => 2.5 > >> + Gbps, 2 => 5.0 Gbps, 3 => 8.0 Gbps. Will override the auto-negotation if > >> + specified. > > > > to repeat my earlier comment from v1: > > > > Shouldn't the link generation be probed automatically? > > It is, but if the property is present, we can foce the link negotiation, > We have had cases where this was desired and helpful. > Right, I missed that this is listed as 'optional', so that seems perfectly fine. Thanks, Arnd