public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Simon Horman <horms@verge.net.au>,
	Magnus Damm <magnus.damm@gmail.com>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	Marek Vasut <marek.vasut@gmail.com>,
	linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] ARM: dts: stout: Convert to new LVDS DT bindings
Date: Mon, 03 Dec 2018 23:48:50 +0200	[thread overview]
Message-ID: <2069641.6dBh1jlBqR@avalon> (raw)
In-Reply-To: <20181203151242.25875-2-geert+renesas@glider.be>

Hi Geert,

Thank you for the patch.

On Monday, 3 December 2018 17:12:41 EET Geert Uytterhoeven wrote:
> As of commit 6d2ca85279becdff ("dt-bindings: display: renesas: Deprecate
> LVDS support in the DU bindings"), the internal LVDS encoder has DT
> bindings separate from the DU.  The Lager device tree was ported over to
> the new model, but the Stout device tree was forgotten.
> 
> Fixes: 15a1ff30d8f9bd83 ("ARM: dts: r8a7790: Convert to new LVDS DT
> bindings") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Compile-tested only.

I can't test the patch either but it looks fine to me.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

I assume you will send this directly to Simon, so I don't plan to take the 
patch in my tree.

> ---
>  arch/arm/boot/dts/r8a7790-stout.dts | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/r8a7790-stout.dts
> b/arch/arm/boot/dts/r8a7790-stout.dts index
> 629da4cee1b971d6..7a7d3b84d1a6b21d 100644
> --- a/arch/arm/boot/dts/r8a7790-stout.dts
> +++ b/arch/arm/boot/dts/r8a7790-stout.dts
> @@ -94,9 +94,8 @@
>  	status = "okay";
> 
>  	clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>, <&cpg CPG_MOD 722>,
> -		 <&cpg CPG_MOD 726>, <&cpg CPG_MOD 725>,
>  		 <&osc1_clk>;
> -	clock-names = "du.0", "du.1", "du.2", "lvds.0", "lvds.1", "dclkin.0";
> +	clock-names = "du.0", "du.1", "du.2", "dclkin.0";
> 
>  	ports {
>  		port@0 {
> @@ -104,11 +103,21 @@
>  				remote-endpoint = <&adv7511_in>;
>  			};
>  		};
> +	};
> +};
> +
> +&lvds0 {
> +	ports {
>  		port@1 {
>  			lvds_connector0: endpoint {
>  			};
>  		};
> -		port@2 {
> +	};
> +};
> +
> +&lvds1 {
> +	ports {
> +		port@1 {
>  			lvds_connector1: endpoint {
>  			};
>  		};

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2018-12-03 21:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-03 15:12 [PATCH 0/2] arm: dts: renesas: Convert remaining boards to new LVDS DT bindings Geert Uytterhoeven
2018-12-03 15:12 ` [PATCH 1/2] ARM: dts: stout: Convert " Geert Uytterhoeven
2018-12-03 21:48   ` Laurent Pinchart [this message]
2018-12-03 22:24     ` Marek Vasut
2018-12-03 22:48       ` Laurent Pinchart
2018-12-05  1:10         ` Marek Vasut
2018-12-05  5:41           ` Laurent Pinchart
2018-12-07 18:36             ` Marek Vasut
2018-12-10 12:03               ` Simon Horman
2018-12-03 15:12 ` [PATCH 2/2] arm64: dts: renesas: r8a7796: salvator-xs: " Geert Uytterhoeven
2018-12-03 21:51   ` Laurent Pinchart
2018-12-10 12:04     ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2069641.6dBh1jlBqR@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=horms@verge.net.au \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=marek.vasut@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox