From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org
Cc: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
lftan-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org,
jslaby-IBi9RG/b67k@public.gmane.org,
peter-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org,
andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
anton.wuerfel-d40JDW7QUjc@public.gmane.org,
phillip.raffeck-d40JDW7QUjc@public.gmane.org,
yegorslists-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org,
matwey-TTlVxmypnbovJsYlp49lxw@public.gmane.org,
mail-APzI5cXaD1zVlRWJc41N0YvC60bnQu0Y@public.gmane.org,
peter.ujfalusi-l0cyMroinI0@public.gmane.org,
jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
dongsheng.wang-3arQi8VN3Tc@public.gmane.org,
luis-HiykPkW1eAzzDCI4PIEvbQC/G2K4zDHf@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
tthayer.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
nios2-dev-g9ZBwUv/Ih/yUk5EbOjzuce+I+R0W71w@public.gmane.org
Subject: Re: [PATCH 2/4] serial: 8250: of: Load TX FIFO Load Size from DT
Date: Fri, 16 Sep 2016 22:51:54 +0200 [thread overview]
Message-ID: <2077078.euc60HfglH@wuerfel> (raw)
In-Reply-To: <2e79f6cc-8d9a-b9b7-884c-6916b2e74d64-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
On Friday, September 16, 2016 3:52:55 PM CEST Thor Thayer wrote:
> >
> >
> Yes, I originally had it implemented using that function but then I
> realized the port8250.tx_loadsz is an unsigned int and therefore can
> change size on different platforms.
>
> The assignment handles that. In retrospect, I should probably change
> this to a of_property_read_u8() anyway so that it won't cause compile
> warnings in the smaller architectures.
>
> Thank you for reviewing and the comments.
We don't support architectures with 'int' types other than 32 bits,
so the version that Rob suggested is guaranteed to work everywhere.
Using u8 properties seems like a bad idea in general, better stay
with 32-bit units for consistency.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-09-16 20:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 16:12 [PATCH 0/4] Add TX FIFO Threshold for Altera 16550-FIFOxx tthayer
[not found] ` <1473351141-9239-1-git-send-email-tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2016-09-08 16:12 ` [PATCH 1/4] Documentation: dt: serial: Add TX FIFO load size tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
2016-09-16 19:19 ` Rob Herring
2016-09-16 20:47 ` Thor Thayer
2016-09-08 16:12 ` [PATCH 2/4] serial: 8250: of: Load TX FIFO Load Size from DT tthayer
2016-09-16 19:20 ` Rob Herring
2016-09-16 20:52 ` Thor Thayer
[not found] ` <2e79f6cc-8d9a-b9b7-884c-6916b2e74d64-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2016-09-16 20:51 ` Arnd Bergmann [this message]
2016-09-08 16:12 ` [PATCH 3/4] serial: 8250: Set Altera 16550 TX FIFO Threshold tthayer
2016-09-08 16:12 ` [PATCH 4/4] nios2: dts: 10m50: Add tx-loadsz parameter tthayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2077078.euc60HfglH@wuerfel \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=anton.wuerfel-d40JDW7QUjc@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dongsheng.wang-3arQi8VN3Tc@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=jslaby-IBi9RG/b67k@public.gmane.org \
--cc=lftan-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=luis-HiykPkW1eAzzDCI4PIEvbQC/G2K4zDHf@public.gmane.org \
--cc=mail-APzI5cXaD1zVlRWJc41N0YvC60bnQu0Y@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=matwey-TTlVxmypnbovJsYlp49lxw@public.gmane.org \
--cc=nios2-dev-g9ZBwUv/Ih/yUk5EbOjzuce+I+R0W71w@public.gmane.org \
--cc=peter-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org \
--cc=peter.ujfalusi-l0cyMroinI0@public.gmane.org \
--cc=phillip.raffeck-d40JDW7QUjc@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org \
--cc=tthayer.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=yegorslists-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).