Re: [PATCH v3 1/2] gpio: davinci: Add keystone-k2g compatible

[Suman Anna <s-anna@ti.com>]

On 08/01/2017 01:12 AM, Vignesh R wrote:
> 
> 
> On Monday 31 July 2017 07:14 PM, Keerthy wrote:
>>
>>
>> On Wednesday 26 July 2017 07:50 PM, Suman Anna wrote:
>>> On 07/26/2017 08:36 AM, Keerthy wrote:
>>>>
>>>> On Wednesday 26 July 2017 06:57 PM, Franklin S Cooper Jr wrote:
>>>>>
>>>>>
>>>>> On 07/26/2017 08:00 AM, Suman Anna wrote:
>>>>>> Hi Keerthy,
>>>>>>
>>>>>> On 07/26/2017 01:45 AM, Keerthy wrote:
>>>>>>> The patch adds keystone-k2g compatible, specific properties and
>>>>>>> an example.
>>>>>
> [...]
>>>>>>
>>>>>
>>>>> What about power-domain property?
>>>
>>> The correct name is "power-domains".
>>>
>>>> Driver has no pm_runtime implemented yet.
>>>
>>> True, not yet, but this is in general a required property on K2G SoCs to
>>> automatically enable clocks through runtime_pm. Clock properties on K2G
>>> nodes should only be truly required if a driver is using clk API
>>> (ideally to control optional clocks or for adjusting clock frequencies).
>>> When the gpio-davinci driver gets updated to use pm_runtime, the clock
>>> properties will be rendered obsolete for K2G.
>>>
>>> Rob,
>>> Any suggestions on how we need to handle this? Should we be adding the
>>> property now or later when we adapt the driver for runtime_pm? This
>>> would be a common theme for K2G nodes that are reusing Davinci drivers.
>>>
>>> My take on this would be to add the property now, and mark the clock
>>> properties obsolete when the driver gets converted.
>>
> 
> I don't think SoC wide properties are put into device specific binding
> documentation, for example pinctrl bindings are not put into device
> documentation.

I wouldn't compare this to pinctrl bindings exactly but more similar to
clocks or the ti,hwmods on OMAP/AM platforms. I see lot of other
bindings documenting the power-domains property just as well.

regards
Suman

> 
>> Rob,
>>
>> Any comments on this?
>>
> 
> [...]
>