From: Markus Elfring <Markus.Elfring@web.de>
To: John Madieu <john.madieu.xa@bp.renesas.com>,
linux-renesas-soc@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Rob Herring <robh@kernel.org>
Cc: John Madieu <john.madieu@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Biju Das <biju.das.jz@bp.renesas.com>,
Lukasz Luba <lukasz.luba@arm.com>,
Magnus Damm <magnus.damm@gmail.com>,
Stephen Boyd <sboyd@kernel.org>, Zhang Rui <rui.zhang@intel.com>
Subject: Re: [PATCH v4 3/5] thermal: renesas: rzg3e: Add thermal driver for the Renesas RZ/G3E SoC
Date: Sat, 29 Mar 2025 14:01:49 +0100 [thread overview]
Message-ID: <207f5f63-39b2-4801-ab98-8fd8cb7c1302@web.de> (raw)
In-Reply-To: <20250317143442.100590-4-john.madieu.xa@bp.renesas.com>
…
> +++ b/drivers/thermal/renesas/rzg3e_thermal.c
> @@ -0,0 +1,445 @@
…
> +static irqreturn_t rzg3e_thermal_adc_irq(int irq, void *dev_id)
> +{
…
> + int new_temp = temp_val * MILLIDEGREE_PER_DEGREE;
> +
> + scoped_guard(spinlock_irqsave, &priv->reg_lock) {
> + priv->cached_temp = new_temp;
> + }
> +
> + complete(&priv->conv_complete);
…
Are curly brackets really relevant for such a “scoped guard”?
https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.14#n197
Regards,
Markus
next prev parent reply other threads:[~2025-03-29 13:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 14:34 [PATCH v4 0/5] thermal: renesas: Add support fot RZ/G3E John Madieu
2025-03-17 14:34 ` [PATCH v4 1/5] soc: renesas: rz-sysc: add syscon/regmap support John Madieu
2025-03-17 14:34 ` [PATCH v4 2/5] dt-bindings: thermal: r9a09g047-tsu: Document the TSU unit John Madieu
2025-03-18 8:17 ` Krzysztof Kozlowski
2025-03-17 14:34 ` [PATCH v4 3/5] thermal: renesas: rzg3e: Add thermal driver for the Renesas RZ/G3E SoC John Madieu
2025-03-29 13:01 ` Markus Elfring [this message]
2025-03-29 13:04 ` John Madieu
2025-03-17 14:34 ` [PATCH v4 4/5] arm64: dts: renesas: r9a09g047: Add TSU node John Madieu
2025-03-17 14:34 ` [PATCH v4 5/5] arm64: defconfig: Enable the Renesas RZ/G3E thermal driver John Madieu
2025-03-18 8:17 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=207f5f63-39b2-4801-ab98-8fd8cb7c1302@web.de \
--to=markus.elfring@web.de \
--cc=biju.das.jz@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=john.madieu.xa@bp.renesas.com \
--cc=john.madieu@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=magnus.damm@gmail.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox