From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Laurent Pinchart Subject: Re: [PATCH v2 1/5] dt-bindings: adv748x: make data-lanes property mandatory for CSI-2 endpoints Date: Fri, 05 Oct 2018 00:42:17 +0300 Message-ID: <2082037.FqgpqPMGh4@avalon> In-Reply-To: <20181004204138.2784-2-niklas.soderlund@ragnatech.se> References: <20181004204138.2784-1-niklas.soderlund@ragnatech.se> <20181004204138.2784-2-niklas.soderlund@ragnatech.se> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" To: Niklas =?ISO-8859-1?Q?S=F6derlund?= Cc: Kieran Bingham , Jacopo Mondi , linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Niklas =?ISO-8859-1?Q?S=F6derlund?= , Rob Herring , devicetree@vger.kernel.org List-ID: Hi Niklas, Thank you for the patch. On Thursday, 4 October 2018 23:41:34 EEST Niklas S=F6derlund wrote: > From: Niklas S=F6derlund >=20 > The CSI-2 transmitters can use a different number of lanes to transmit > data. Make the data-lanes mandatory for the endpoints describe the s/describe/that describe/ ? > transmitters as no good default can be set to fallback on. >=20 > Signed-off-by: Niklas S=F6derlund > --- > Documentation/devicetree/bindings/media/i2c/adv748x.txt | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/media/i2c/adv748x.txt > b/Documentation/devicetree/bindings/media/i2c/adv748x.txt index > 5dddc95f9cc46084..f9dac01ab795fc28 100644 > --- a/Documentation/devicetree/bindings/media/i2c/adv748x.txt > +++ b/Documentation/devicetree/bindings/media/i2c/adv748x.txt > @@ -50,6 +50,9 @@ are numbered as follows. >=20 > The digital output port nodes must contain at least one endpoint. >=20 > +The endpoints described in TXA and TXB ports must if present contain > +the data-lanes property as described in video-interfaces.txt. > + Would it make sense to merge those two paragraphs, as they refer to the sam= e=20 endpoint ? "The digital output port nodes, when present, shall contain at least one=20 endpoint. Each of those endpoints shall contain the data-lanes property as= =20 described in video-interfaces.txt." (DT bindings normally use "shall" instead of "must", but that hasn't really= =20 been enforced.) If you want to keep the paragraphs separate, I would recommend using "digit= al=20 output ports" instead of "TXA and TXB" in the second paragraph for consiste= ncy=20 (or the other way around). I'm fine with any of the above option, so please pick your favourite, and a= dd Reviewed-by: Laurent Pinchart > Ports are optional if they are not connected to anything at the hardware > level. >=20 > Example: =2D-=20 Regards, Laurent Pinchart