From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: forbidden405@outlook.com,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: David Yang <mmyangfl@gmail.com>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/8] ARM: dts: hisilicon: add missing compatibles to CRG node
Date: Thu, 22 Feb 2024 19:08:31 +0100 [thread overview]
Message-ID: <2085057c-0000-4e0d-a633-c84e939313d6@linaro.org> (raw)
In-Reply-To: <20240222-clk-mv200-v3-2-f30795b50318@outlook.com>
On 21/02/2024 17:41, Yang Xiwen via B4 Relay wrote:
> From: Yang Xiwen <forbidden405@outlook.com>
>
> Add "syscon" and "simple-mfd" compatibles to CRG node due to recent
> binding changes.
Why? You claimed you added them in the bindings because DTS has them. In
DTS you claim reason is: binding has them.
That's confusing.
>
> Signed-off-by: Yang Xiwen <forbidden405@outlook.com>
> ---
> arch/arm/boot/dts/hisilicon/hi3519.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/hisilicon/hi3519.dtsi b/arch/arm/boot/dts/hisilicon/hi3519.dtsi
> index a42b71cdc5d7..da46e01b8fdc 100644
> --- a/arch/arm/boot/dts/hisilicon/hi3519.dtsi
> +++ b/arch/arm/boot/dts/hisilicon/hi3519.dtsi
> @@ -35,7 +35,7 @@ clk_3m: clk_3m {
> };
>
> crg: clock-reset-controller@12010000 {
> - compatible = "hisilicon,hi3519-crg";
> + compatible = "hisilicon,hi3519-crg", "syscon", "simple-mfd";
Why? This does not make much sense. No children here, no usage as syscon.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-02-22 18:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 16:41 [PATCH v3 0/8] clk: hisilicon: add support for Hi3798MV200 Yang Xiwen via B4 Relay
2024-02-21 16:41 ` [PATCH v3 1/8] dt-bindings: clock: convert hisi-crg.txt to YAML Yang Xiwen via B4 Relay
2024-02-22 18:06 ` Krzysztof Kozlowski
2024-02-22 18:08 ` Yang Xiwen
2024-02-21 16:41 ` [PATCH v3 2/8] ARM: dts: hisilicon: add missing compatibles to CRG node Yang Xiwen via B4 Relay
2024-02-22 18:08 ` Krzysztof Kozlowski [this message]
2024-02-22 18:13 ` Yang Xiwen
2024-02-22 18:18 ` Krzysztof Kozlowski
2024-02-22 18:24 ` Yang Xiwen
2024-02-21 16:41 ` [PATCH v3 3/8] dt-bindings: clock: histb-clock: split into two header files Yang Xiwen via B4 Relay
2024-02-22 18:11 ` Krzysztof Kozlowski
2024-02-22 18:15 ` Yang Xiwen
2024-02-22 18:19 ` Krzysztof Kozlowski
2024-02-22 18:19 ` Krzysztof Kozlowski
2024-02-21 16:41 ` [PATCH v3 4/8] arm64: dts: hisilicon: fix include path Yang Xiwen via B4 Relay
2024-02-21 16:41 ` [PATCH v3 5/8] clk: hisilicon: fix include path for crg-hi3798cv200 Yang Xiwen via B4 Relay
2024-02-21 16:41 ` [PATCH v3 6/8] dt-bindings: clock: hisilicon,clock-reset-controller: add Hi3798MV200 SoC Yang Xiwen via B4 Relay
2024-02-21 16:41 ` [PATCH v3 7/8] dt-bindings: clock: hisilicon: add clock definitions for Hi3798MV200 Yang Xiwen via B4 Relay
2024-02-22 18:10 ` Krzysztof Kozlowski
2024-02-21 16:41 ` [PATCH v3 8/8] clk: hisilicon: add CRG driver for Hi3798MV200 SoC Yang Xiwen via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2085057c-0000-4e0d-a633-c84e939313d6@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=forbidden405@outlook.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmyangfl@gmail.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).