From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH v2 2/2] dt-bindings: rockchip-thermal: fix the misleading description Date: Tue, 11 Oct 2016 09:01:44 +0200 Message-ID: <2090010.rzXtZk2lxz@phil> References: <1476151655-18415-1-git-send-email-shawn.lin@rock-chips.com> <1476151655-18415-2-git-send-email-shawn.lin@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1476151655-18415-2-git-send-email-shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Shawn Lin Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Eduardo Valentin , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring , Zhang Rui , Caesar Wang List-Id: devicetree@vger.kernel.org Am Dienstag, 11. Oktober 2016, 10:07:35 CEST schrieb Shawn Lin: > "rockchip,hw-tshut-temp", "rockchip,hw-tshut-mode" and > "rockchip,hw-tshut-polarity" are not a required properties > actually as the code could also work by loading the default > settings there. So it is apprently misleading, although we > prefer to get these from DT. And it seems we miss the 'rockchip,grf' > here which should also be an optional property. > > Signed-off-by: Shawn Lin Reviewed-by: Heiko Stuebner