* [PATCH v5 0/3] hwrng: add hwrng support for Rockchip RK3568
@ 2024-06-26 1:36 Daniel Golle
2024-06-26 1:36 ` [PATCH v5 1/3] dt-bindings: rng: Add Rockchip RK3568 TRNG Daniel Golle
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Daniel Golle @ 2024-06-26 1:36 UTC (permalink / raw)
To: Daniel Golle, Aurelien Jarno, Olivia Mackall, Herbert Xu,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Philipp Zabel, Uwe Kleine-König, Dragan Simic, Sascha Hauer,
Martin Kaiser, Tony Luck, Ard Biesheuvel, linux-crypto,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
Rockchip SoCs used to have a random number generator as part of their
crypto device, and support for it has to be added to the corresponding
driver.
However newer Rockchip SoCs like the RK3568 have an independent True
Random Number Generator device. This patchset adds a driver for it and
enable it in the device tree.
v4 -> v5:
* Patch 1: always use RK3568 name
- use full RK3568 name in patch description
- add RK3568 to title in binding
* Patch 2: full name and cosmetics
- also always mention RK3568 as there may be other RNG in other
(future) Rockchip SoCs
- remove debug output on successful probe
- use MODULE_AUTHOR several times instead of single comma-separated
* Patch 3: unchanged
v3 -> v4:
* Patch 1: minor corrections
- fix Rokchip -> Rockchip typo
- change commit title as requested
* Patch 2: improved error handling and resource management
- Always use writel() instead of writel_relaxed()
- Use pm_runtime_resume_and_get
- Correctly return error code in rk_rng_read()
- Make use of devm_reset_control_array_get_exclusive
- Use devm_pm_runtime_enable and there by get rid of rk_rng_remove()
* Patch 3:
- Move node to conform with ordering by address
v2 -> v3: patch adopted by Daniel Golle
* Patch 1: address comments of Krzysztof Kozlowski, add MAINTAINERS
- improved description
- meaningful clock-names
- add entry in MAINTAINERS files
* Patch 2: numerous code-style improvements
- drop misleading rk_rng_write_ctl(), simplify I/O writes
- drop unused TRNG_RNG_DOUT_[1-7] macros
- handle error handling for pm_runtime_get_sync()
- use memcpy_fromio() instead of open coding for-loop
- some minor white-spaces fixes
* Patch 3:
- use clock-names as defined in dt-bindings
v1 -> v2:
* Patch 1: fix issues reported by Rob Herring and Krzysztof Kozlowski:
- Rename rockchip-rng.yaml into rockchip,rk3568-rng.yaml
- Fix binding title and description
- Fix compatible property
- Rename clocks and add the corresponding descriptions
- Drop reset-names
- Add a bus definition with #address-cells and #size-cells to the
example.
* Patch 2: fix issue reported by kernel test robot <lkp@intel.com>
- Do not read the random registers as big endian, looking at the
RK3568 TRM this is actually not needed. This fixes a sparse
warning.
* Patch 3: unchanged
Aurelien Jarno (3):
dt-bindings: rng: Add Rockchip RK3568 TRNG
hwrng: add hwrng driver for Rockchip RK3568 SoC
arm64: dts: rockchip: add DT entry for RNG to RK356x
.../bindings/rng/rockchip,rk3568-rng.yaml | 61 +++++
MAINTAINERS | 7 +
arch/arm64/boot/dts/rockchip/rk356x.dtsi | 9 +
drivers/char/hw_random/Kconfig | 14 ++
drivers/char/hw_random/Makefile | 1 +
drivers/char/hw_random/rockchip-rng.c | 222 ++++++++++++++++++
6 files changed, 314 insertions(+)
create mode 100644 Documentation/devicetree/bindings/rng/rockchip,rk3568-rng.yaml
create mode 100644 drivers/char/hw_random/rockchip-rng.c
--
2.45.2
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH v5 1/3] dt-bindings: rng: Add Rockchip RK3568 TRNG 2024-06-26 1:36 [PATCH v5 0/3] hwrng: add hwrng support for Rockchip RK3568 Daniel Golle @ 2024-06-26 1:36 ` Daniel Golle 2024-06-26 7:31 ` Krzysztof Kozlowski 2024-06-26 1:37 ` [PATCH v5 2/3] hwrng: add hwrng driver for Rockchip RK3568 SoC Daniel Golle 2024-06-26 1:37 ` [PATCH v5 3/3] arm64: dts: rockchip: add DT entry for RNG to RK356x Daniel Golle 2 siblings, 1 reply; 8+ messages in thread From: Daniel Golle @ 2024-06-26 1:36 UTC (permalink / raw) To: Daniel Golle, Aurelien Jarno, Olivia Mackall, Herbert Xu, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner, Philipp Zabel, Uwe Kleine-König, Dragan Simic, Sascha Hauer, Martin Kaiser, Tony Luck, Ard Biesheuvel, linux-crypto, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel From: Aurelien Jarno <aurelien@aurel32.net> Add the True Random Number Generator on the Rockchip RK3568 SoC. Signed-off-by: Aurelien Jarno <aurelien@aurel32.net> Signed-off-by: Daniel Golle <daniel@makrotopia.org> --- .../bindings/rng/rockchip,rk3568-rng.yaml | 61 +++++++++++++++++++ MAINTAINERS | 6 ++ 2 files changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/rng/rockchip,rk3568-rng.yaml diff --git a/Documentation/devicetree/bindings/rng/rockchip,rk3568-rng.yaml b/Documentation/devicetree/bindings/rng/rockchip,rk3568-rng.yaml new file mode 100644 index 000000000000..ad3648b96f82 --- /dev/null +++ b/Documentation/devicetree/bindings/rng/rockchip,rk3568-rng.yaml @@ -0,0 +1,61 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Rockchip RK3568 TRNG + +description: True Random Number Generator on Rockchip RK3568 SoC + +maintainers: + - Aurelien Jarno <aurelien@aurel32.net> + - Daniel Golle <daniel@makrotopia.org> + +properties: + compatible: + enum: + - rockchip,rk3568-rng + + reg: + maxItems: 1 + + clocks: + items: + - description: TRNG clock + - description: TRNG AHB clock + + clock-names: + items: + - const: core + - const: ahb + + resets: + maxItems: 1 + +required: + - compatible + - reg + - clocks + - clock-names + - resets + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/rk3568-cru.h> + bus { + #address-cells = <2>; + #size-cells = <2>; + + rng@fe388000 { + compatible = "rockchip,rk3568-rng"; + reg = <0x0 0xfe388000 0x0 0x4000>; + clocks = <&cru CLK_TRNG_NS>, <&cru HCLK_TRNG_NS>; + clock-names = "core", "ahb"; + resets = <&cru SRST_TRNG_NS>; + }; + }; + +... diff --git a/MAINTAINERS b/MAINTAINERS index 807feae089c4..aef74047de1b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -19498,6 +19498,12 @@ F: Documentation/userspace-api/media/v4l/metafmt-rkisp1.rst F: drivers/media/platform/rockchip/rkisp1 F: include/uapi/linux/rkisp1-config.h +ROCKCHIP RK3568 RANDOM NUMBER GENERATOR SUPPORT +M: Daniel Golle <daniel@makrotopia.org> +M: Aurelien Jarno <aurelien@aurel32.net> +S: Maintained +F: Documentation/devicetree/bindings/rng/rockchip,rk3568-rng.yaml + ROCKCHIP RASTER 2D GRAPHIC ACCELERATION UNIT DRIVER M: Jacob Chen <jacob-chen@iotwrt.com> M: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> -- 2.45.2 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v5 1/3] dt-bindings: rng: Add Rockchip RK3568 TRNG 2024-06-26 1:36 ` [PATCH v5 1/3] dt-bindings: rng: Add Rockchip RK3568 TRNG Daniel Golle @ 2024-06-26 7:31 ` Krzysztof Kozlowski 0 siblings, 0 replies; 8+ messages in thread From: Krzysztof Kozlowski @ 2024-06-26 7:31 UTC (permalink / raw) To: Daniel Golle, Aurelien Jarno, Olivia Mackall, Herbert Xu, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner, Philipp Zabel, Uwe Kleine-König, Dragan Simic, Sascha Hauer, Martin Kaiser, Tony Luck, Ard Biesheuvel, linux-crypto, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel On 26/06/2024 03:36, Daniel Golle wrote: > From: Aurelien Jarno <aurelien@aurel32.net> > > Add the True Random Number Generator on the Rockchip RK3568 SoC. > > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net> > Signed-off-by: Daniel Golle <daniel@makrotopia.org> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v5 2/3] hwrng: add hwrng driver for Rockchip RK3568 SoC 2024-06-26 1:36 [PATCH v5 0/3] hwrng: add hwrng support for Rockchip RK3568 Daniel Golle 2024-06-26 1:36 ` [PATCH v5 1/3] dt-bindings: rng: Add Rockchip RK3568 TRNG Daniel Golle @ 2024-06-26 1:37 ` Daniel Golle 2024-06-26 7:31 ` Krzysztof Kozlowski 2024-07-06 0:15 ` Herbert Xu 2024-06-26 1:37 ` [PATCH v5 3/3] arm64: dts: rockchip: add DT entry for RNG to RK356x Daniel Golle 2 siblings, 2 replies; 8+ messages in thread From: Daniel Golle @ 2024-06-26 1:37 UTC (permalink / raw) To: Daniel Golle, Aurelien Jarno, Olivia Mackall, Herbert Xu, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner, Philipp Zabel, Uwe Kleine-König, Dragan Simic, Sascha Hauer, Martin Kaiser, Tony Luck, Ard Biesheuvel, linux-crypto, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel From: Aurelien Jarno <aurelien@aurel32.net> Rockchip SoCs used to have a random number generator as part of their crypto device, and support for it has to be added to the corresponding driver. However newer Rockchip SoCs like the RK3568 have an independent True Random Number Generator device. This patch adds a driver for it, greatly inspired from the downstream driver. The TRNG device does not seem to have a signal conditionner and the FIPS 140-2 test returns a lot of failures. They can be reduced by increasing RK_RNG_SAMPLE_CNT, in a tradeoff between quality and speed. This value has been adjusted to get ~90% of successes and the quality value has been set accordingly. Signed-off-by: Aurelien Jarno <aurelien@aurel32.net> [daniel@makrotpia.org: code style fixes] Signed-off-by: Daniel Golle <daniel@makrotopia.org> --- MAINTAINERS | 1 + drivers/char/hw_random/Kconfig | 14 ++ drivers/char/hw_random/Makefile | 1 + drivers/char/hw_random/rockchip-rng.c | 222 ++++++++++++++++++++++++++ 4 files changed, 238 insertions(+) create mode 100644 drivers/char/hw_random/rockchip-rng.c diff --git a/MAINTAINERS b/MAINTAINERS index aef74047de1b..9437ab8c9446 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -19503,6 +19503,7 @@ M: Daniel Golle <daniel@makrotopia.org> M: Aurelien Jarno <aurelien@aurel32.net> S: Maintained F: Documentation/devicetree/bindings/rng/rockchip,rk3568-rng.yaml +F: drivers/char/hw_random/rockchip-rng.c ROCKCHIP RASTER 2D GRAPHIC ACCELERATION UNIT DRIVER M: Jacob Chen <jacob-chen@iotwrt.com> diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig index 442c40efb200..2b62cd08f91a 100644 --- a/drivers/char/hw_random/Kconfig +++ b/drivers/char/hw_random/Kconfig @@ -573,6 +573,20 @@ config HW_RANDOM_JH7110 To compile this driver as a module, choose M here. The module will be called jh7110-trng. +config HW_RANDOM_ROCKCHIP + tristate "Rockchip True Random Number Generator" + depends on HW_RANDOM && (ARCH_ROCKCHIP || COMPILE_TEST) + depends on HAS_IOMEM + default HW_RANDOM + help + This driver provides kernel-side support for the True Random Number + Generator hardware found on some Rockchip SoC like RK3566 or RK3568. + + To compile this driver as a module, choose M here: the + module will be called rockchip-rng. + + If unsure, say Y. + endif # HW_RANDOM config UML_RANDOM diff --git a/drivers/char/hw_random/Makefile b/drivers/char/hw_random/Makefile index 32549a1186dc..01f012eab440 100644 --- a/drivers/char/hw_random/Makefile +++ b/drivers/char/hw_random/Makefile @@ -48,4 +48,5 @@ obj-$(CONFIG_HW_RANDOM_XIPHERA) += xiphera-trng.o obj-$(CONFIG_HW_RANDOM_ARM_SMCCC_TRNG) += arm_smccc_trng.o obj-$(CONFIG_HW_RANDOM_CN10K) += cn10k-rng.o obj-$(CONFIG_HW_RANDOM_POLARFIRE_SOC) += mpfs-rng.o +obj-$(CONFIG_HW_RANDOM_ROCKCHIP) += rockchip-rng.o obj-$(CONFIG_HW_RANDOM_JH7110) += jh7110-trng.o diff --git a/drivers/char/hw_random/rockchip-rng.c b/drivers/char/hw_random/rockchip-rng.c new file mode 100644 index 000000000000..fd8fa5d7e028 --- /dev/null +++ b/drivers/char/hw_random/rockchip-rng.c @@ -0,0 +1,222 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * rockchip-rng.c True Random Number Generator driver for Rockchip RK3568 SoC + * + * Copyright (c) 2018, Fuzhou Rockchip Electronics Co., Ltd. + * Copyright (c) 2022, Aurelien Jarno + * Authors: + * Lin Jinhan <troy.lin@rock-chips.com> + * Aurelien Jarno <aurelien@aurel32.net> + */ +#include <linux/clk.h> +#include <linux/hw_random.h> +#include <linux/io.h> +#include <linux/iopoll.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/platform_device.h> +#include <linux/pm_runtime.h> +#include <linux/reset.h> +#include <linux/slab.h> + +#define RK_RNG_AUTOSUSPEND_DELAY 100 +#define RK_RNG_MAX_BYTE 32 +#define RK_RNG_POLL_PERIOD_US 100 +#define RK_RNG_POLL_TIMEOUT_US 10000 + +/* + * TRNG collects osc ring output bit every RK_RNG_SAMPLE_CNT time. The value is + * a tradeoff between speed and quality and has been adjusted to get a quality + * of ~900 (~90% of FIPS 140-2 successes). + */ +#define RK_RNG_SAMPLE_CNT 1000 + +/* TRNG registers from RK3568 TRM-Part2, section 5.4.1 */ +#define TRNG_RST_CTL 0x0004 +#define TRNG_RNG_CTL 0x0400 +#define TRNG_RNG_CTL_LEN_64_BIT (0x00 << 4) +#define TRNG_RNG_CTL_LEN_128_BIT (0x01 << 4) +#define TRNG_RNG_CTL_LEN_192_BIT (0x02 << 4) +#define TRNG_RNG_CTL_LEN_256_BIT (0x03 << 4) +#define TRNG_RNG_CTL_OSC_RING_SPEED_0 (0x00 << 2) +#define TRNG_RNG_CTL_OSC_RING_SPEED_1 (0x01 << 2) +#define TRNG_RNG_CTL_OSC_RING_SPEED_2 (0x02 << 2) +#define TRNG_RNG_CTL_OSC_RING_SPEED_3 (0x03 << 2) +#define TRNG_RNG_CTL_ENABLE BIT(1) +#define TRNG_RNG_CTL_START BIT(0) +#define TRNG_RNG_SAMPLE_CNT 0x0404 +#define TRNG_RNG_DOUT 0x0410 + +struct rk_rng { + struct hwrng rng; + void __iomem *base; + struct reset_control *rst; + int clk_num; + struct clk_bulk_data *clk_bulks; +}; + +static int rk_rng_init(struct hwrng *rng) +{ + struct rk_rng *rk_rng = container_of(rng, struct rk_rng, rng); + int ret; + + /* start clocks */ + ret = clk_bulk_prepare_enable(rk_rng->clk_num, rk_rng->clk_bulks); + if (ret < 0) { + dev_err((struct device *) rk_rng->rng.priv, + "Failed to enable clks %d\n", ret); + return ret; + } + + /* set the sample period */ + writel(RK_RNG_SAMPLE_CNT, rk_rng->base + TRNG_RNG_SAMPLE_CNT); + + /* set osc ring speed and enable it */ + writel(TRNG_RNG_CTL_LEN_256_BIT | + TRNG_RNG_CTL_OSC_RING_SPEED_0 | + TRNG_RNG_CTL_ENABLE, + rk_rng->base + TRNG_RNG_CTL); + + return 0; +} + +static void rk_rng_cleanup(struct hwrng *rng) +{ + struct rk_rng *rk_rng = container_of(rng, struct rk_rng, rng); + + /* stop TRNG */ + writel(0, rk_rng->base + TRNG_RNG_CTL); + + /* stop clocks */ + clk_bulk_disable_unprepare(rk_rng->clk_num, rk_rng->clk_bulks); +} + +static int rk_rng_read(struct hwrng *rng, void *buf, size_t max, bool wait) +{ + struct rk_rng *rk_rng = container_of(rng, struct rk_rng, rng); + size_t to_read = min_t(size_t, max, RK_RNG_MAX_BYTE); + u32 reg; + int ret = 0; + + ret = pm_runtime_resume_and_get((struct device *) rk_rng->rng.priv); + if (ret < 0) + return ret; + + /* Start collecting random data */ + writel(TRNG_RNG_CTL_START, rk_rng->base + TRNG_RNG_CTL); + + ret = readl_poll_timeout(rk_rng->base + TRNG_RNG_CTL, reg, + !(reg & TRNG_RNG_CTL_START), + RK_RNG_POLL_PERIOD_US, + RK_RNG_POLL_TIMEOUT_US); + if (ret < 0) + goto out; + + /* Read random data stored in the registers */ + memcpy_fromio(buf, rk_rng->base + TRNG_RNG_DOUT, to_read); +out: + pm_runtime_mark_last_busy((struct device *) rk_rng->rng.priv); + pm_runtime_put_sync_autosuspend((struct device *) rk_rng->rng.priv); + + return (ret < 0) ? ret : to_read; +} + +static int rk_rng_probe(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + struct rk_rng *rk_rng; + int ret; + + rk_rng = devm_kzalloc(dev, sizeof(*rk_rng), GFP_KERNEL); + if (!rk_rng) + return -ENOMEM; + + rk_rng->base = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(rk_rng->base)) + return PTR_ERR(rk_rng->base); + + rk_rng->clk_num = devm_clk_bulk_get_all(dev, &rk_rng->clk_bulks); + if (rk_rng->clk_num < 0) + return dev_err_probe(dev, rk_rng->clk_num, + "Failed to get clks property\n"); + + rk_rng->rst = devm_reset_control_array_get_exclusive(&pdev->dev); + if (IS_ERR(rk_rng->rst)) + return dev_err_probe(dev, PTR_ERR(rk_rng->rst), + "Failed to get reset property\n"); + + reset_control_assert(rk_rng->rst); + udelay(2); + reset_control_deassert(rk_rng->rst); + + platform_set_drvdata(pdev, rk_rng); + + rk_rng->rng.name = dev_driver_string(dev); +#ifndef CONFIG_PM + rk_rng->rng.init = rk_rng_init; + rk_rng->rng.cleanup = rk_rng_cleanup; +#endif + rk_rng->rng.read = rk_rng_read; + rk_rng->rng.priv = (unsigned long) dev; + rk_rng->rng.quality = 900; + + pm_runtime_set_autosuspend_delay(dev, RK_RNG_AUTOSUSPEND_DELAY); + pm_runtime_use_autosuspend(dev); + devm_pm_runtime_enable(dev); + + ret = devm_hwrng_register(dev, &rk_rng->rng); + if (ret) + return dev_err_probe(&pdev->dev, ret, "Failed to register Rockchip hwrng\n"); + + return 0; +} + +#ifdef CONFIG_PM +static int rk_rng_runtime_suspend(struct device *dev) +{ + struct rk_rng *rk_rng = dev_get_drvdata(dev); + + rk_rng_cleanup(&rk_rng->rng); + + return 0; +} + +static int rk_rng_runtime_resume(struct device *dev) +{ + struct rk_rng *rk_rng = dev_get_drvdata(dev); + + return rk_rng_init(&rk_rng->rng); +} +#endif + +static const struct dev_pm_ops rk_rng_pm_ops = { + SET_RUNTIME_PM_OPS(rk_rng_runtime_suspend, + rk_rng_runtime_resume, NULL) + SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, + pm_runtime_force_resume) +}; + +static const struct of_device_id rk_rng_dt_match[] = { + { .compatible = "rockchip,rk3568-rng", }, + { /* sentinel */ }, +}; + +MODULE_DEVICE_TABLE(of, rk_rng_dt_match); + +static struct platform_driver rk_rng_driver = { + .driver = { + .name = "rockchip-rng", + .pm = &rk_rng_pm_ops, + .of_match_table = rk_rng_dt_match, + }, + .probe = rk_rng_probe, +}; + +module_platform_driver(rk_rng_driver); + +MODULE_DESCRIPTION("Rockchip RK3568 True Random Number Generator driver"); +MODULE_AUTHOR("Lin Jinhan <troy.lin@rock-chips.com>"); +MODULE_AUTHOR("Aurelien Jarno <aurelien@aurel32.net>"); +MODULE_AUTHOR("Daniel Golle <daniel@makrotopia.org>"); +MODULE_LICENSE("GPL"); -- 2.45.2 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v5 2/3] hwrng: add hwrng driver for Rockchip RK3568 SoC 2024-06-26 1:37 ` [PATCH v5 2/3] hwrng: add hwrng driver for Rockchip RK3568 SoC Daniel Golle @ 2024-06-26 7:31 ` Krzysztof Kozlowski 2024-07-06 0:15 ` Herbert Xu 1 sibling, 0 replies; 8+ messages in thread From: Krzysztof Kozlowski @ 2024-06-26 7:31 UTC (permalink / raw) To: Daniel Golle, Aurelien Jarno, Olivia Mackall, Herbert Xu, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner, Philipp Zabel, Uwe Kleine-König, Dragan Simic, Sascha Hauer, Martin Kaiser, Tony Luck, Ard Biesheuvel, linux-crypto, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel On 26/06/2024 03:37, Daniel Golle wrote: > From: Aurelien Jarno <aurelien@aurel32.net> > > Rockchip SoCs used to have a random number generator as part of their > crypto device, and support for it has to be added to the corresponding > driver. However newer Rockchip SoCs like the RK3568 have an independent > True Random Number Generator device. This patch adds a driver for it, > greatly inspired from the downstream driver. > > The TRNG device does not seem to have a signal conditionner and the FIPS > 140-2 test returns a lot of failures. They can be reduced by increasing > RK_RNG_SAMPLE_CNT, in a tradeoff between quality and speed. This value > has been adjusted to get ~90% of successes and the quality value has > been set accordingly. > > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net> > [daniel@makrotpia.org: code style fixes] > Signed-off-by: Daniel Golle <daniel@makrotopia.org> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v5 2/3] hwrng: add hwrng driver for Rockchip RK3568 SoC 2024-06-26 1:37 ` [PATCH v5 2/3] hwrng: add hwrng driver for Rockchip RK3568 SoC Daniel Golle 2024-06-26 7:31 ` Krzysztof Kozlowski @ 2024-07-06 0:15 ` Herbert Xu 1 sibling, 0 replies; 8+ messages in thread From: Herbert Xu @ 2024-07-06 0:15 UTC (permalink / raw) To: Daniel Golle Cc: Aurelien Jarno, Olivia Mackall, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner, Philipp Zabel, Uwe Kleine-König, Dragan Simic, Sascha Hauer, Martin Kaiser, Tony Luck, Ard Biesheuvel, linux-crypto, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel On Wed, Jun 26, 2024 at 02:37:10AM +0100, Daniel Golle wrote: > > +#ifndef CONFIG_PM > + rk_rng->rng.init = rk_rng_init; > + rk_rng->rng.cleanup = rk_rng_cleanup; > +#endif Please rewrite this as if (!IS_ENABLED(CONFIG_PM)) { ... } > +#ifdef CONFIG_PM > +static int rk_rng_runtime_suspend(struct device *dev) > +{ > + struct rk_rng *rk_rng = dev_get_drvdata(dev); > + > + rk_rng_cleanup(&rk_rng->rng); > + > + return 0; > +} > + > +static int rk_rng_runtime_resume(struct device *dev) > +{ > + struct rk_rng *rk_rng = dev_get_drvdata(dev); > + > + return rk_rng_init(&rk_rng->rng); > +} > +#endif These ifdefs should just disappear, with __maybe_unused added instead. Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v5 3/3] arm64: dts: rockchip: add DT entry for RNG to RK356x 2024-06-26 1:36 [PATCH v5 0/3] hwrng: add hwrng support for Rockchip RK3568 Daniel Golle 2024-06-26 1:36 ` [PATCH v5 1/3] dt-bindings: rng: Add Rockchip RK3568 TRNG Daniel Golle 2024-06-26 1:37 ` [PATCH v5 2/3] hwrng: add hwrng driver for Rockchip RK3568 SoC Daniel Golle @ 2024-06-26 1:37 ` Daniel Golle 2024-06-28 20:06 ` kernel test robot 2 siblings, 1 reply; 8+ messages in thread From: Daniel Golle @ 2024-06-26 1:37 UTC (permalink / raw) To: Daniel Golle, Aurelien Jarno, Olivia Mackall, Herbert Xu, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner, Philipp Zabel, Uwe Kleine-König, Dragan Simic, Sascha Hauer, Martin Kaiser, Tony Luck, Ard Biesheuvel, linux-crypto, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel From: Aurelien Jarno <aurelien@aurel32.net> Enable the just added Rockchip RNG driver for RK356x SoCs. Signed-off-by: Aurelien Jarno <aurelien@aurel32.net> Signed-off-by: Daniel Golle <daniel@makrotopia.org> --- arch/arm64/boot/dts/rockchip/rk356x.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi index d8543b5557ee..d43d59b44ea5 100644 --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi @@ -1112,6 +1112,15 @@ sdhci: mmc@fe310000 { status = "disabled"; }; + rng: rng@fe388000 { + compatible = "rockchip,rk3568-rng"; + reg = <0x0 0xfe388000 0x0 0x4000>; + clocks = <&cru CLK_TRNG_NS>, <&cru HCLK_TRNG_NS>; + clock-names = "core", "ahb"; + resets = <&cru SRST_TRNG_NS>; + reset-names = "reset"; + }; + i2s0_8ch: i2s@fe400000 { compatible = "rockchip,rk3568-i2s-tdm"; reg = <0x0 0xfe400000 0x0 0x1000>; -- 2.45.2 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v5 3/3] arm64: dts: rockchip: add DT entry for RNG to RK356x 2024-06-26 1:37 ` [PATCH v5 3/3] arm64: dts: rockchip: add DT entry for RNG to RK356x Daniel Golle @ 2024-06-28 20:06 ` kernel test robot 0 siblings, 0 replies; 8+ messages in thread From: kernel test robot @ 2024-06-28 20:06 UTC (permalink / raw) To: Daniel Golle, Aurelien Jarno, Olivia Mackall, Herbert Xu, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner, Philipp Zabel, Uwe Kleine-König, Dragan Simic, Sascha Hauer, Martin Kaiser, Tony Luck, Ard Biesheuvel, linux-crypto, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel Cc: oe-kbuild-all Hi Daniel, kernel test robot noticed the following build warnings: [auto build test WARNING on char-misc/char-misc-testing] [also build test WARNING on char-misc/char-misc-next char-misc/char-misc-linus rockchip/for-next robh/for-next herbert-cryptodev-2.6/master linus/master v6.10-rc5 next-20240627] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Daniel-Golle/dt-bindings-rng-Add-Rockchip-RK3568-TRNG/20240626-114623 base: char-misc/char-misc-testing patch link: https://lore.kernel.org/r/2181f2207391fb8fb8ae2cfda07d38f65da05ed9.1719365406.git.daniel%40makrotopia.org patch subject: [PATCH v5 3/3] arm64: dts: rockchip: add DT entry for RNG to RK356x config: arm64-randconfig-051-20240628 (https://download.01.org/0day-ci/archive/20240629/202406290305.M3hDJkwM-lkp@intel.com/config) compiler: aarch64-linux-gcc (GCC) 13.2.0 dtschema version: 2024.6.dev3+g650bf2d reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240629/202406290305.M3hDJkwM-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202406290305.M3hDJkwM-lkp@intel.com/ dtcheck warnings: (new ones prefixed by >>) >> arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg-arc-d.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# -- >> arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg-arc-s.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# -- >> arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dtb: i2c@fe5b0000: Unevaluated properties are not allowed ('pintctrl-names' was unexpected) from schema $id: http://devicetree.org/schemas/i2c/i2c-rk3x.yaml# -- >> arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353ps.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# -- >> arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353v.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353v.dtb: i2c@fe5b0000: Unevaluated properties are not allowed ('pintctrl-names' was unexpected) from schema $id: http://devicetree.org/schemas/i2c/i2c-rk3x.yaml# -- >> arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353vs.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# -- >> arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg503.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# -- arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi:486.10-497.6: Warning (graph_child_address): /i2c@fe5c0000/tcpc@60/connector/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary >> arch/arm64/boot/dts/rockchip/rk3566-pinenote-v1.1.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# arch/arm64/boot/dts/rockchip/rk3566-pinenote-v1.1.dtb: bluetooth: reset-gpios: False schema does not allow [[34, 20, 1]] from schema $id: http://devicetree.org/schemas/net/broadcom-bluetooth.yaml# arch/arm64/boot/dts/rockchip/rk3566-pinenote-v1.1.dtb: bluetooth: 'device-wake-gpios', 'host-wake-gpios' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/net/broadcom-bluetooth.yaml# arch/arm64/boot/dts/rockchip/rk3566-pinenote-v1.1.dtb: usb2phy@fe8a0000: otg-port: 'port' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/phy/rockchip,inno-usb2phy.yaml# -- arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi:288.10-292.5: Warning (unit_address_vs_reg): /dsi@fe060000/panel@0/port@0: node has a unit name, but no reg or ranges property arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi:289.29-291.6: Warning (unit_address_vs_reg): /dsi@fe060000/panel@0/port@0/endpoint@0: node has a unit name, but no reg or ranges property arch/arm64/boot/dts/rockchip/rk3566-pinetab2-v0.1.dtb: panel@0: 'port@0', 'reset-gpios' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/display/panel/boe,th101mb31ig002-28a.yaml# >> arch/arm64/boot/dts/rockchip/rk3566-pinetab2-v0.1.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# arch/arm64/boot/dts/rockchip/rk3566-pinetab2-v0.1.dtb: phy@fe870000: 'power-domains' is a required property from schema $id: http://devicetree.org/schemas/phy/rockchip-inno-csi-dphy.yaml# -- arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi:288.10-292.5: Warning (unit_address_vs_reg): /dsi@fe060000/panel@0/port@0: node has a unit name, but no reg or ranges property arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi:289.29-291.6: Warning (unit_address_vs_reg): /dsi@fe060000/panel@0/port@0/endpoint@0: node has a unit name, but no reg or ranges property arch/arm64/boot/dts/rockchip/rk3566-pinetab2-v2.0.dtb: panel@0: 'port@0', 'reset-gpios' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/display/panel/boe,th101mb31ig002-28a.yaml# >> arch/arm64/boot/dts/rockchip/rk3566-pinetab2-v2.0.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# arch/arm64/boot/dts/rockchip/rk3566-pinetab2-v2.0.dtb: phy@fe870000: 'power-domains' is a required property from schema $id: http://devicetree.org/schemas/phy/rockchip-inno-csi-dphy.yaml# -- >> arch/arm64/boot/dts/rockchip/rk3566-powkiddy-rgb10max3.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# -- >> arch/arm64/boot/dts/rockchip/rk3566-powkiddy-rgb30.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# -- >> arch/arm64/boot/dts/rockchip/rk3566-powkiddy-rk2023.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# -- >> arch/arm64/boot/dts/rockchip/rk3566-powkiddy-x55.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# -- >> arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# -- arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dtb: pmic@20: '#sound-dai-cells', 'assigned-clock-parents', 'assigned-clocks', 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/mfd/rockchip,rk809.yaml# >> arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# -- arch/arm64/boot/dts/rockchip/rk3566-radxa-cm3-io.dtb: wifi@1: compatible: 'oneOf' conditional failed, one must be fixed: ['brcm,bcm43455-fmac'] is too short 'brcm,bcm43455-fmac' is not one of ['brcm,bcm4329-fmac', 'pci14e4,43dc', 'pci14e4,4464', 'pci14e4,4488', 'pci14e4,4425', 'pci14e4,4433'] from schema $id: http://devicetree.org/schemas/net/wireless/brcm,bcm4329-fmac.yaml# arch/arm64/boot/dts/rockchip/rk3566-radxa-cm3-io.dtb: wifi@1: Unevaluated properties are not allowed ('compatible' was unexpected) from schema $id: http://devicetree.org/schemas/net/wireless/brcm,bcm4329-fmac.yaml# >> arch/arm64/boot/dts/rockchip/rk3566-radxa-cm3-io.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# arch/arm64/boot/dts/rockchip/rk3566-radxa-cm3-io.dtb: bluetooth: reset-gpios: False schema does not allow [[103, 16, 1]] from schema $id: http://devicetree.org/schemas/net/broadcom-bluetooth.yaml# -- arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dtb: pmic@20: '#sound-dai-cells', 'assigned-clock-parents', 'assigned-clocks', 'clock-names', 'clocks', 'codec' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/mfd/rockchip,rk809.yaml# >> arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# -- >> arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# -- >> arch/arm64/boot/dts/rockchip/rk3566-soquartz-blade.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# arch/arm64/boot/dts/rockchip/rk3566-soquartz-blade.dtb: phy@fe840000: 'phy-supply' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/phy/phy-rockchip-naneng-combphy.yaml# -- >> arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dtb: phy@fe840000: 'phy-supply' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/phy/phy-rockchip-naneng-combphy.yaml# -- >> arch/arm64/boot/dts/rockchip/rk3566-soquartz-model-a.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# arch/arm64/boot/dts/rockchip/rk3566-soquartz-model-a.dtb: phy@fe840000: 'phy-supply' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/phy/phy-rockchip-naneng-combphy.yaml# -- >> arch/arm64/boot/dts/rockchip/rk3566-box-demo.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# arch/arm64/boot/dts/rockchip/rk3566-box-demo.dtb: bluetooth: clock-names: 'oneOf' conditional failed, one must be fixed: ['ext_clock'] is too short 'extclk' was expected 'txco' was expected 'lpo' was expected from schema $id: http://devicetree.org/schemas/net/broadcom-bluetooth.yaml# arch/arm64/boot/dts/rockchip/rk3566-box-demo.dtb: bluetooth: 'device-wake-gpios', 'host-wake-gpios' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/net/broadcom-bluetooth.yaml# -- arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dtb: mmc@fe2b0000: Unevaluated properties are not allowed ('supports-sd' was unexpected) from schema $id: http://devicetree.org/schemas/mmc/rockchip-dw-mshc.yaml# arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dtb: mmc@fe310000: Unevaluated properties are not allowed ('supports-emmc' was unexpected) from schema $id: http://devicetree.org/schemas/mmc/snps,dwcmshc-sdhci.yaml# >> arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# -- arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dtb: sata@fc800000: Unevaluated properties are not allowed ('power-domains' was unexpected) from schema $id: http://devicetree.org/schemas/ata/rockchip,dwc-ahci.yaml# >> arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dtb: phy@fe8c0000: 'phy-supply' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/phy/rockchip,pcie3-phy.yaml# -- arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dtb: pmic@20: '#sound-dai-cells', 'assigned-clock-parents', 'assigned-clocks', 'clock-names', 'clocks', 'codec' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/mfd/rockchip,rk809.yaml# >> arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# -- >> arch/arm64/boot/dts/rockchip/rk3568-fastrhino-r66s.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# -- >> arch/arm64/boot/dts/rockchip/rk3568-fastrhino-r68s.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# -- arch/arm64/boot/dts/rockchip/rk3568-lubancat-2.dtb: pmic@20: '#sound-dai-cells', 'assigned-clock-parents', 'assigned-clocks', 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/mfd/rockchip,rk809.yaml# arch/arm64/boot/dts/rockchip/rk3568-lubancat-2.dtb: mmc@fe310000: Unevaluated properties are not allowed ('supports-emmc' was unexpected) from schema $id: http://devicetree.org/schemas/mmc/snps,dwcmshc-sdhci.yaml# >> arch/arm64/boot/dts/rockchip/rk3568-lubancat-2.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# arch/arm64/boot/dts/rockchip/rk3568-lubancat-2.dtb: sata@fc000000: Unevaluated properties are not allowed ('power-domains' was unexpected) from schema $id: http://devicetree.org/schemas/ata/rockchip,dwc-ahci.yaml# -- >> arch/arm64/boot/dts/rockchip/rk3568-mecsbc.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# -- >> arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5c.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# -- >> arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# -- arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dtb: sata@fc800000: Unevaluated properties are not allowed ('power-domains' was unexpected) from schema $id: http://devicetree.org/schemas/ata/rockchip,dwc-ahci.yaml# arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dtb: pmic@20: '#sound-dai-cells', 'assigned-clock-parents', 'assigned-clocks', 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/mfd/rockchip,rk809.yaml# >> arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dtb: phy@fe830000: 'phy-supply' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/phy/phy-rockchip-naneng-combphy.yaml# arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dtb: phy@fe820000: 'phy-supply' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/phy/phy-rockchip-naneng-combphy.yaml# -- >> arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# -- arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dtb: sata@fc400000: Unevaluated properties are not allowed ('power-domains' was unexpected) from schema $id: http://devicetree.org/schemas/ata/rockchip,dwc-ahci.yaml# >> arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dtb: phy@fe830000: 'phy-supply' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/phy/phy-rockchip-naneng-combphy.yaml# -- arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dtb: sata@fc800000: Unevaluated properties are not allowed ('power-domains' was unexpected) from schema $id: http://devicetree.org/schemas/ata/rockchip,dwc-ahci.yaml# arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dtb: pmic@20: regulators:DCDC_REG1: Unevaluated properties are not allowed ('regulator-init-microvolt' was unexpected) from schema $id: http://devicetree.org/schemas/mfd/rockchip,rk809.yaml# arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dtb: pmic@20: regulators:DCDC_REG2: Unevaluated properties are not allowed ('regulator-init-microvolt' was unexpected) from schema $id: http://devicetree.org/schemas/mfd/rockchip,rk809.yaml# arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dtb: pmic@20: regulators:DCDC_REG4: Unevaluated properties are not allowed ('regulator-init-microvolt' was unexpected) from schema $id: http://devicetree.org/schemas/mfd/rockchip,rk809.yaml# >> arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# -- arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dtb: pmic@20: '#sound-dai-cells', 'assigned-clock-parents', 'assigned-clocks', 'clock-names', 'clocks', 'codec' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/mfd/rockchip,rk809.yaml# >> arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dtb: phy@fe8c0000: 'phy-supply' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/phy/rockchip,pcie3-phy.yaml# -- >> arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5.dtb: rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml# -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-07-06 0:17 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-06-26 1:36 [PATCH v5 0/3] hwrng: add hwrng support for Rockchip RK3568 Daniel Golle 2024-06-26 1:36 ` [PATCH v5 1/3] dt-bindings: rng: Add Rockchip RK3568 TRNG Daniel Golle 2024-06-26 7:31 ` Krzysztof Kozlowski 2024-06-26 1:37 ` [PATCH v5 2/3] hwrng: add hwrng driver for Rockchip RK3568 SoC Daniel Golle 2024-06-26 7:31 ` Krzysztof Kozlowski 2024-07-06 0:15 ` Herbert Xu 2024-06-26 1:37 ` [PATCH v5 3/3] arm64: dts: rockchip: add DT entry for RNG to RK356x Daniel Golle 2024-06-28 20:06 ` kernel test robot
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).