From: Arnd Bergmann <arnd@arndb.de>
To: Loc Ho <lho@apm.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
ijc+devicetree@hellion.org.uk, jcm@redhat.com,
mchehab@osg.samsung.com, patches@apm.com, robh+dt@kernel.org,
bp@alien8.de, dougthompson@xmission.com,
linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org
Subject: Re: [PATCH v10 4/5] edac: Add APM X-Gene SoC EDAC driver
Date: Fri, 22 May 2015 10:59:28 +0200 [thread overview]
Message-ID: <2097631.G0OFDqxtEt@wuerfel> (raw)
In-Reply-To: <1431991481-25684-5-git-send-email-lho@apm.com>
On Monday 18 May 2015 17:24:40 Loc Ho wrote:
> + tmp_ctx.mcu_id = ((res.start >> 16) & 0xF) / 4;
>
Just found this line: you are effectively hardcoding the physical
register layout of the chip in the driver here, to get the index
of the memory controller. This is a very bad idea as it prevents
you from reusing this driver for another chip that puts the
same registers in a different place, don't do that.
Arnd
next prev parent reply other threads:[~2015-05-22 8:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 23:24 [PATCH v10 0/4] edac: Add APM X-Gene SoC EDAC driver Loc Ho
[not found] ` <1431991481-25684-1-git-send-email-lho-qTEPVZfXA3Y@public.gmane.org>
2015-05-18 23:24 ` [PATCH v10 1/5] arm64: Enable EDAC on ARM64 Loc Ho
[not found] ` <1431991481-25684-2-git-send-email-lho-qTEPVZfXA3Y@public.gmane.org>
2015-05-18 23:24 ` [PATCH v10 2/5] MAINTAINERS: Add entry for APM X-Gene SoC EDAC driver Loc Ho
[not found] ` <1431991481-25684-3-git-send-email-lho-qTEPVZfXA3Y@public.gmane.org>
2015-05-18 23:24 ` [PATCH v10 3/5] Documentation: Add documentation for the APM X-Gene SoC EDAC DTS binding Loc Ho
[not found] ` <1431991481-25684-4-git-send-email-lho-qTEPVZfXA3Y@public.gmane.org>
2015-05-18 23:24 ` [PATCH v10 4/5] edac: Add APM X-Gene SoC EDAC driver Loc Ho
[not found] ` <1431991481-25684-5-git-send-email-lho-qTEPVZfXA3Y@public.gmane.org>
2015-05-18 23:24 ` [PATCH v10 5/5] arm64: Add APM X-Gene SoC EDAC DTS entries Loc Ho
2015-05-22 8:23 ` [PATCH v10 4/5] edac: Add APM X-Gene SoC EDAC driver Arnd Bergmann
2015-05-22 8:46 ` Borislav Petkov
[not found] ` <20150522084625.GE23022-fF5Pk5pvG8Y@public.gmane.org>
2015-05-22 8:55 ` Arnd Bergmann
2015-05-22 18:28 ` Loc Ho
2015-05-22 18:25 ` Loc Ho
2015-05-22 8:59 ` Arnd Bergmann [this message]
2015-05-22 8:02 ` [PATCH v10 3/5] Documentation: Add documentation for the APM X-Gene SoC EDAC DTS binding Arnd Bergmann
2015-05-19 17:03 ` [PATCH v10 1/5] arm64: Enable EDAC on ARM64 Borislav Petkov
[not found] ` <20150519170308.GL4641-fF5Pk5pvG8Y@public.gmane.org>
2015-05-19 19:57 ` Loc Ho
[not found] ` <CAPw-ZT=mTpt_vz+e=rM5ywK8feNKkJQrpEWg=noRCziJ0840TQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-19 20:33 ` Borislav Petkov
[not found] ` <20150519203336.GP4641-fF5Pk5pvG8Y@public.gmane.org>
2015-05-21 18:07 ` Borislav Petkov
[not found] ` <20150521180719.GE3689-fF5Pk5pvG8Y@public.gmane.org>
2015-05-21 18:11 ` [RFC PATCH] EDAC: Cleanup atomic_scrub mess Borislav Petkov
2015-05-22 20:13 ` Chris Metcalf
[not found] ` <555F8DE2.4060402-d5a29ZRxExrQT0dZR+AlfA@public.gmane.org>
2015-05-27 15:52 ` Borislav Petkov
[not found] ` <20150527155219.GB19407-fF5Pk5pvG8Y@public.gmane.org>
2015-05-28 2:27 ` Michael Ellerman
[not found] ` <20150521181157.GF3689-fF5Pk5pvG8Y@public.gmane.org>
2015-05-28 12:34 ` Russell King - ARM Linux
[not found] ` <20150528123448.GA2067-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2015-05-28 13:37 ` Borislav Petkov
2015-05-22 8:24 ` [PATCH v10 0/4] edac: Add APM X-Gene SoC EDAC driver Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2097631.G0OFDqxtEt@wuerfel \
--to=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=devicetree@vger.kernel.org \
--cc=dougthompson@xmission.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jcm@redhat.com \
--cc=lho@apm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-edac@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@osg.samsung.com \
--cc=patches@apm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).