From: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
To: Pavel Machek <pavel@denx.de>
Cc: atull <atull@opensource.altera.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
jgunthorpe@obsidianresearch.com, hpa@zytor.com,
Michal Simek <monstr@monstr.eu>,
Michal Simek <michal.simek@xilinx.com>,
rdunlap@infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, robh+dt@kernel.org,
grant.likely@linaro.org, iws@ovro.caltech.edu,
linux-doc@vger.kernel.org, broonie@kernel.org,
philip@balister.org, rubini@gnudd.com, s.trumtrar@pengutronix.de,
jason@lakedaemon.net, kyle.teske@ni.com, nico@linaro.org,
balbi@ti.com, m.chehab@samsung.com, davidb@codeaurora.org,
rob@landley.net, davem@davemloft.net, cesarb@cesarb.net,
sameo@linux.intel.com, akpm@linux-foundation.org,
linus.walleij@linaro.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, devel@driverdev.osuosl.org,
delicious.quinoa@gmail.com, dinguyen@op
Subject: Re: [PATCH v7 2/4] fpga manager: add sysfs interface document
Date: Fri, 2 Jan 2015 12:50:10 +0200 [thread overview]
Message-ID: <20FF5ACF-DA9F-4FBA-AA87-490A73D02A2E@konsulko.com> (raw)
In-Reply-To: <20150102051200.GI4873@amd>
Hi Pavel,
> On Jan 2, 2015, at 07:12 , Pavel Machek <pavel@denx.de> wrote:
>
>
>> +What: /sys/class/fpga_manager/<fpga>/firmware
>> +Date: October 2014
>> +KernelVersion: 3.18
>> +Contact: Alan Tull <atull@opensource.altera.com>
>> +Description: Name of the FPGA image file to load using firmware class.
>
> This is wrong interface, right? The only use of this string is to pass
> it to udev. We should simply pass "fpga-0" as a firware name, and let
> udev figure it out, no need to to prepare name in separate component,
> then pass it to kernel, which passes it back to udev.
>
No. No dependencies on udev please. This should hook directly to the firmware
loader interface which does not rely on userspace at all.
>> +What: /sys/class/fpga_manager/<fpga>/reset
>> +Date: October 2014
>> +KernelVersion: 3.18
>> +Contact: Alan Tull <atull@opensource.altera.com>
>> +Description: Write 1 to reset the FPGA
>
> Does 0 need to be written there to pull the fpga out of reset? Is this
> a suitable interface?
>
> Pavel
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Regards
— Pantelis
next prev parent reply other threads:[~2015-01-02 10:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 16:45 [PATCH v7 0/4] FPGA Manager Framework atull
2014-12-19 16:45 ` [PATCH v7 1/4] doc: add bindings document for altera fpga manager atull
2014-12-22 2:38 ` Rob Herring
2015-01-06 16:04 ` atull
2014-12-19 16:45 ` [PATCH v7 2/4] fpga manager: add sysfs interface document atull
2015-01-02 5:12 ` Pavel Machek
2015-01-02 10:50 ` Pantelis Antoniou [this message]
2014-12-19 16:45 ` [PATCH v7 3/4] staging: fpga manager: framework core atull
2014-12-19 16:45 ` [PATCH v7 4/4] staging: fpga manager: add driver for socfpga fpga manager atull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20FF5ACF-DA9F-4FBA-AA87-490A73D02A2E@konsulko.com \
--to=pantelis.antoniou@konsulko.com \
--cc=akpm@linux-foundation.org \
--cc=atull@opensource.altera.com \
--cc=balbi@ti.com \
--cc=broonie@kernel.org \
--cc=cesarb@cesarb.net \
--cc=davem@davemloft.net \
--cc=davidb@codeaurora.org \
--cc=delicious.quinoa@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@op \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=iws@ovro.caltech.edu \
--cc=jason@lakedaemon.net \
--cc=jgunthorpe@obsidianresearch.com \
--cc=kyle.teske@ni.com \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=nico@linaro.org \
--cc=pavel@denx.de \
--cc=pawel.moll@arm.com \
--cc=philip@balister.org \
--cc=rdunlap@infradead.org \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=rubini@gnudd.com \
--cc=s.trumtrar@pengutronix.de \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).