Re: [PATCH v4 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml

[Krzysztof Kozlowski <krzk@kernel.org>]

On 19/05/2025 03:26, Chaoyi Chen wrote:
> +maintainers:
> +  - Andy Yan <andy.yan@rock-chip.com>
> +  - Heiko Stuebner <heiko@sntech.de>
> +  - Sandy Huang <hjc@rock-chips.com>
> +
> +allOf:
> +  - $ref: /schemas/sound/dai-common.yaml#
> +
> +properties:
> +  compatible:
> +    items:
> +      - const: rockchip,rk3399-cdn-dp
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    items:
> +      - description: DP core work clock
> +      - description: APB clock
> +      - description: SPDIF interface clock
> +      - description: GRF clock
> +
> +  clock-names:
> +    items:
> +      - const: core-clk
> +      - const: pclk
> +      - const: spdif
> +      - const: grf
> +
> +  extcon:
> +    $ref: /schemas/types.yaml#/definitions/phandle-array
> +    items:
> +      maxItems: 1
> +    maxItems: 2

Instead of this, list the items. Old binding said only "specifier", so
this is technically a change, which should be explained in commit msg.

> +    description:
> +      List of phandle to the extcon device providing the cable state for the DP PHY.
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  phys:
> +    items:
> +      maxItems: 1
> +    maxItems: 2
> +    description: |
> +      List of phandle to the PHY device for DP output.
> +      RK3399 have two DP-TPYEC PHY, specifying one PHY which want to use,
> +      or specify two PHYs here to let the driver determine which PHY to use.


You do not allow one phy, so your description is not accurate. OTOH,
original binding did not allow two phandles, so that's another change in
the binding. You need to document all changes done to the binding in the
commit msg.

> +
> +  ports:
> +    $ref: /schemas/graph.yaml#/properties/ports
> +
> +    properties:
> +      port@0:
> +        $ref: /schemas/graph.yaml#/properties/port
> +        description: Input of the CDN DP
> +        properties:
> +          endpoint@0:
> +            description: Connection to the VOPB
> +          endpoint@1:
> +            description: Connection to the VOPL
> +      port@1:
> +        $ref: /schemas/graph.yaml#/properties/port
> +        description: Output of the CDN DP
> +
> +    required:
> +      - port@0
> +      - port@1
> +
> +  power-domains:
> +    maxItems: 1
> +
> +  resets:
> +    maxItems: 4
> +
> +  reset-names:
> +    items:
> +      - const: spdif
> +      - const: dptx
> +      - const: apb
> +      - const: core
> +
> +  rockchip,grf:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description:
> +      Phandle to GRF register to control HPD.
> +
> +  "#sound-dai-cells":
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - interrupts
> +  - phys
> +  - ports
> +  - resets
> +  - reset-names
> +  - rockchip,grf


sound-dai-cells was a required property.

Best regards,
Krzysztof