From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Artur Weber <aweber.kernel@gmail.com>,
Olof Johansson <olof@lixom.net>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
soc@kernel.org, Rob Herring <robh+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v4] ARM: dts: exynos: Add Samsung Galaxy Tab 3 8.0 boards
Date: Fri, 23 Jun 2023 10:04:30 +0200 [thread overview]
Message-ID: <20b480d8-087c-d5fe-08ca-7d2b684f4f96@linaro.org> (raw)
In-Reply-To: <72af054e-e82b-917c-1f9b-fe231dcfa5bf@gmail.com>
On 22/06/2023 14:52, Artur Weber wrote:
> On 04/06/2023 21:15, Krzysztof Kozlowski wrote:
>> On 04/06/2023 18:56, Artur Weber wrote:
>>> +/*
>>> + * This device does not use the built-in RTC; instead, the RTC in the
>>> + * S5M8786 PMIC is used instead. Remove the unused node to avoid DTB check
>>> + * warnings.
>>> + */
>>> +/delete-node/ &rtc;
>>
>> This is not the solution. The S3C RTC is there. Just like all other
>> boards we have two RTCs and DTS should be complete. Definitely you
>> should not remove something just because there were warnings. Instead
>> warnings should be fixed.
>
> The problem is that the built-in RTC does not seem to work on this
> device. I attempted to add it, using the same clocks as other devices
> in mainline using the S5M8676 PMIC:
>
> &rtc {
> status = "okay";
> clocks = <&clock CLK_RTC>, <&s5m8767_osc S2MPS11_CLK_AP>;
> clock-names = "rtc", "rtc_src";
> };
>
> However, it just prints the following on startup:
>
> s3c-rtc 10070000.rtc: rtc disabled, re-enabling
> s3c-rtc 10070000.rtc: registered as rtc0
> s3c-rtc 10070000.rtc: hctosys: unable to read the hardware clock
This should be debugged then... but with explanation is fine to leave
the node disabled.
Removal of nodes is almost never correct.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-06-23 8:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-04 16:56 [PATCH v4] ARM: dts: exynos: Add Samsung Galaxy Tab 3 8.0 boards Artur Weber
2023-06-04 19:15 ` Krzysztof Kozlowski
2023-06-22 12:52 ` Artur Weber
2023-06-23 8:04 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20b480d8-087c-d5fe-08ca-7d2b684f4f96@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=arnd@arndb.de \
--cc=aweber.kernel@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).