From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Robert Marko <robimarko@gmail.com>,
agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
mturquette@baylibre.com, sboyd@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>
Subject: Re: [PATCH 2/3] clk: qcom: ipq6018: add USB GDSCs
Date: Mon, 30 Oct 2023 20:37:35 +0100 [thread overview]
Message-ID: <20c8cfde-3f55-45c5-bc23-21979ac9680d@linaro.org> (raw)
In-Reply-To: <CAOX2RU4MBvDZZ767RPS9XKj0U2L3gviVG5cyR8NKyO4LD+sfYQ@mail.gmail.com>
On 29.10.2023 12:04, Robert Marko wrote:
> On Wed, 25 Oct 2023 at 12:45, Robert Marko <robimarko@gmail.com> wrote:
>>
>> IPQ6018 has GDSC-s for each of the USB ports, so lets define them as such
>> and drop the curent code that is de-asserting the USB GDSC-s as part of
>> the GCC probe.
>>
>> Signed-off-by: Robert Marko <robimarko@gmail.com>
>
> Unfortunately, after testing on multiple devices I hit the same GDSC
> issue I had a long time ago
> that was the reason I did not send this upstream.
> It seems that USB3 port GDSC (USB0 GDSC in code) works just fine,
> however the USB2 one
> (USB1 GDSC in code) it is stuck off and USB2 port will fail due to this:
> 1.607531] ------------[ cut here ]------------
> [ 1.607559] usb1_gdsc status stuck at 'off'
> [ 1.607592] WARNING: CPU: 0 PID: 35 at gdsc_toggle_logic+0x16c/0x174
> [ 1.615120] Modules linked in:
Can you dump GDSCR (the entire 32-bit register) at boot and when toggling?
Konrad
next prev parent reply other threads:[~2023-10-30 19:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 10:44 [PATCH 1/3] dt-bindings: clock: qcom: ipq6018: add USB GDSCs Robert Marko
2023-10-25 10:44 ` [PATCH 2/3] clk: " Robert Marko
2023-10-26 18:42 ` Konrad Dybcio
2023-10-26 18:45 ` Konrad Dybcio
2023-10-27 8:48 ` Robert Marko
2023-10-29 11:04 ` Robert Marko
2023-10-30 19:37 ` Konrad Dybcio [this message]
2023-10-30 20:37 ` Robert Marko
2023-10-30 21:12 ` Konrad Dybcio
2023-10-31 9:01 ` Robert Marko
2023-11-07 21:51 ` Konrad Dybcio
2023-11-11 11:28 ` Robert Marko
2023-11-13 11:58 ` Konrad Dybcio
2023-11-13 12:50 ` Robert Marko
2023-11-15 16:22 ` Konrad Dybcio
2023-11-28 12:25 ` Robert Marko
2023-11-01 7:57 ` Kathiravan Thirumoorthy
2023-10-25 10:44 ` [PATCH 3/3] arm64: dts: qcom: ipq6018: add USB power domains Robert Marko
2023-10-25 12:44 ` [PATCH 1/3] dt-bindings: clock: qcom: ipq6018: add USB GDSCs Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20c8cfde-3f55-45c5-bc23-21979ac9680d@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_kathirav@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=robimarko@gmail.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).