From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alessandro Zanni <alessandro.zanni87@gmail.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
skhan@linuxfoundation.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] dt-bindings: edac: Add Altera SOCFPGA SDRAM EDAC binding
Date: Fri, 2 Aug 2024 08:54:38 +0200 [thread overview]
Message-ID: <20d128b3-ad81-4338-bd59-a039ddcbbadf@kernel.org> (raw)
In-Reply-To: <20240801161005.120111-1-alessandro.zanni87@gmail.com>
On 01/08/2024 18:10, Alessandro Zanni wrote:
> Convert the device tree bindings for the Altera PCIe MSI controller
>
> Signed-off-by: Alessandro Zanni <alessandro.zanni87@gmail.com>
> ---
>
Subject: you did not add binding in this patch. Binding was already
there. You converted one to DT schema.
> Notes:
> v3: moved yaml file from arm/altera to the edac folder, removed items keys, added general node names
>
...
> +
> +examples:
> + - |
> + memory-controller {
> + compatible = "altr,sdram-edac";
> + altr,sdr-syscon = <&sdr>;
> + interrupts = <0 39 4>;
No improvements here.
<form letter>
This is a friendly reminder during the review process.
It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.
Thank you.
</form letter>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-02 6:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 16:10 [PATCH v3] dt-bindings: edac: Add Altera SOCFPGA SDRAM EDAC binding Alessandro Zanni
2024-08-02 6:54 ` Krzysztof Kozlowski [this message]
2024-08-02 14:32 ` Alessandro Zanni
2024-08-04 8:34 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20d128b3-ad81-4338-bd59-a039ddcbbadf@kernel.org \
--to=krzk@kernel.org \
--cc=alessandro.zanni87@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).