From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Stanislav Jakubek <stano.jakubek@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: misc: brcm,kona-smc: convert to YAML
Date: Fri, 5 May 2023 12:36:39 +0200 [thread overview]
Message-ID: <20d58d52-afab-dced-1d55-c839b8938595@linaro.org> (raw)
In-Reply-To: <20230505071822.GA3236@standask-GA-A55M-S2HP>
On 05/05/2023 09:18, Stanislav Jakubek wrote:
>>> + - items:
>>> + - enum:
>>> + - brcm,bcm11351-smc
>>> + - brcm,bcm21664-smc
>>> + - brcm,bcm23550-smc
>>> + - const: brcm,kona-smc
>>> + - items:
>>> + - const: bcm,bcm11351-smc
>>> + - const: bcm,kona-smc
>>> + deprecated: true
>>
>> That's not correct. You deprecate the same set as you allow before. I
>> think you wanted to deprecated kona-smc alone.
>
> What I'm trying to do here is to deprecate both compatibles with the
> "bcm" vendor prefix, as these were initially introduced in [1]. bcm11351 is the
> only one that ever had the "bcm" prefix, both bcm21664 [2] and bcm23550 [3]
> were introduced with the "brcm" prefix (though they were never documented).
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=7f6c62e2695bcb1547afdeb4ad3bcdf8c610be2c
> [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=2eba905e860f8aed5f2743b45259bb2e92548a55
> [3] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=fcd4138653f049c8fa45b48dc5f2806ced68e304
Ah, right, I missed the difference in prefix. I propose to just drop it.
It was deprecated 10 years ago!
Best regards,
Krzysztof
prev parent reply other threads:[~2023-05-05 10:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 19:02 [PATCH] dt-bindings: misc: brcm,kona-smc: convert to YAML Stanislav Jakubek
2023-05-05 6:49 ` Krzysztof Kozlowski
2023-05-05 7:18 ` Stanislav Jakubek
2023-05-05 10:36 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20d58d52-afab-dced-1d55-c839b8938595@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=stano.jakubek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox