From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Henrik Grimler <henrik@grimler.se>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
alim.akhtar@samsung.com, m.szyprowski@samsung.com,
jenneron@protonmail.com, markuss.broks@gmail.com,
martin.juecker@gmail.com, virag.david003@gmail.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v5 1/2] ARM: dts: exynos: replace mshc0 alias with mmc-ddr-1_8v property
Date: Fri, 17 Mar 2023 12:55:40 +0100 [thread overview]
Message-ID: <20db729f-e8fb-3d16-54a2-b9a54b9a1b55@linaro.org> (raw)
In-Reply-To: <20230316211558.8526-2-henrik@grimler.se>
On 16/03/2023 22:15, Henrik Grimler wrote:
> Previously, the mshc0 alias has been necessary so that
> MMC_CAP_1_8V_DDR | MMC_CAP_8_BIT_DATA are set for mshc_0/mmc_0.
> However, these capabilities should be described in the device tree so
> that we do not have to rely on the alias.
>
> The property mmc-ddr-1_8v replaces MMC_CAP_1_8V_DDR, while bus_width =
> <8>, which is already set for all the mshc0/mmc0 nodes, replaces
> MMC_CAP_8_BIT_DATA.
>
> Also drop other mshc aliases as they are not needed.
>
> Signed-off-by: Henrik Grimler <henrik@grimler.se>
> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
>
> ---
>
> Changes since v4:
> * Do not set mmc-ddr-1_8v for sdhci_0 on Exynos 4210,
> following Marek's tests
>
> Changes since v3:
> * Drop attempt at node sorting/cleaning
> * Move two mmc alias additions to the other patch
> * Update commit message
>
> Changes since v2:
> * Set mmc-ddr-1_8v in device trees for mshc_0/mmc_0
>
>
> arch/arm/boot/dts/exynos3250-artik5.dtsi | 1 +
> arch/arm/boot/dts/exynos3250-monk.dts | 1 +
> arch/arm/boot/dts/exynos3250-rinato.dts | 1 +
Why you do not remove Exynos3250 aliases?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-17 11:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 21:15 [PATCH v5 0/2] ARM: dts: add mmc aliases for Exynos devices Henrik Grimler
2023-03-16 21:15 ` [PATCH v5 1/2] ARM: dts: exynos: replace mshc0 alias with mmc-ddr-1_8v property Henrik Grimler
2023-03-17 11:55 ` Krzysztof Kozlowski [this message]
2023-03-19 20:13 ` Henrik Grimler
2023-03-16 21:15 ` [PATCH v5 2/2] ARM: dts: exynos: add mmc aliases Henrik Grimler
2023-03-17 12:28 ` Krzysztof Kozlowski
2023-03-19 20:13 ` Henrik Grimler
2023-03-24 11:29 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20db729f-e8fb-3d16-54a2-b9a54b9a1b55@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=henrik@grimler.se \
--cc=jenneron@protonmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=markuss.broks@gmail.com \
--cc=martin.juecker@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=virag.david003@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).