From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
andersson@kernel.org, agross@kernel.org, mturquette@baylibre.com,
sboyd@kernel.org, dmitry.baryshkov@linaro.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, jonathan@marek.ca, quic_tdas@quicinc.com,
vladimir.zapolskiy@linaro.org
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v4 3/4] clk: qcom: camcc-sc8280xp: Add sc8280xp CAMCC
Date: Thu, 26 Oct 2023 13:21:23 +0200 [thread overview]
Message-ID: <20e2801d-df4f-436e-a677-2c81d43e3273@linaro.org> (raw)
In-Reply-To: <20231026105345.3376-4-bryan.odonoghue@linaro.org>
On 10/26/23 12:53, Bryan O'Donoghue wrote:
> Add the sc8280xp CAMCC driver which follows the sdm845 CAMCC lineage
> with additional CCI and IFE blocks and more granular clock parentage.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
[...]
> +static struct gdsc titan_top_gdsc;
> +
> +static struct gdsc bps_gdsc = {
> + .gdscr = 0x7004,
> + .pd = {
> + .name = "bps_gdsc",
> + },
> + .flags = HW_CTRL | RETAIN_FF_ENABLE,
This should really be HW_CTRL_TRIGGER from [1]
and then downstream uses cam_bps_transfer_gdsc_control and
cam_bps_get_gdsc_control to control hw (fast) or sw (normal) mode
similarly in drivers/cam_icp/icp_hw/ipe_hw/ipe_soc.c for IPE
[...]
> + /*
> + * Keep camcc_gdsc_clk always enabled:
> + */
> + regmap_update_bits(regmap, 0xc1e4, BIT(0), 1);
/* Keep camcc_gdsc_clk always enabled */
regmap_update_bits(regmap, 0xc1e4, BIT(0), BIT(0));
[1] https://lore.kernel.org/linux-arm-msm/20230923115008.1698384-4-abel.vesa@linaro.org/
Konrad
next prev parent reply other threads:[~2023-10-26 11:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 10:53 [RESEND PATCH v4 0/4] Add sc8280xp CAMCC bindings and driver Bryan O'Donoghue
2023-10-26 10:53 ` [RESEND PATCH v4 1/4] dt-bindings: clock: Use gcc.yaml for common clock properties Bryan O'Donoghue
2023-10-26 10:53 ` [RESEND PATCH v4 2/4] dt-bindings: clock: Add SC8280XP CAMCC Bryan O'Donoghue
2023-10-26 10:53 ` [RESEND PATCH v4 3/4] clk: qcom: camcc-sc8280xp: Add sc8280xp CAMCC Bryan O'Donoghue
2023-10-26 11:21 ` Konrad Dybcio [this message]
2023-10-26 11:34 ` Bryan O'Donoghue
2023-10-26 18:39 ` Konrad Dybcio
2023-10-26 10:53 ` [RESEND PATCH v4 4/4] arm64: dts: qcom: sc8280xp: Add in CAMCC for sc8280xp Bryan O'Donoghue
2023-10-26 11:21 ` Konrad Dybcio
2023-11-16 12:16 ` [RESEND PATCH v4 0/4] Add sc8280xp CAMCC bindings and driver Bryan O'Donoghue
2023-12-08 2:57 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20e2801d-df4f-436e-a677-2c81d43e3273@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jonathan@marek.ca \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_tdas@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).