Re: [PATCH v7 10/20] soc: mediatek: mtk-cmdq: Add new APIs to replace cmdq_pkt_write() and cmdq_pkt_write_mask()

["Jason-JH Lin (林睿祥)" <Jason-JH.Lin@mediatek.com>]

[snip]

> > > > +
> > > > +int cmdq_pkt_write_mask_subsys(struct cmdq_pkt *pkt, u8
> > > > subsys,
> > > > u32 pa_base /*unused*/,
> > > > +                          u16 offset, u32 value, u32 mask)
> > > 
> > > pa_base is useless. Drop it.
> > > 
> > > > +{
> > > > +   return cmdq_pkt_write_mask(pkt, subsys, offset, value,
> > > > mask);
> > > > +}
> > > > +EXPORT_SYMBOL(cmdq_pkt_write_mask_subsys);
> > > > +
> > 
> > Hi CK,
> > 
> > I'll drop the unused parameters.
> > Thanks for the reviews.
> 
> It's unused, but if we want to use function pointers we do need
> those.
> 
> Unless you want to use one variable for both things, which then
> becomes
> kind of janky and unreadable.
> 

Yes, I encountered this problem when I was editing it yesterday.

I'll keep these unused parameters to make the function pointer
interface aligned and send the next version soon.

Thanks,
Jason-JH Lin

> Cheers,
> Angelo
> 
> > 
> > Regards,
> > Jason-JH Lin