From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F117332906; Tue, 7 Jul 2026 08:46:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783414017; cv=none; b=ZFZJ4EAc/mCRd6Yfw6EQwGGai7pQ2lXg47kHExgQ5b2OTtdjn1qkMXhqo0g4w2Csw/b6AGYspbFg2Hv6YFuX4EmgiTtPb9CBySkvqdl8jSbyFW2ZgojCog5ZDYN9HaHJzrpuHv6vI4qghQ9pUFhfjx8HgHOhYpHgTiMwB8Is1hA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783414017; c=relaxed/simple; bh=228aUnoMVVrnNGBKK/TOVHsEsR0ak9z+UVu2BN4AsGU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bLtjc+d1ltTvSqiURdeda3IgklqbgXbBTNu72wD47zm9tRanDHdOoJkA5wKV/N7MK9S58mFcRiF+on6aCY5sd1Y52erAkOicj2spEV7+jyTWVPQxxrMl3kv5qY6riRCAa+pSTW9nPlFzpNbN2DVu/z9bJerddTnZ6nl+FXirwIs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Q34GhtcG; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Q34GhtcG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BCD701F000E9; Tue, 7 Jul 2026 08:46:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783414015; bh=bUxqzJp0aVr/7EIdEb8wQgLJ1KH0IEqs74J0kNd0hvs=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=Q34GhtcGoe4z/54p5UBfiNVjEf2/byb1VnFIebzUkmu3qxhYUDMKE46TQwHFNKxhN cKajMD/KZtsjTD3U7EwR321t0OXQUhj552k/FLs6AKxtl6V5mE8mrmTOnjz+SJRugV aHODYcmhoXooIPyZRiDgJbodnHUilWd7X2Q5tAVICxSPo5lBKezSxxvyi0hy2UdDQP ycOuCZk7/qKkdfdn/oHjjEk0dpYPdcB9vOuM+reXQC/sJ3hWqG+AxrnCUe8CYDvB8f g79HChgWaoMf5JVv6Fdfs+Tp+gAkrWWogJh5nYycNLtMWrKh9WnWHuCegboWGrB/Mc hGv2dnoqtmXMw== Message-ID: <20fa0bb5-1bdd-4ea2-9266-710dbde9d4c1@kernel.org> Date: Tue, 7 Jul 2026 10:46:49 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Revert "dt-bindings: i2c: Describe SA8255p" To: Shawn Guo Cc: Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Praveen Talari , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260707080229.3795971-1-shengchao.guo@oss.qualcomm.com> <5926f59b-e0c6-46fe-a839-620a2648c335@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 07/07/2026 10:43, Shawn Guo wrote: > On Tue, Jul 07, 2026 at 10:08:09AM +0200, Krzysztof Kozlowski wrote: >> On 07/07/2026 10:02, Shawn Guo wrote: >>> This reverts commit fd359c0272bb4078f3a7ef34c1d53ee0deb59900. >>> >>> Compatible "qcom,sa8255p-geni-i2c" had already been defined by >>> soc/qcom/qcom,sa8255p-geni-se-qup.yaml. Revert the change to avoid the >>> same compatible being defined by two bindings. >> >> This makes no sense and to prove it: are you going to revert all such >> bindings, like 100 of them? > > Nord compatible "qcom,sa8797p-geni-i2c" was added to > soc/qcom/qcom,sa8255p-geni-se-qup.yaml, as that's where Lemans compatible > "qcom,sa8255p-geni-i2c" is defined. CHECK_DTBS has been working fine by > matching geni-se-qup yaml. > > make CHECK_DTBS=y qcom/sa8797p-ride.dtb > > Now with this geni-i2c yaml comes in play, CHECK_DTBS finds it instead > and starts complaining about Nord compatible missing there. > > DTC [C] arch/arm64/boot/dts/qcom/sa8797p-ride.dtb > arch/arm64/boot/dts/qcom/sa8797p-ride.dtb: i2c@880000 (qcom,sa8797p-geni-i2c): compatible:0: 'qcom,sa8255p-geni-i2c' was expected > from schema $id: http://devicetree.org/schemas/i2c/qcom,sa8255p-geni-i2c.yaml > arch/arm64/boot/dts/qcom/sa8797p-ride.dtb: i2c@880000 (qcom,sa8797p-geni-i2c): compatible: ['qcom,sa8797p-geni-i2c', 'qcom,sa8255p-geni-i2c'] is too long > from schema $id: http://devicetree.org/schemas/i2c/qcom,sa8255p-geni-i2c.yaml > > What's your suggestion to fix the problem, add Nord compatible to > geni-se-qup yaml as well? I don't understand what is the problem, but you also did not answer to my question. If you answered my question, you would answer above, but in case question was unclear so let me rephrase it: why do you revert only this duplicated compatible but not 100 others? Best regards, Krzysztof