From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF3D4C00145 for ; Mon, 12 Dec 2022 13:39:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232851AbiLLNjy (ORCPT ); Mon, 12 Dec 2022 08:39:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232840AbiLLNje (ORCPT ); Mon, 12 Dec 2022 08:39:34 -0500 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 319BD14D3D for ; Mon, 12 Dec 2022 05:38:27 -0800 (PST) Received: by mail-lf1-x12d.google.com with SMTP id y25so18599492lfa.9 for ; Mon, 12 Dec 2022 05:38:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5XaoqYPcstX2vkS44Es/ogTcUNI1GuvolK6Dv6wUJUc=; b=XUqT3au53d6d9bBUS18grnSa04NrSeqJ4CBP9J4zSz/1Vx16d96vKWk7qC1sVh3joL MRPrfwWh/rglFXrc03Q+iPTN1LF8Lio+LDYO5VFbLXIbzwEu6ustI0HEj7absedxAOsA N81YDd/29+Ms2kleUnVxPiNoPdmxdVm/ODh0i+rfyni8UVnzo0nX//2c94vLCs36qlTm qKkFYiEch8OOKxGijjWeLwtGoM3SylCvN4oPS0QBFl9XnagVwhiGYKXRHvbylVGuk6qF d6ZmjYiPu6t+CXpDfsEQNvWrtxEv1PxY9LQRfBPb29nxQjmSl9OU9vl7D8iatdgjwr6+ M7Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5XaoqYPcstX2vkS44Es/ogTcUNI1GuvolK6Dv6wUJUc=; b=AqSXZZ3UMjeKA9xlXOKgNM5S0qsysZl5LNtfh+jYBN+JE/4GlJRreFHwObsDK45+fM XlBFlm9hIhEeNVi/eQyDKKKkr9X7JaPJdY02Kho8EEZZHyYi1seB5JlNywsAmyGUZeym 0YVaj1CP+l7Rg3BqdrCHYV6VRKTvZ5uYOhpza2JszyZ1xWW2Igpm9yYzAFYlGcj5r8g5 yB82lT65RhMjmt12qkEqk/sOpmTqACNgBUeNaSxpsAq4dzMhIbruwa5bd+bP+9ewnBJZ Muc8/W8Rnh6b8nq3WSDoEsXcAj6BcSBUOOIHyKqID56Eh5b38080ixOeaf5H6uQx+N5A 0tAg== X-Gm-Message-State: ANoB5pk2rEoYHmJpqAypq3MOpqkSG2nUDSz54NLVyZ5E9oTg2G8YrtW6 +eF7+3iZ0z2p15oCtbZQarxRXQ== X-Google-Smtp-Source: AA0mqf6/hxsy5FnJXs6wytAFIbgsQrbKOzve15vDPnggvJsgQcFq2I3Nap9smAPQG7jiiyHD5+mV0A== X-Received: by 2002:a05:6512:21b:b0:4b5:5098:e6f7 with SMTP id a27-20020a056512021b00b004b55098e6f7mr3451086lfo.68.1670852305496; Mon, 12 Dec 2022 05:38:25 -0800 (PST) Received: from [192.168.1.101] (abxh44.neoplus.adsl.tpnet.pl. [83.9.1.44]) by smtp.gmail.com with ESMTPSA id m6-20020a056512358600b00499b27a329esm1632967lfr.300.2022.12.12.05.38.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Dec 2022 05:38:25 -0800 (PST) Message-ID: <20fcf298-7d91-0458-489d-4fb65cdff380@linaro.org> Date: Mon, 12 Dec 2022 14:38:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 4/4] arm64: dts: qcom: rename AOSS QMP node to pmu Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221212133303.39610-1-krzysztof.kozlowski@linaro.org> <20221212133303.39610-4-krzysztof.kozlowski@linaro.org> From: Konrad Dybcio In-Reply-To: <20221212133303.39610-4-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12.12.2022 14:33, Krzysztof Kozlowski wrote: > The Always On Subsystem (AOSS) QMP is not a power domain controller > since commit 135780456218 ("arm64: dts: qcom: sc7180: Use QMP property > to control load state") and few others. In fact, it was never a power > domain controller but rather control of power state of remote > processors. This power state control is know handled differently, thus > the AOSS QMP nodes do not have power-domain-cells: > > sc7280-idp.dtb: power-controller@c300000: '#power-domain-cells' is a required property > From schema: Documentation/devicetree/bindings/power/power-domain.yaml > > AOSS QMP is an interface to the actuall AOSS subsystem responsible for > some of power management functions, thus let's call the nodes as "pmu" - > Power Management Unit. power-management@ is used on apple and rockchip and pmu is very ambiguous (power management or performance measurement unit). Konrad > > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +- > arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 +- > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- > arch/arm64/boot/dts/qcom/sm6350.dtsi | 2 +- > arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 +- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +- > arch/arm64/boot/dts/qcom/sm8350.dtsi | 2 +- > arch/arm64/boot/dts/qcom/sm8450.dtsi | 2 +- > 9 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index 906fb9343bcc..7e781570b2c6 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -3248,7 +3248,7 @@ aoss_reset: reset-controller@c2a0000 { > #reset-cells = <1>; > }; > > - aoss_qmp: power-controller@c300000 { > + aoss_qmp: pmu@c300000 { > compatible = "qcom,sc7180-aoss-qmp", "qcom,aoss-qmp"; > reg = <0 0x0c300000 0 0x400>; > interrupts = ; > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index 7c24c2129800..b08ddeb7bcec 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -4257,7 +4257,7 @@ aoss_reset: reset-controller@c2a0000 { > #reset-cells = <1>; > }; > > - aoss_qmp: power-controller@c300000 { > + aoss_qmp: pmu@c300000 { > compatible = "qcom,sc7280-aoss-qmp", "qcom,aoss-qmp"; > reg = <0 0x0c300000 0 0x400>; > interrupts-extended = <&ipcc IPCC_CLIENT_AOP > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index 3cb4ca6c53eb..e04f1f751881 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -1921,7 +1921,7 @@ tsens1: thermal-sensor@c265000 { > #thermal-sensor-cells = <1>; > }; > > - aoss_qmp: power-controller@c300000 { > + aoss_qmp: pmu@c300000 { > compatible = "qcom,sc8280xp-aoss-qmp", "qcom,aoss-qmp"; > reg = <0 0x0c300000 0 0x400>; > interrupts-extended = <&ipcc IPCC_CLIENT_AOP IPCC_MPROC_SIGNAL_GLINK_QMP IRQ_TYPE_EDGE_RISING>; > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index 5f1f7cb52c90..2e15a003825e 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -4965,7 +4965,7 @@ aoss_reset: reset-controller@c2a0000 { > #reset-cells = <1>; > }; > > - aoss_qmp: power-controller@c300000 { > + aoss_qmp: pmu@c300000 { > compatible = "qcom,sdm845-aoss-qmp", "qcom,aoss-qmp"; > reg = <0 0x0c300000 0 0x400>; > interrupts = ; > diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi > index 0f01ff4feb55..bb20fed0f4f0 100644 > --- a/arch/arm64/boot/dts/qcom/sm6350.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi > @@ -1273,7 +1273,7 @@ tsens1: thermal-sensor@c265000 { > #thermal-sensor-cells = <1>; > }; > > - aoss_qmp: power-controller@c300000 { > + aoss_qmp: pmu@c300000 { > compatible = "qcom,sm6350-aoss-qmp", "qcom,aoss-qmp"; > reg = <0 0x0c300000 0 0x1000>; > interrupts-extended = <&ipcc IPCC_CLIENT_AOP IPCC_MPROC_SIGNAL_GLINK_QMP > diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi > index d1b64280ab0b..ad6902b13a71 100644 > --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi > @@ -3589,7 +3589,7 @@ pdc: interrupt-controller@b220000 { > interrupt-controller; > }; > > - aoss_qmp: power-controller@c300000 { > + aoss_qmp: pmu@c300000 { > compatible = "qcom,sm8150-aoss-qmp", "qcom,aoss-qmp"; > reg = <0x0 0x0c300000 0x0 0x400>; > interrupts = ; > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > index fbbbae29e0c2..6faf13ed90c1 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -3741,7 +3741,7 @@ tsens1: thermal-sensor@c265000 { > #thermal-sensor-cells = <1>; > }; > > - aoss_qmp: power-controller@c300000 { > + aoss_qmp: pmu@c300000 { > compatible = "qcom,sm8250-aoss-qmp", "qcom,aoss-qmp"; > reg = <0 0x0c300000 0 0x400>; > interrupts-extended = <&ipcc IPCC_CLIENT_AOP > diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi > index 49db223a0777..519e436aeab9 100644 > --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi > @@ -1717,7 +1717,7 @@ tsens1: thermal-sensor@c265000 { > #thermal-sensor-cells = <1>; > }; > > - aoss_qmp: power-controller@c300000 { > + aoss_qmp: pmu@c300000 { > compatible = "qcom,sm8350-aoss-qmp", "qcom,aoss-qmp"; > reg = <0 0x0c300000 0 0x400>; > interrupts-extended = <&ipcc IPCC_CLIENT_AOP IPCC_MPROC_SIGNAL_GLINK_QMP > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi > index e0d30dadbf8b..234fe6549fe0 100644 > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi > @@ -2453,7 +2453,7 @@ tsens1: thermal-sensor@c265000 { > #thermal-sensor-cells = <1>; > }; > > - aoss_qmp: power-controller@c300000 { > + aoss_qmp: pmu@c300000 { > compatible = "qcom,sm8450-aoss-qmp", "qcom,aoss-qmp"; > reg = <0 0x0c300000 0 0x400>; > interrupts-extended = <&ipcc IPCC_CLIENT_AOP IPCC_MPROC_SIGNAL_GLINK_QMP