From: "Heiko Stübner" <heiko@sntech.de>
To: Christopher Obbard <chris.obbard@collabora.com>,
Dragan Simic <dsimic@manjaro.org>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Kever Yang <kever.yang@rock-chips.com>
Subject: Re: [PATCH 0/2] Add support for Firefly CORE PX30 JD4
Date: Tue, 16 Jul 2024 22:07:56 +0200 [thread overview]
Message-ID: <2101274.K71DO8KEF6@diego> (raw)
In-Reply-To: <81015d015aae01f2d5fa70262304837e@manjaro.org>
Am Dienstag, 16. Juli 2024, 19:45:44 CEST schrieb Dragan Simic:
> Hello Christopher,
>
> On 2024-07-16 17:51, Christopher Obbard wrote:
> > The Firefly CORE PX30 JD4 board is a SOM and motherboard bundle from
> > Firefly containing the Rockchip PX30 SOC. This series adds support for
> > it.
> >
> > ---
> > Christopher Obbard (2):
> > dt-bindings: arm: rockchip: add Firefly CORE PX30 JD4
> > arm64: dts: rockchip: add Firefly CORE PX30 JD4
> >
> > .../devicetree/bindings/arm/rockchip.yaml | 5 +
> > arch/arm64/boot/dts/rockchip/Makefile | 1 +
> > .../dts/rockchip/px30-firefly-core-px30-jd4.dts | 562
> > +++++++++++++++++++++
> > 3 files changed, 568 insertions(+)
>
> It would be better to split this into two separate files: a dtsi
> for the SoM, and a dts for the carrier board (which would include
> the new dtsi). That would reflect the actual hardware better.
correct :-) .
There are numerous examples of these types in the kernel
already, both these combinations - for inspiration :-) .
next prev parent reply other threads:[~2024-07-16 20:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-16 15:51 [PATCH 0/2] Add support for Firefly CORE PX30 JD4 Christopher Obbard
2024-07-16 15:51 ` [PATCH 1/2] dt-bindings: arm: rockchip: add " Christopher Obbard
2024-07-16 16:26 ` Conor Dooley
2024-07-16 16:36 ` Christopher Obbard
2024-07-16 15:51 ` [PATCH 2/2] arm64: dts: " Christopher Obbard
2024-07-16 17:45 ` [PATCH 0/2] Add support for " Dragan Simic
2024-07-16 20:07 ` Heiko Stübner [this message]
2024-07-16 21:12 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2101274.K71DO8KEF6@diego \
--to=heiko@sntech.de \
--cc=chris.obbard@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dsimic@manjaro.org \
--cc=kever.yang@rock-chips.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).