Re: [PATCH] dt-bindings: pwm: rockchip: Allow "interrupts" prooperty

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 07/01/2024 00:25, Uwe Kleine-König wrote:
> Hello,
> 
> On Sat, Jan 06, 2024 at 10:25:10PM +0100, Johan Jonker wrote:
>> On 1/6/24 18:10, Krzysztof Kozlowski wrote:
>>> On 06/01/2024 15:26, Uwe Kleine-König wrote:
>>>> This fixes the dtbs_check error
>>>>
>>>> 	arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dtb: pwm@10280030: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
>>>> 	from schema $id: http://devicetree.org/schemas/pwm/pwm-rockchip.yaml#
>>>>
>>>> in several device trees.
>>>>
>>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>>
>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> NAK
>>
>> There's a reason why this isn't implemented before:
>>
>> [RFC PATCH v1 1/2] dt-bindings: pwm: rockchip: add interrupts property <https://lore.kernel.org/linux-rockchip/ed3df2c8-ffb5-1723-0ed7-3a2721972852@gmail.com/#r>
>>
>> https://lore.kernel.org/linux-rockchip/ed3df2c8-ffb5-1723-0ed7-3a2721972852@gmail.com/
>>
>> [PATCH 1/1] dt-bindings: pwm: rockchip: Add description for rk3588 <https://lore.kernel.org/linux-rockchip/20220901135523.52151-1-sebastian.reichel@collabora.com/#r>
>>
>> https://lore.kernel.org/linux-rockchip/66b5b616-ae9f-a1aa-e2b5-450f570cfcdd@gmail.com/
>>
>> [PATCH v1 03/11] dt-bindings: pwm: rockchip: add rockchip,rk3128-pwm <https://lore.kernel.org/linux-rockchip/f5dd0ee4-d97e-d878-ffde-c06e9b233e38@gmail.com/>
>>
>> https://lore.kernel.org/linux-rockchip/946d8ac2-6ff2-093a-ad3c-aa755e00d1dd@arm.com/
>>
>>
>> On how to correctly model the DT with common interrupts , PWM and one shot as a sort of MFD etc there's no consensus yet.
>>
>> Leaf it as it is till someone made a working driver demo, so that the coder is free to model a DT solution that fits to him/her.
> 
> Having the warnings until this happens is bad though. If describing the
> irqs in the schema is considered wrong, we should remove the interrupts
> properties from the device tree sources.

I think the previous thread mixes bindings with driver. Does the
hardware have interrupt? Yes? Add it to the bindings. No? Don't add it.

However Johan's reply is saying something about driver, so how is it
related?


Best regards,
Krzysztof