From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E327C433FE for ; Fri, 4 Nov 2022 07:13:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229900AbiKDHNb (ORCPT ); Fri, 4 Nov 2022 03:13:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229496AbiKDHNa (ORCPT ); Fri, 4 Nov 2022 03:13:30 -0400 Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1808E27B22 for ; Fri, 4 Nov 2022 00:13:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1667546008; x=1699082008; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=xd0p4wIkQZstjM24CW/U/ZPDBuX1FLgsH4lw2kNwVrI=; b=ONFP7eo1l9V5OVnBCINP/VNXEjBSZUoVd39/1r1HOXbhqrRPVTdO76m6 vnbOhB46kxuaCR8FKw74LA87937esXaWB9vg+Q1TN7klvFRj6hBP4sabO 5BRNB4ZxJZCkJqP/unbw6JNvTpWV3ZPJ5/D5gqcD+rkaePEvZysAMO816 4sm1yHZA6hBu7W4P724ACH3p1GGmeH6kuskp7/T4V6jZ9h9TxiMcLPT5h xc+NyqoiF2bXlou3UsXy4wfrwBIqTfhksJUuBMgkKbnBw6tUX5hfHoYs2 oRKnPUarCna1DbVcUeIORckefBRbgwGzNQJhcFikAr1xOPE8RuHDt1aNu A==; X-IronPort-AV: E=Sophos;i="5.96,136,1665439200"; d="scan'208";a="27152653" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 04 Nov 2022 08:13:26 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Fri, 04 Nov 2022 08:13:26 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Fri, 04 Nov 2022 08:13:26 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1667546006; x=1699082006; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=xd0p4wIkQZstjM24CW/U/ZPDBuX1FLgsH4lw2kNwVrI=; b=T9Ai2bkWX9AUiKBnG4CwZhu4OMFH/+pA6EseudXmSxiM2g0Ins+jniCr Nr+++h9ihgyBnq/p13Afv/YDSKn9jojzXNvu2GFBISgIWwMICsLvprg4E gYt/uRmh0CWVOdIu1fZ7zIsOt1d1DNKFd/AwRExjAsSLowBGiNwPu/qOF Q0RtHf/2ydLgpOxYh/2qFuHDsG4L8Sc0iHn7246rKlHqHrDnb2Zu0JWXr wBOEE0oqmEETHmsvuMIgCa/kqdFNXwG104gB38T08ENEEtlI0nKrTSgYz 19236yIAdTYEOcKmj3jod20rN1ru1DvxGuPUGVAUZfH57yGej0l03ki2m Q==; X-IronPort-AV: E=Sophos;i="5.96,136,1665439200"; d="scan'208";a="27152652" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 04 Nov 2022 08:13:25 +0100 Received: from steina-w.localnet (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id A2D50280056; Fri, 4 Nov 2022 08:13:25 +0100 (CET) From: Alexander Stein To: Marek Vasut Cc: linux-arm-kernel@lists.infradead.org, Marek Vasut , Adam Ford , Fabio Estevam , Joakim Zhang , Krzysztof Kozlowski , Laurent Pinchart , Lucas Stach , Markus Niebel , NXP Linux Team , Paul Elder , Peng Fan , Pengutronix Kernel Team , Richard Zhu , Rob Herring , Sascha Hauer , Shawn Guo , Tim Harvey , devicetree@vger.kernel.org Subject: Re: [PATCH 1/3] arm64: dts: imx8mq: Swap SAI DMA order Date: Fri, 04 Nov 2022 08:13:22 +0100 Message-ID: <2105362.yKVeVyVuyW@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20221103181920.95736-1-marex@denx.de> References: <20221103181920.95736-1-marex@denx.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Marek, thanks for this patch. Am Donnerstag, 3. November 2022, 19:19:18 CET schrieb Marek Vasut: > Swap the SAI dmas and dma-names to match the order documented in > Documentation/devicetree/bindings/sound/fsl-sai.txt This file has been converted to Documentation/devicetree/bindings/sound/ fsl,sai.yaml in commit d563336877b2 ("ASoC: dt-bindings: fsl,sai: Convert format to json-schema"). In next since next-20220816. In this schema the DMA order 'tx', 'rx' is only for fsl,vf610-sai, all other compatibles use 'rx', 'tx'. So this swap is not needed anymore. Same is for imx8mm and imx8mn. This change should have been made before schema conversion, so they would have been identical on all compatibles... Best regards, Alexander > using the following regex: > > " > s@\(dma[^=]\+= \)\([^,]\+\), \([^;]\+\);@\1\3, \2; > " > > No functional change. > > Signed-off-by: Marek Vasut > --- > Cc: Adam Ford > Cc: Alexander Stein > Cc: Fabio Estevam > Cc: Joakim Zhang > Cc: Krzysztof Kozlowski > Cc: Laurent Pinchart > Cc: Lucas Stach > Cc: Marek Vasut > Cc: Markus Niebel > Cc: NXP Linux Team > Cc: Paul Elder > Cc: Peng Fan > Cc: Pengutronix Kernel Team > Cc: Richard Zhu > Cc: Rob Herring > Cc: Sascha Hauer > Cc: Shawn Guo > Cc: Tim Harvey > Cc: devicetree@vger.kernel.org > To: linux-arm-kernel@lists.infradead.org > --- > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > b/arch/arm64/boot/dts/freescale/imx8mq.dtsi index > c47e2d7235d3e..f00b040ca03e9 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > @@ -345,8 +345,8 @@ sai1: sai@30010000 { > <&clk IMX8MQ_CLK_SAI1_ROOT>, > <&clk IMX8MQ_CLK_DUMMY>, <&clk IMX8MQ_CLK_DUMMY>; > clock-names = "bus", "mclk1", "mclk2", "mclk3"; > - dmas = <&sdma2 8 24 0>, <&sdma1 9 24 0>; > - dma-names = "rx", "tx"; > + dmas = <&sdma1 9 24 0>, <&sdma2 8 24 0>; > + dma-names = "tx", "rx"; > status = "disabled"; > }; > > @@ -359,8 +359,8 @@ sai6: sai@30030000 { > <&clk IMX8MQ_CLK_SAI6_ROOT>, > <&clk IMX8MQ_CLK_DUMMY>, <&clk IMX8MQ_CLK_DUMMY>; > clock-names = "bus", "mclk1", "mclk2", "mclk3"; > - dmas = <&sdma2 4 24 0>, <&sdma2 5 24 0>; > - dma-names = "rx", "tx"; > + dmas = <&sdma2 5 24 0>, <&sdma2 4 24 0>; > + dma-names = "tx", "rx"; > status = "disabled"; > }; > > @@ -373,8 +373,8 @@ sai5: sai@30040000 { > <&clk IMX8MQ_CLK_SAI5_ROOT>, > <&clk IMX8MQ_CLK_DUMMY>, <&clk IMX8MQ_CLK_DUMMY>; > clock-names = "bus", "mclk1", "mclk2", "mclk3"; > - dmas = <&sdma2 2 24 0>, <&sdma2 3 24 0>; > - dma-names = "rx", "tx"; > + dmas = <&sdma2 3 24 0>, <&sdma2 2 24 0>; > + dma-names = "tx", "rx"; > status = "disabled"; > }; > > @@ -387,8 +387,8 @@ sai4: sai@30050000 { > <&clk IMX8MQ_CLK_SAI4_ROOT>, > <&clk IMX8MQ_CLK_DUMMY>, <&clk IMX8MQ_CLK_DUMMY>; > clock-names = "bus", "mclk1", "mclk2", "mclk3"; > - dmas = <&sdma2 0 24 0>, <&sdma2 1 24 0>; > - dma-names = "rx", "tx"; > + dmas = <&sdma2 1 24 0>, <&sdma2 0 24 0>; > + dma-names = "tx", "rx"; > status = "disabled"; > };