From: Rohit Kumar <rohitkr@codeaurora.org>
To: Mark Brown <broonie@kernel.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, bgoswami@codeaurora.org,
lgirdwood@gmail.com, plai@codeaurora.org,
linux-kernel@vger.kernel.org, tiwai@suse.com, robh+dt@kernel.org,
srinivas.kandagatla@linaro.org
Subject: Re: [PATCH v3 3/5] ASoC: qcom: add sdm845 sound card support
Date: Mon, 9 Jul 2018 17:31:04 +0530 [thread overview]
Message-ID: <2110bdcf-96ad-deb5-a5cb-767d7b2e242d@codeaurora.org> (raw)
In-Reply-To: <20180709111437.GB16082@sirena.org.uk>
Thanks Mark for reviewing.
On 7/9/2018 4:44 PM, Mark Brown wrote:
> On Fri, Jul 06, 2018 at 03:13:13PM +0530, Rohit kumar wrote:
>
>> @@ -0,0 +1,390 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Copyright (c) 2018, The Linux Foundation. All rights reserved.
>> + */
> Please make the entire comment block a C++ comment, it makes it look
> more intentional.
Sure, will make this change in next patchset.
>> +static const struct component_master_ops sdm845_ops = {
>> + .bind = sdm845_bind,
>> + .unbind = sdm845_unbind,
>> +};
> Why is this using the component stuff rather than the normal support for
> finding the components of audio cards?
>
QCOM soundcard is dependent on platform and cpu dais which gets
registered only when ADSP is up.
This is the design being followed in
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/sound/soc/qcom/apq8096.c?h=v4.18-rc4#n132
We too have the same dependency.
>
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Thanks,
Rohit
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2018-07-09 12:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 9:43 [PATCH v3 0/5] Add support for audio on SDM845 SoC Rohit kumar
2018-07-06 9:43 ` [PATCH v3 1/5] ASoC: qcom: dt-bindings: Add sdm845 machine bindings Rohit kumar
2018-07-11 15:31 ` Rob Herring
2018-07-06 9:43 ` [PATCH v3 2/5] ASoC: qcom: Add support to parse common audio device nodes Rohit kumar
2018-07-06 17:51 ` Srinivas Kandagatla
2018-07-09 7:43 ` [alsa-devel] " Vinod
2018-07-06 9:43 ` [PATCH v3 3/5] ASoC: qcom: add sdm845 sound card support Rohit kumar
2018-07-09 7:48 ` [alsa-devel] " Vinod
2018-07-09 10:46 ` Rohit Kumar
2018-07-09 14:45 ` Vinod
2018-07-09 9:06 ` Srinivas Kandagatla
2018-07-09 11:14 ` Mark Brown
2018-07-09 12:01 ` Rohit Kumar [this message]
2018-07-09 12:03 ` [alsa-devel] " Mark Brown
2018-07-09 12:34 ` Srinivas Kandagatla
2018-07-09 12:41 ` Mark Brown
2018-07-09 12:47 ` Srinivas Kandagatla
2018-07-09 14:02 ` Srinivas Kandagatla
2018-07-09 16:33 ` Mark Brown
2018-07-10 10:59 ` Srinivas Kandagatla
2018-07-06 9:43 ` [PATCH v3 4/5] ASoC: dt-bindings: Update dt binding name for apq8096 Rohit kumar
2018-07-06 17:51 ` Srinivas Kandagatla
2018-07-11 15:31 ` Rob Herring
2018-07-06 9:43 ` [PATCH v3 5/5] ASoC: qcom: apq8096: Use common APIs to parse device nodes Rohit kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2110bdcf-96ad-deb5-a5cb-767d7b2e242d@codeaurora.org \
--to=rohitkr@codeaurora.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=plai@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).