devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: Lee Jones <lee.jones@linaro.org>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Olof Johansson <olof@lixom.net>,
	Doug Anderson <dianders@chromium.org>,
	Bill Richardson <wfrichar@chromium.org>,
	Simon Glass <sjg@google.com>,
	Gwendal Grignou <gwendal@google.com>,
	Stephen Barber <smbarber@chromium.org>,
	Filipe Brandenburger <filbranden@google.com>,
	Todd Broch <tbroch@chromium.org>,
	Alexandru M Stan <amstan@chromium.org>,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v4 0/8] mfd: cros_ec: Add multi EC and proto v3 support
Date: Tue, 02 Jun 2015 23:15:49 +0200	[thread overview]
Message-ID: <2123062.dmIBPlf795@diego> (raw)
In-Reply-To: <1433232671-27679-1-git-send-email-javier.martinez@collabora.co.uk>

Am Dienstag, 2. Juni 2015, 10:11:03 schrieb Javier Martinez Canillas:
> Hello,
> 
> Newer Chromebooks have more than one Embedded Controller (EC) in the
> system. These additional ECs are connected through I2C with a host EC
> which is the one that is connected to the Application Processor (AP)
> through different transports (I2C, SPI or LPC).
> 
> So on these platforms, sub-processors are chained to each other:
> 
> AP <--> Host EC <--> Power Delivery (PD) EC
> 
> The AP sends commands to the additional EC through the host EC using
> a set of passthru commands and the host redirects to the correct EC.
> 
> This is a v4 of a series that adds support for multiple EC in a system
> and also for the protocol version 3 that is used on newer ECs.
> 
> Most patches were taken from the downstream ChromiumOS v3.14 tree with
> fixes squashed, split to minimise the cross subsystem churn and changes
> for mainline inclusion but were not modified functionality wise.
> 
> This version addresses a lot of issues pointed out by Lee Jones on the v3
> posted before [0].
> 
> The patches are based on top of "[PATCH 0/2] mfd: cros_ec: Small cleanups"
> [1] that were posted before and was already picked by Lee Jones.
> 
> Testing was done on some Chromebooks that have a single EC and support
> protocol v2 such as the Exynos5250 Snow, Exynos5420 Peach Pit and Exynos5800
> Peach Pi to be sure that no regressions were introduced for these machines.

I just gave this a try on veyron and everything still works as expected.

All patches except "[PATCH v4 6/8] mfd: cros_ec: Support multiple EC in a 
system" already have Tested-by tags, so this patch now is also

Tested-by: Heiko Stuebner <heiko@sntech.de>


Heiko

  parent reply	other threads:[~2015-06-02 21:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-02  8:11 [PATCH v4 0/8] mfd: cros_ec: Add multi EC and proto v3 support Javier Martinez Canillas
2015-06-02  8:11 ` [PATCH v4 1/8] mfd: cros_ec: Use a zero-length array for command data Javier Martinez Canillas
2015-06-02  8:11 ` [PATCH v4 2/8] mfd: cros_ec: rev cros_ec_commands.h Javier Martinez Canillas
2015-06-02  8:11 ` [PATCH v4 3/8] mfd: cros_ec: Move protocol helpers out of the MFD driver Javier Martinez Canillas
2015-06-02  8:11 ` [PATCH v4 4/8] mfd: cros_ec: add proto v3 skeleton Javier Martinez Canillas
     [not found] ` <1433232671-27679-1-git-send-email-javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2015-06-02  8:11   ` [PATCH v4 5/8] mfd: cros_ec: add bus-specific proto v3 code Javier Martinez Canillas
2015-06-02  8:11   ` [PATCH v4 6/8] mfd: cros_ec: Support multiple EC in a system Javier Martinez Canillas
2015-06-03  8:53     ` Lee Jones
2015-06-03 10:12       ` Javier Martinez Canillas
2015-06-03 11:27         ` Lee Jones
2015-06-03 11:49           ` Javier Martinez Canillas
2015-06-02  8:11   ` [PATCH v4 7/8] mfd: cros_ec: spi: Add a DT property to delay asserting the CS Javier Martinez Canillas
2015-06-02  8:11 ` [PATCH v4 8/8] mfd: cros_ec: spi: Add delay for asserting CS Javier Martinez Canillas
2015-06-02 21:15 ` Heiko Stübner [this message]
2015-06-03  6:45   ` [PATCH v4 0/8] mfd: cros_ec: Add multi EC and proto v3 support Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2123062.dmIBPlf795@diego \
    --to=heiko@sntech.de \
    --cc=amstan@chromium.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=filbranden@google.com \
    --cc=gwendal@google.com \
    --cc=javier.martinez@collabora.co.uk \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=sameo@linux.intel.com \
    --cc=sjg@google.com \
    --cc=smbarber@chromium.org \
    --cc=tbroch@chromium.org \
    --cc=wfrichar@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).