* [PATCH v2] arm64: dts: renesas: r8a77990: Fix VIN endpoint numbering
@ 2018-11-05 13:12 Jacopo Mondi
2018-11-06 14:00 ` Simon Horman
0 siblings, 1 reply; 4+ messages in thread
From: Jacopo Mondi @ 2018-11-05 13:12 UTC (permalink / raw)
To: horms, geert, laurent.pinchart
Cc: Jacopo Mondi, linux-renesas-soc, devicetree, Koji Matsuoka,
Takeshi Kihara
The VIN driver bindings dictates fixed numbering for VIN endpoints connected
to CSI-2 endpoints, even when a single endpoint exists.
Without proper endpoint numbering the VIN driver fails to probe.
Based on a patch in BSP from Koji Matsuoka <koji.matsuoka.xm@renesas.com>
Fixes: ec70407ae7d7 ("arm64: dts: renesas: r8a77990: Add VIN and CSI-2 device nodes")
Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm64/boot/dts/renesas/r8a77990.dtsi | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
index 9509dc0..106a574 100644
--- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
@@ -745,9 +745,13 @@
#size-cells = <0>;
port@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
reg = <1>;
- vin4csi40: endpoint {
+ vin4csi40: endpoint@2 {
+ reg = <2>;
remote-endpoint= <&csi40vin4>;
};
};
@@ -769,9 +773,13 @@
#size-cells = <0>;
port@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
reg = <1>;
- vin5csi40: endpoint {
+ vin5csi40: endpoint@2 {
+ reg = <2>;
remote-endpoint= <&csi40vin5>;
};
};
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] arm64: dts: renesas: r8a77990: Fix VIN endpoint numbering
2018-11-05 13:12 [PATCH v2] arm64: dts: renesas: r8a77990: Fix VIN endpoint numbering Jacopo Mondi
@ 2018-11-06 14:00 ` Simon Horman
2018-11-07 16:30 ` Laurent Pinchart
0 siblings, 1 reply; 4+ messages in thread
From: Simon Horman @ 2018-11-06 14:00 UTC (permalink / raw)
To: Jacopo Mondi
Cc: geert, laurent.pinchart, linux-renesas-soc, devicetree,
Koji Matsuoka, Takeshi Kihara
On Mon, Nov 05, 2018 at 02:12:43PM +0100, Jacopo Mondi wrote:
> The VIN driver bindings dictates fixed numbering for VIN endpoints connected
> to CSI-2 endpoints, even when a single endpoint exists.
>
> Without proper endpoint numbering the VIN driver fails to probe.
>
> Based on a patch in BSP from Koji Matsuoka <koji.matsuoka.xm@renesas.com>
>
> Fixes: ec70407ae7d7 ("arm64: dts: renesas: r8a77990: Add VIN and CSI-2 device nodes")
> Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Thanks,
This looks fine to me but I will wait to see if there are other reviews
before applying.
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] arm64: dts: renesas: r8a77990: Fix VIN endpoint numbering
2018-11-06 14:00 ` Simon Horman
@ 2018-11-07 16:30 ` Laurent Pinchart
2018-11-08 10:42 ` Simon Horman
0 siblings, 1 reply; 4+ messages in thread
From: Laurent Pinchart @ 2018-11-07 16:30 UTC (permalink / raw)
To: Simon Horman
Cc: Jacopo Mondi, geert, linux-renesas-soc, devicetree, Koji Matsuoka,
Takeshi Kihara
Hi Simon,
On Tuesday, 6 November 2018 16:00:35 EET Simon Horman wrote:
> On Mon, Nov 05, 2018 at 02:12:43PM +0100, Jacopo Mondi wrote:
> > The VIN driver bindings dictates fixed numbering for VIN endpoints
> > connected to CSI-2 endpoints, even when a single endpoint exists.
> >
> > Without proper endpoint numbering the VIN driver fails to probe.
> >
> > Based on a patch in BSP from Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> >
> > Fixes: ec70407ae7d7 ("arm64: dts: renesas: r8a77990: Add VIN and CSI-2
> > device nodes") Signed-off-by: Koji Matsuoka
> > <koji.matsuoka.xm@renesas.com>
> > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Thanks,
>
> This looks fine to me but I will wait to see if there are other reviews
> before applying.
>
> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
I think you can go ahead and apply it.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] arm64: dts: renesas: r8a77990: Fix VIN endpoint numbering
2018-11-07 16:30 ` Laurent Pinchart
@ 2018-11-08 10:42 ` Simon Horman
0 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2018-11-08 10:42 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Jacopo Mondi, geert, linux-renesas-soc, devicetree, Koji Matsuoka,
Takeshi Kihara
On Wed, Nov 07, 2018 at 06:30:13PM +0200, Laurent Pinchart wrote:
> Hi Simon,
>
> On Tuesday, 6 November 2018 16:00:35 EET Simon Horman wrote:
> > On Mon, Nov 05, 2018 at 02:12:43PM +0100, Jacopo Mondi wrote:
> > > The VIN driver bindings dictates fixed numbering for VIN endpoints
> > > connected to CSI-2 endpoints, even when a single endpoint exists.
> > >
> > > Without proper endpoint numbering the VIN driver fails to probe.
> > >
> > > Based on a patch in BSP from Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> > >
> > > Fixes: ec70407ae7d7 ("arm64: dts: renesas: r8a77990: Add VIN and CSI-2
> > > device nodes") Signed-off-by: Koji Matsuoka
> > > <koji.matsuoka.xm@renesas.com>
> > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > Thanks,
> >
> > This looks fine to me but I will wait to see if there are other reviews
> > before applying.
> >
> > Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
>
> I think you can go ahead and apply it.
Thanks, applied for v4.21.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-08 20:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-05 13:12 [PATCH v2] arm64: dts: renesas: r8a77990: Fix VIN endpoint numbering Jacopo Mondi
2018-11-06 14:00 ` Simon Horman
2018-11-07 16:30 ` Laurent Pinchart
2018-11-08 10:42 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).