From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, mchehab@kernel.org,
hverkuil@xs4all.nl, sakari.ailus@linux.intel.com, crope@iki.fi,
chris.paterson2@renesas.com, geert+renesas@glider.be,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v3 5/7] doc_rst: media: New SDR formats PC16, PC18 & PC20
Date: Tue, 11 Apr 2017 15:39:40 +0300 [thread overview]
Message-ID: <213133284.36Jzg1zrIM@avalon> (raw)
In-Reply-To: <1486479757-32128-6-git-send-email-ramesh.shanmugasundaram@bp.renesas.com>
Hi Ramesh,
Thank you for the patch.
On Tuesday 07 Feb 2017 15:02:35 Ramesh Shanmugasundaram wrote:
> This patch adds documentation for the three new SDR formats
>
> V4L2_SDR_FMT_PCU16BE
> V4L2_SDR_FMT_PCU18BE
> V4L2_SDR_FMT_PCU20BE
>
> Signed-off-by: Ramesh Shanmugasundaram
> <ramesh.shanmugasundaram@bp.renesas.com> ---
> .../media/uapi/v4l/pixfmt-sdr-pcu16be.rst | 55 +++++++++++++++++++
> .../media/uapi/v4l/pixfmt-sdr-pcu18be.rst | 55 +++++++++++++++++++
> .../media/uapi/v4l/pixfmt-sdr-pcu20be.rst | 54 +++++++++++++++++++
> Documentation/media/uapi/v4l/sdr-formats.rst | 3 ++
> 4 files changed, 167 insertions(+)
> create mode 100644 Documentation/media/uapi/v4l/pixfmt-sdr-pcu16be.rst
> create mode 100644 Documentation/media/uapi/v4l/pixfmt-sdr-pcu18be.rst
> create mode 100644 Documentation/media/uapi/v4l/pixfmt-sdr-pcu20be.rst
>
> diff --git a/Documentation/media/uapi/v4l/pixfmt-sdr-pcu16be.rst
> b/Documentation/media/uapi/v4l/pixfmt-sdr-pcu16be.rst new file mode 100644
> index 0000000..2de1b1a
> --- /dev/null
> +++ b/Documentation/media/uapi/v4l/pixfmt-sdr-pcu16be.rst
> @@ -0,0 +1,55 @@
> +.. -*- coding: utf-8; mode: rst -*-
> +
> +.. _V4L2-SDR-FMT-PCU16BE:
> +
> +******************************
> +V4L2_SDR_FMT_PCU16BE ('PC16')
> +******************************
> +
> +Planar complex unsigned 16-bit big endian IQ sample
> +
> +Description
> +===========
> +
> +This format contains a sequence of complex number samples. Each complex
> +number consist of two parts called In-phase and Quadrature (IQ). Both I
> +and Q are represented as a 16 bit unsigned big endian number stored in
> +32 bit space. The remaining unused bits within the 32 bit space will be
> +padded with 0. I value starts first and Q value starts at an offset
> +equalling half of the buffer size (i.e.) offset = buffersize/2. Out of
> +the 16 bits, bit 15:2 (14 bit) is data and bit 1:0 (2 bit) can be any
> +value.
This sounds very strange to me. Are the two lower bits always random ? What is
that used for ?
> +**Byte Order.**
> +Each cell is one byte.
> +
> +.. flat-table::
> + :header-rows: 1
> + :stub-columns: 0
> +
> + * - Offset:
> + - Byte B0
> + - Byte B1
> + - Byte B2
> + - Byte B3
> + * - start + 0:
> + - I'\ :sub:`0[13:6]`
> + - I'\ :sub:`0[5:0]; B1[1:0]=pad`
> + - pad
> + - pad
> + * - start + 4:
> + - I'\ :sub:`1[13:6]`
> + - I'\ :sub:`1[5:0]; B1[1:0]=pad`
> + - pad
> + - pad
> + * - ...
> + * - start + offset:
> + - Q'\ :sub:`0[13:6]`
> + - Q'\ :sub:`0[5:0]; B1[1:0]=pad`
> + - pad
> + - pad
> + * - start + offset + 4:
> + - Q'\ :sub:`1[13:6]`
> + - Q'\ :sub:`1[5:0]; B1[1:0]=pad`
> + - pad
> + - pad
> diff --git a/Documentation/media/uapi/v4l/pixfmt-sdr-pcu18be.rst
> b/Documentation/media/uapi/v4l/pixfmt-sdr-pcu18be.rst new file mode 100644
> index 0000000..da8b26b
> --- /dev/null
> +++ b/Documentation/media/uapi/v4l/pixfmt-sdr-pcu18be.rst
> @@ -0,0 +1,55 @@
> +.. -*- coding: utf-8; mode: rst -*-
> +
> +.. _V4L2-SDR-FMT-PCU18BE:
> +
> +******************************
> +V4L2_SDR_FMT_PCU18BE ('PC18')
> +******************************
> +
> +Planar complex unsigned 18-bit big endian IQ sample
> +
> +Description
> +===========
> +
> +This format contains a sequence of complex number samples. Each complex
> +number consist of two parts called In-phase and Quadrature (IQ). Both I
> +and Q are represented as a 18 bit unsigned big endian number stored in
> +32 bit space. The remaining unused bits within the 32 bit space will be
> +padded with 0. I value starts first and Q value starts at an offset
> +equalling half of the buffer size (i.e.) offset = buffersize/2. Out of
> +the 18 bits, bit 17:2 (16 bit) is data and bit 1:0 (2 bit) can be any
> +value.
> +
> +**Byte Order.**
> +Each cell is one byte.
> +
> +.. flat-table::
> + :header-rows: 1
> + :stub-columns: 0
> +
> + * - Offset:
> + - Byte B0
> + - Byte B1
> + - Byte B2
> + - Byte B3
> + * - start + 0:
> + - I'\ :sub:`0[17:10]`
> + - I'\ :sub:`0[9:2]`
> + - I'\ :sub:`0[1:0]; B2[5:0]=pad`
> + - pad
> + * - start + 4:
> + - I'\ :sub:`1[17:10]`
> + - I'\ :sub:`1[9:2]`
> + - I'\ :sub:`1[1:0]; B2[5:0]=pad`
> + - pad
> + * - ...
> + * - start + offset:
> + - Q'\ :sub:`0[17:10]`
> + - Q'\ :sub:`0[9:2]`
> + - Q'\ :sub:`0[1:0]; B2[5:0]=pad`
> + - pad
> + * - start + offset + 4:
> + - Q'\ :sub:`1[17:10]`
> + - Q'\ :sub:`1[9:2]`
> + - Q'\ :sub:`1[1:0]; B2[5:0]=pad`
> + - pad
> diff --git a/Documentation/media/uapi/v4l/pixfmt-sdr-pcu20be.rst
> b/Documentation/media/uapi/v4l/pixfmt-sdr-pcu20be.rst new file mode 100644
> index 0000000..5499eed
> --- /dev/null
> +++ b/Documentation/media/uapi/v4l/pixfmt-sdr-pcu20be.rst
> @@ -0,0 +1,54 @@
> +.. -*- coding: utf-8; mode: rst -*-
> +.. _V4L2-SDR-FMT-PCU20BE:
> +
> +******************************
> +V4L2_SDR_FMT_PCU20BE ('PC20')
> +******************************
> +
> +Planar complex unsigned 20-bit big endian IQ sample
> +
> +Description
> +===========
> +
> +This format contains a sequence of complex number samples. Each complex
> +number consist of two parts called In-phase and Quadrature (IQ). Both I
> +and Q are represented as a 20 bit unsigned big endian number stored in
> +32 bit space. The remaining unused bits within the 32 bit space will be
> +padded with 0. I value starts first and Q value starts at an offset
> +equalling half of the buffer size (i.e.) offset = buffersize/2. Out of
> +the 20 bits, bit 19:2 (18 bit) is data and bit 1:0 (2 bit) can be any
> +value.
> +
> +**Byte Order.**
> +Each cell is one byte.
> +
> +.. flat-table::
> + :header-rows: 1
> + :stub-columns: 0
> +
> + * - Offset:
> + - Byte B0
> + - Byte B1
> + - Byte B2
> + - Byte B3
> + * - start + 0:
> + - I'\ :sub:`0[19:12]`
> + - I'\ :sub:`0[11:4]`
> + - I'\ :sub:`0[3:0]; B2[3:0]=pad`
> + - pad
> + * - start + 4:
> + - I'\ :sub:`1[19:12]`
> + - I'\ :sub:`1[11:4]`
> + - I'\ :sub:`1[3:0]; B2[3:0]=pad`
> + - pad
> + * - ...
> + * - start + offset:
> + - Q'\ :sub:`0[19:12]`
> + - Q'\ :sub:`0[11:4]`
> + - Q'\ :sub:`0[3:0]; B2[3:0]=pad`
> + - pad
> + * - start + offset + 4:
> + - Q'\ :sub:`1[19:12]`
> + - Q'\ :sub:`1[11:4]`
> + - Q'\ :sub:`1[3:0]; B2[3:0]=pad`
> + - pad
> diff --git a/Documentation/media/uapi/v4l/sdr-formats.rst
> b/Documentation/media/uapi/v4l/sdr-formats.rst index f863c08..2037f5b
> 100644
> --- a/Documentation/media/uapi/v4l/sdr-formats.rst
> +++ b/Documentation/media/uapi/v4l/sdr-formats.rst
> @@ -17,3 +17,6 @@ These formats are used for :ref:`SDR <sdr>` interface
> only. pixfmt-sdr-cs08
> pixfmt-sdr-cs14le
> pixfmt-sdr-ru12le
> + pixfmt-sdr-pcu16be
> + pixfmt-sdr-pcu18be
> + pixfmt-sdr-pcu20be
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2017-04-11 12:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 15:02 [PATCH v3 0/7] Add V4L2 SDR (DRIF & MAX2175) driver Ramesh Shanmugasundaram
[not found] ` <1486479757-32128-1-git-send-email-ramesh.shanmugasundaram-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2017-02-07 15:02 ` [PATCH v3 1/7] media: v4l2-ctrls: Reserve controls for MAX217X Ramesh Shanmugasundaram
2017-04-11 8:28 ` Laurent Pinchart
2017-02-07 15:02 ` [PATCH v3 2/7] dt-bindings: media: Add MAX2175 binding description Ramesh Shanmugasundaram
2017-02-15 16:59 ` Rob Herring
2017-04-11 9:42 ` Laurent Pinchart
2017-04-11 9:57 ` Ramesh Shanmugasundaram
[not found] ` <HK2PR06MB0545282102FBC0472D9831AEC3000-jAC1QCBx2F1Af0bSEaWBKm0DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-04-11 11:27 ` Laurent Pinchart
2017-04-11 12:19 ` Ramesh Shanmugasundaram
[not found] ` <HK2PR06MB0545F9FBB1B27E91D80F906EC3000-jAC1QCBx2F1Af0bSEaWBKm0DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-04-11 12:58 ` Laurent Pinchart
2017-02-07 15:02 ` [PATCH v3 3/7] media: i2c: max2175: Add MAX2175 support Ramesh Shanmugasundaram
2017-02-13 12:40 ` Hans Verkuil
2017-02-07 15:02 ` [PATCH v3 4/7] media: Add new SDR formats PC16, PC18 & PC20 Ramesh Shanmugasundaram
2017-02-07 15:02 ` [PATCH v3 5/7] doc_rst: media: New " Ramesh Shanmugasundaram
2017-04-11 12:39 ` Laurent Pinchart [this message]
2017-04-18 17:13 ` Ramesh Shanmugasundaram
2017-02-07 15:02 ` [PATCH v3 6/7] dt-bindings: media: Add Renesas R-Car DRIF binding Ramesh Shanmugasundaram
[not found] ` <1486479757-32128-7-git-send-email-ramesh.shanmugasundaram-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2017-02-15 17:09 ` Rob Herring
2017-02-16 11:02 ` Ramesh Shanmugasundaram
2017-04-11 22:41 ` Laurent Pinchart
2017-04-11 22:35 ` Laurent Pinchart
2017-02-07 15:02 ` [PATCH v3 7/7] media: platform: rcar_drif: Add DRIF support Ramesh Shanmugasundaram
[not found] ` <1486479757-32128-8-git-send-email-ramesh.shanmugasundaram-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2017-04-11 22:24 ` Laurent Pinchart
2017-04-18 17:12 ` Ramesh Shanmugasundaram
2017-02-13 12:46 ` [PATCH v3 0/7] Add V4L2 SDR (DRIF & MAX2175) driver Hans Verkuil
2017-02-14 13:42 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=213133284.36Jzg1zrIM@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=chris.paterson2@renesas.com \
--cc=crope@iki.fi \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=ramesh.shanmugasundaram@bp.renesas.com \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox