From: "Heiko Stübner" <heiko@sntech.de>
To: "Ulf Hansson" <ulf.hansson@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Chen-Yu Tsai" <wens@csie.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Kevin Hilman" <khilman@baylibre.com>,
"Jerome Brunet" <jbrunet@baylibre.com>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Lars Povlsen" <lars.povlsen@microchip.com>,
"Steen Hegelund" <Steen.Hegelund@microchip.com>,
"Daniel Machon" <daniel.machon@microchip.com>,
UNGLinuxDriver@microchip.com,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Andreas Färber" <afaerber@suse.de>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Tony Huang" <tonyhuang.sunplus@gmail.com>,
"Li-hao Kuo" <lhjeff911@gmail.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"Masahiro Yamada" <yamada.masahiro@socionext.com>,
"Markus Pargmann" <mpa@pengutronix.de>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
"Jaehoon Chung" <jh80.chung@samsung.com>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-amlogic@lists.infradead.org, linux-tegra@vger.kernel.org,
linux-actions@lists.infradead.org,
linux-rockchip@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH 2/2] dt-bindings: mmc: correct pwrseq node names
Date: Fri, 20 Jan 2023 10:38:43 +0100 [thread overview]
Message-ID: <2138388.Mh6RI2rZIc@diego> (raw)
In-Reply-To: <20230120085722.171965-2-krzysztof.kozlowski@linaro.org>
Am Freitag, 20. Januar 2023, 09:57:22 CET schrieb Krzysztof Kozlowski:
> Node names should be generic and should not contain underscores.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml | 2 +-
> Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml | 2 +-
> Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml
> index 911a5996e099..588be73168fa 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml
> @@ -41,7 +41,7 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/gpio/gpio.h>
> - sdhci0_pwrseq {
> + pwrseq {
[applicable for all 3 examples]
hmm, power-sequences are not necessarily tied to an address and I guess
it will be very much a common case to have multiple ones on a system.
So might it be better to follow other patterns (like leds) to number them
or suggest a "foo-pwrseq" / "pwrseq-foo"?
Heiko
> compatible = "mmc-pwrseq-emmc";
> reset-gpios = <&gpio1 12 GPIO_ACTIVE_LOW>;
> };
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml
> index 3397dbff88c2..b35e00e8c65e 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml
> @@ -35,7 +35,7 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/gpio/gpio.h>
> - wifi_pwrseq: wifi_pwrseq {
> + pwrseq {
> compatible = "mmc-pwrseq-sd8787";
> powerdown-gpios = <&twl_gpio 0 GPIO_ACTIVE_LOW>;
> reset-gpios = <&twl_gpio 1 GPIO_ACTIVE_LOW>;
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml
> index 64e3644eefeb..00feaafc1063 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml
> @@ -55,7 +55,7 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/gpio/gpio.h>
> - sdhci0_pwrseq {
> + pwrseq {
> compatible = "mmc-pwrseq-simple";
> reset-gpios = <&gpio1 12 GPIO_ACTIVE_LOW>;
> clocks = <&clk_32768_ck>;
>
next prev parent reply other threads:[~2023-01-20 9:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 8:57 [PATCH 1/2] dt-bindings: mmc: drop unneeded quotes Krzysztof Kozlowski
2023-01-20 8:57 ` [PATCH 2/2] dt-bindings: mmc: correct pwrseq node names Krzysztof Kozlowski
2023-01-20 9:38 ` Heiko Stübner [this message]
2023-01-24 8:17 ` Krzysztof Kozlowski
2023-01-24 11:41 ` Heiko Stübner
2023-01-23 22:04 ` Rob Herring
2023-01-24 12:57 ` Ulf Hansson
2023-01-20 9:12 ` [PATCH 1/2] dt-bindings: mmc: drop unneeded quotes Wolfram Sang
2023-01-20 9:30 ` Heiko Stübner
2023-01-20 9:31 ` Neil Armstrong
2023-01-23 22:04 ` Rob Herring
2023-01-24 12:57 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2138388.Mh6RI2rZIc@diego \
--to=heiko@sntech.de \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=adrian.hunter@intel.com \
--cc=afaerber@suse.de \
--cc=alim.akhtar@samsung.com \
--cc=daniel.machon@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=jernej.skrabec@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=jonathanh@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars.povlsen@microchip.com \
--cc=lhjeff911@gmail.com \
--cc=linux-actions@lists.infradead.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mpa@pengutronix.de \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=samuel@sholland.org \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tonyhuang.sunplus@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=wens@csie.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).