From: Jon Hunter <jonathanh@nvidia.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, Wayne Chang <waynec@nvidia.com>
Subject: Re: [PATCH V8 1/6] dt-bindings: usb: Add Cypress cypd4226 Type-C controller
Date: Thu, 26 Jan 2023 15:05:23 +0000 [thread overview]
Message-ID: <213afca0-43e8-4027-3da5-3f35f130148b@nvidia.com> (raw)
In-Reply-To: <db7646a3-330f-b9cb-161a-ddf31dc679d5@linaro.org>
On 26/01/2023 11:36, Krzysztof Kozlowski wrote:
> On 25/01/2023 21:42, Jon Hunter wrote:
>> From: Wayne Chang <waynec@nvidia.com>
>>
>> Add the device-tree binding documentation for Cypress cypd4226 dual
>> Type-C controller.
>>
>> Signed-off-by: Wayne Chang <waynec@nvidia.com>
>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>
>> +
>> + firmware-name:
>> + enum:
>> + - nvidia,gpu
>> + - nvidia,jetson-agx-xavier
>> + description: |
>> + The name of the CCGx firmware built for product series.
>> + should be set one of following:
>> + - "nvidia,gpu" for the NVIDIA RTX product series
>> + - "nvidia,jetson-agx-xavier" for the NVIDIA Jetson product series
>> +
>> +patternProperties:
>> + '^connector@[0-1]+$':
>> + $ref: /schemas/connector/usb-connector.yaml#
>
> No improvements here
>
> This is a friendly reminder during the review process.
>
> It seems my previous comments were not fully addressed. Maybe my
> feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all
> requested changes or keep discussing them.
>
> Thank you.
Hmmm ... I think I misinterpreted what you were asking/suggesting. OK,
let me fix this up.
Jon
--
nvpublic
next prev parent reply other threads:[~2023-01-26 15:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 20:42 [PATCH V8 0/6] Add device-tree support for Cypress CYPD4226 Jon Hunter
2023-01-25 20:42 ` [PATCH V8 1/6] dt-bindings: usb: Add Cypress cypd4226 Type-C controller Jon Hunter
2023-01-26 11:36 ` Krzysztof Kozlowski
2023-01-26 15:05 ` Jon Hunter [this message]
2023-01-27 14:59 ` Jon Hunter
2023-01-25 20:42 ` [PATCH V8 2/6] i2c: nvidia-gpu: Add ACPI property to align with device-tree Jon Hunter
2023-01-25 20:42 ` [PATCH V8 3/6] usb: typec: ucsi_ccg: Add OF support Jon Hunter
2023-01-25 20:42 ` [PATCH V8 4/6] i2c: nvidia-gpu: Remove ccgx,firmware-build property Jon Hunter
2023-01-25 20:42 ` [PATCH V8 5/6] arm64: tegra: Populate USB Type-C Controller for Jetson AGX Orin Jon Hunter
2023-01-25 20:42 ` [PATCH V8 6/6] arm64: defconfig: Enable UCSI support Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=213afca0-43e8-4027-3da5-3f35f130148b@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=waynec@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).