From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: "Leonard Göhrs" <l.goehrs@pengutronix.de>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@pengutronix.de, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: dts: stm32: correct vcc-supply for eeprom on stm32mp15xx-osd32
Date: Fri, 3 Jun 2022 13:34:22 +0200 [thread overview]
Message-ID: <213e966d-ac69-b5be-52ad-4ab9f616565e@pengutronix.de> (raw)
In-Reply-To: <20220603094422.2112746-2-l.goehrs@pengutronix.de>
On 03.06.22 11:44, Leonard Göhrs wrote:
> According to the OSD32MP1 Power System overview[1] the EEPROM is connected to
> the VDD line and not to some single-purpose fixed regulator.
> Set the EEPROM supply according to the diagram to eliminate this parent-less
> regulator.
>
> [1]: https://octavosystems.com/app_notes/osd32mp1-power-system-overview/#connections
>
> Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
Acked-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Thanks,
Ahmad
> ---
> arch/arm/boot/dts/stm32mp15xx-osd32.dtsi | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> index e997c4953fd1..935b7084b5a2 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> @@ -50,12 +50,6 @@ retram: retram@38000000 {
> no-map;
> };
> };
> -
> - reg_sip_eeprom: regulator_eeprom {
> - compatible = "regulator-fixed";
> - regulator-name = "sip_eeprom";
> - regulator-always-on;
> - };
> };
>
> &i2c4 {
> @@ -204,7 +198,7 @@ pmic_watchdog: watchdog {
>
> sip_eeprom: eeprom@50 {
> compatible = "atmel,24c32";
> - vcc-supply = <®_sip_eeprom>;
> + vcc-supply = <&vdd>;
> reg = <0x50>;
> };
> };
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2022-06-03 11:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 9:44 [PATCH 1/2] ARM: dts: stm32: fix missing internally connected voltage regulator for OSD32MP1 Leonard Göhrs
2022-06-03 9:44 ` [PATCH 2/2] ARM: dts: stm32: correct vcc-supply for eeprom on stm32mp15xx-osd32 Leonard Göhrs
2022-06-03 11:34 ` Ahmad Fatoum [this message]
2022-06-13 8:15 ` Alexandre TORGUE
2022-06-03 11:32 ` [PATCH 1/2] ARM: dts: stm32: fix missing internally connected voltage regulator for OSD32MP1 Ahmad Fatoum
2022-06-13 8:14 ` Alexandre TORGUE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=213e966d-ac69-b5be-52ad-4ab9f616565e@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=alexandre.torgue@foss.st.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.goehrs@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).