devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: stm32: fix missing internally connected voltage regulator for OSD32MP1
@ 2022-06-03  9:44 Leonard Göhrs
  2022-06-03  9:44 ` [PATCH 2/2] ARM: dts: stm32: correct vcc-supply for eeprom on stm32mp15xx-osd32 Leonard Göhrs
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Leonard Göhrs @ 2022-06-03  9:44 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Maxime Coquelin,
	Alexandre Torgue
  Cc: kernel, Leonard Göhrs, devicetree, linux-stm32,
	linux-arm-kernel, linux-kernel

According to the OSD32MP1 Power System overview[1] ldo3's input is always
internally connected to vdd_ddr.

[1]: https://octavosystems.com/app_notes/osd32mp1-power-system-overview/#connections

Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
---
 arch/arm/boot/dts/stm32mp15xx-osd32.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
index 6706d8311a66..e997c4953fd1 100644
--- a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
+++ b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
@@ -78,6 +78,7 @@ regulators {
 			compatible = "st,stpmic1-regulators";
 
 			ldo1-supply = <&v3v3>;
+			ldo3-supply = <&vdd_ddr>;
 			ldo6-supply = <&v3v3>;
 			pwr_sw1-supply = <&bst_out>;
 
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH 2/2] ARM: dts: stm32: correct vcc-supply for eeprom on stm32mp15xx-osd32
  2022-06-03  9:44 [PATCH 1/2] ARM: dts: stm32: fix missing internally connected voltage regulator for OSD32MP1 Leonard Göhrs
@ 2022-06-03  9:44 ` Leonard Göhrs
  2022-06-03 11:34   ` Ahmad Fatoum
  2022-06-13  8:15   ` Alexandre TORGUE
  2022-06-03 11:32 ` [PATCH 1/2] ARM: dts: stm32: fix missing internally connected voltage regulator for OSD32MP1 Ahmad Fatoum
  2022-06-13  8:14 ` Alexandre TORGUE
  2 siblings, 2 replies; 6+ messages in thread
From: Leonard Göhrs @ 2022-06-03  9:44 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Maxime Coquelin,
	Alexandre Torgue
  Cc: kernel, Leonard Göhrs, devicetree, linux-stm32,
	linux-arm-kernel, linux-kernel

According to the OSD32MP1 Power System overview[1] the EEPROM is connected to
the VDD line and not to some single-purpose fixed regulator.
Set the EEPROM supply according to the diagram to eliminate this parent-less
regulator.

[1]: https://octavosystems.com/app_notes/osd32mp1-power-system-overview/#connections

Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
---
 arch/arm/boot/dts/stm32mp15xx-osd32.dtsi | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
index e997c4953fd1..935b7084b5a2 100644
--- a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
+++ b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
@@ -50,12 +50,6 @@ retram: retram@38000000 {
 			no-map;
 		};
 	};
-
-	reg_sip_eeprom: regulator_eeprom {
-		compatible = "regulator-fixed";
-		regulator-name = "sip_eeprom";
-		regulator-always-on;
-	};
 };
 
 &i2c4 {
@@ -204,7 +198,7 @@ pmic_watchdog: watchdog {
 
 	sip_eeprom: eeprom@50 {
 		compatible = "atmel,24c32";
-		vcc-supply = <&reg_sip_eeprom>;
+		vcc-supply = <&vdd>;
 		reg = <0x50>;
 	};
 };
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] ARM: dts: stm32: fix missing internally connected voltage regulator for OSD32MP1
  2022-06-03  9:44 [PATCH 1/2] ARM: dts: stm32: fix missing internally connected voltage regulator for OSD32MP1 Leonard Göhrs
  2022-06-03  9:44 ` [PATCH 2/2] ARM: dts: stm32: correct vcc-supply for eeprom on stm32mp15xx-osd32 Leonard Göhrs
@ 2022-06-03 11:32 ` Ahmad Fatoum
  2022-06-13  8:14 ` Alexandre TORGUE
  2 siblings, 0 replies; 6+ messages in thread
From: Ahmad Fatoum @ 2022-06-03 11:32 UTC (permalink / raw)
  To: Leonard Göhrs, Rob Herring, Krzysztof Kozlowski,
	Maxime Coquelin, Alexandre Torgue
  Cc: devicetree, linux-kernel, kernel, linux-stm32, linux-arm-kernel

On 03.06.22 11:44, Leonard Göhrs wrote:
> According to the OSD32MP1 Power System overview[1] ldo3's input is always
> internally connected to vdd_ddr.
> 
> [1]: https://octavosystems.com/app_notes/osd32mp1-power-system-overview/#connections
> 
> Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Thanks,
Ahmad

> ---
>  arch/arm/boot/dts/stm32mp15xx-osd32.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> index 6706d8311a66..e997c4953fd1 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> @@ -78,6 +78,7 @@ regulators {
>  			compatible = "st,stpmic1-regulators";
>  
>  			ldo1-supply = <&v3v3>;
> +			ldo3-supply = <&vdd_ddr>;
>  			ldo6-supply = <&v3v3>;
>  			pwr_sw1-supply = <&bst_out>;
>  


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] ARM: dts: stm32: correct vcc-supply for eeprom on stm32mp15xx-osd32
  2022-06-03  9:44 ` [PATCH 2/2] ARM: dts: stm32: correct vcc-supply for eeprom on stm32mp15xx-osd32 Leonard Göhrs
@ 2022-06-03 11:34   ` Ahmad Fatoum
  2022-06-13  8:15   ` Alexandre TORGUE
  1 sibling, 0 replies; 6+ messages in thread
From: Ahmad Fatoum @ 2022-06-03 11:34 UTC (permalink / raw)
  To: Leonard Göhrs, Rob Herring, Krzysztof Kozlowski,
	Maxime Coquelin, Alexandre Torgue
  Cc: devicetree, linux-kernel, kernel, linux-stm32, linux-arm-kernel

On 03.06.22 11:44, Leonard Göhrs wrote:
> According to the OSD32MP1 Power System overview[1] the EEPROM is connected to
> the VDD line and not to some single-purpose fixed regulator.
> Set the EEPROM supply according to the diagram to eliminate this parent-less
> regulator.
> 
> [1]: https://octavosystems.com/app_notes/osd32mp1-power-system-overview/#connections
> 
> Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>

Acked-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Thanks,
Ahmad

> ---
>  arch/arm/boot/dts/stm32mp15xx-osd32.dtsi | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> index e997c4953fd1..935b7084b5a2 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> @@ -50,12 +50,6 @@ retram: retram@38000000 {
>  			no-map;
>  		};
>  	};
> -
> -	reg_sip_eeprom: regulator_eeprom {
> -		compatible = "regulator-fixed";
> -		regulator-name = "sip_eeprom";
> -		regulator-always-on;
> -	};
>  };
>  
>  &i2c4 {
> @@ -204,7 +198,7 @@ pmic_watchdog: watchdog {
>  
>  	sip_eeprom: eeprom@50 {
>  		compatible = "atmel,24c32";
> -		vcc-supply = <&reg_sip_eeprom>;
> +		vcc-supply = <&vdd>;
>  		reg = <0x50>;
>  	};
>  };


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] ARM: dts: stm32: fix missing internally connected voltage regulator for OSD32MP1
  2022-06-03  9:44 [PATCH 1/2] ARM: dts: stm32: fix missing internally connected voltage regulator for OSD32MP1 Leonard Göhrs
  2022-06-03  9:44 ` [PATCH 2/2] ARM: dts: stm32: correct vcc-supply for eeprom on stm32mp15xx-osd32 Leonard Göhrs
  2022-06-03 11:32 ` [PATCH 1/2] ARM: dts: stm32: fix missing internally connected voltage regulator for OSD32MP1 Ahmad Fatoum
@ 2022-06-13  8:14 ` Alexandre TORGUE
  2 siblings, 0 replies; 6+ messages in thread
From: Alexandre TORGUE @ 2022-06-13  8:14 UTC (permalink / raw)
  To: Leonard Göhrs, Rob Herring, Krzysztof Kozlowski,
	Maxime Coquelin
  Cc: kernel, devicetree, linux-stm32, linux-arm-kernel, linux-kernel

Hi Leonard

On 6/3/22 11:44, Leonard Göhrs wrote:
> According to the OSD32MP1 Power System overview[1] ldo3's input is always
> internally connected to vdd_ddr.
> 
> [1]: https://octavosystems.com/app_notes/osd32mp1-power-system-overview/#connections
> 
> Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
> ---
>   arch/arm/boot/dts/stm32mp15xx-osd32.dtsi | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> index 6706d8311a66..e997c4953fd1 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> @@ -78,6 +78,7 @@ regulators {
>   			compatible = "st,stpmic1-regulators";
>   
>   			ldo1-supply = <&v3v3>;
> +			ldo3-supply = <&vdd_ddr>;
>   			ldo6-supply = <&v3v3>;
>   			pwr_sw1-supply = <&bst_out>;
>   


Applied on stm32-next.

Thanks.
Alex

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] ARM: dts: stm32: correct vcc-supply for eeprom on stm32mp15xx-osd32
  2022-06-03  9:44 ` [PATCH 2/2] ARM: dts: stm32: correct vcc-supply for eeprom on stm32mp15xx-osd32 Leonard Göhrs
  2022-06-03 11:34   ` Ahmad Fatoum
@ 2022-06-13  8:15   ` Alexandre TORGUE
  1 sibling, 0 replies; 6+ messages in thread
From: Alexandre TORGUE @ 2022-06-13  8:15 UTC (permalink / raw)
  To: Leonard Göhrs, Rob Herring, Krzysztof Kozlowski,
	Maxime Coquelin
  Cc: kernel, devicetree, linux-stm32, linux-arm-kernel, linux-kernel

Hi

On 6/3/22 11:44, Leonard Göhrs wrote:
> According to the OSD32MP1 Power System overview[1] the EEPROM is connected to
> the VDD line and not to some single-purpose fixed regulator.
> Set the EEPROM supply according to the diagram to eliminate this parent-less
> regulator.
> 
> [1]: https://octavosystems.com/app_notes/osd32mp1-power-system-overview/#connections
> 
> Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
> ---
>   arch/arm/boot/dts/stm32mp15xx-osd32.dtsi | 8 +-------
>   1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> index e997c4953fd1..935b7084b5a2 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> @@ -50,12 +50,6 @@ retram: retram@38000000 {
>   			no-map;
>   		};
>   	};
> -
> -	reg_sip_eeprom: regulator_eeprom {
> -		compatible = "regulator-fixed";
> -		regulator-name = "sip_eeprom";
> -		regulator-always-on;
> -	};
>   };
>   
>   &i2c4 {
> @@ -204,7 +198,7 @@ pmic_watchdog: watchdog {
>   
>   	sip_eeprom: eeprom@50 {
>   		compatible = "atmel,24c32";
> -		vcc-supply = <&reg_sip_eeprom>;
> +		vcc-supply = <&vdd>;
>   		reg = <0x50>;
>   	};
>   };

Applied on stm32-next.

Thanks.
Alex

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-06-13  8:15 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-03  9:44 [PATCH 1/2] ARM: dts: stm32: fix missing internally connected voltage regulator for OSD32MP1 Leonard Göhrs
2022-06-03  9:44 ` [PATCH 2/2] ARM: dts: stm32: correct vcc-supply for eeprom on stm32mp15xx-osd32 Leonard Göhrs
2022-06-03 11:34   ` Ahmad Fatoum
2022-06-13  8:15   ` Alexandre TORGUE
2022-06-03 11:32 ` [PATCH 1/2] ARM: dts: stm32: fix missing internally connected voltage regulator for OSD32MP1 Ahmad Fatoum
2022-06-13  8:14 ` Alexandre TORGUE

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).