From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH] arm64: dts: rockchip: support the usb2phy for rk3399 evb Date: Thu, 07 Jul 2016 12:11:41 +0200 Message-ID: <2150255.RfISFviJKP@phil> References: <1467866800-24794-1-git-send-email-wxt@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1467866800-24794-1-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Caesar Wang Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, william.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org, huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org, eddie.cai-TNX95d0MmH7DzftRWevZcw@public.gmane.org, Frank Wang List-Id: devicetree@vger.kernel.org Hi, Am Donnerstag, 7. Juli 2016, 12:46:40 schrieb Caesar Wang: > From: Frank Wang > > This patch adds the usb2phy needed dts node information for rk3399. > > USB2.0 PHY is comprised of one Host port and one OTG port. > Host Port is for USB2.0 host controller; OTG port is for USB2.0 part of > USB3.0 OTG controller, and as a part to construct a fully feature TypeC > subsystem. > > The USB2.0 vbus gpio is board specific, it's no same with all rk3399 > boards, so move it into evb voard. > > Signed-off-by: Frank Wang > Signed-off-by: Caesar Wang > --- > > arch/arm64/boot/dts/rockchip/rk3399-evb.dts | 4 ++++ > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 19 +++++++++++++++++++ > 2 files changed, 23 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index 4c84229..21d147f 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -242,6 +242,25 @@ > status = "disabled"; > }; > > + usb2phy: usb2phy { > + compatible = "rockchip,rk3399-usb-phy"; > + rockchip,grf = <&grf>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + usb2phy0: usb2-phy0 { > + #phy-cells = <0>; > + #clock-cells = <0>; > + reg = <0xe458>; > + }; > + > + usb2phy1: usb2-phy1 { > + #phy-cells = <0>; > + #clock-cells = <0>; > + reg = <0xe468>; > + }; > + }; > + The rk3399 uses the innosilicon usb2 phy and the binding we've come up for it looks a lot different than the above. So I'm not sure where this is coming from, especially as I haven't seen the driver part for the rk3399 at all yet. So far Frank was always working on te rk3366 variant, which seemed to be the most complete. Heiko -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html