Re: [PATCH 07/10] usb: Make sure that DWC2 initializes after the power channel mailbox driver.

Stephen Warren
2015-03-04T03:17:24Z

On 03/03/2015 01:32 AM, Lee Jones wrote:
> On Mon, 02 Mar 2015, Eric Anholt wrote:
>> This gets USB working on the Raspberry Pi without relying on U-Boot to
>> send the power message for us. Without it, you would get warnings
>> about fifo sizes and "dwc2_core_reset() HANG! Soft Reset
>> GRSTCTL=80000001" leading to a failed probe.

>> diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c

>> +bool bcm2835_usb_power_enabled(void)
>> +{
>> +#ifdef CONFIG_BCM2835_MBOX
>
> Please don't put #ifdeffery in *.c files. If you have to match on
> CONFIG_* options, please do so using inlines in a header file
> somewhere.

I haven't heard of that restriction before. I'm sure there are many
ifdefs in C files in the kernel. What benefit does moving the ifdefs
into headers have?