From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Andrew F. Davis" Subject: Re: [PATCH v2 14/19] ASoC: tlv320aic31xx: Remove regulator notification handling Date: Fri, 1 Dec 2017 09:01:19 -0600 Message-ID: <216ac36e-772a-0919-67cc-86589d3916fc@ti.com> References: <20171129213300.20021-1-afd@ti.com> <20171129213300.20021-15-afd@ti.com> <20171201133604.6v3ychahwvlaygxi@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20171201133604.6v3ychahwvlaygxi@sirena.org.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: Mark Rutland , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Tony Lindgren , Liam Girdwood , linux-kernel@vger.kernel.org, Rob Herring , =?UTF-8?Q?Beno=c3=aet_Cousson?= List-Id: devicetree@vger.kernel.org On 12/01/2017 07:36 AM, Mark Brown wrote: > On Wed, Nov 29, 2017 at 03:32:55PM -0600, Andrew F. Davis wrote: >> A regulator being forcefully disabled is a catastrophic event that >> should never happen to most devices, especially not sound CODECs. > > That's not what the disable notification handling is for. It's there so > that the driver can skip having to reinitialize the device if other > constraints mean the power doesn't actually get turned off when it > disables the regualtors. It's nothing to do with forced disables. > Looking into the call sites, at least in this case the only time this notification will be called, outside the normal enable/disable paths (which do the same thing here: turn on regmap cache only mode and mark it dirty), will be during a force disable scenario.