* [PATCH] ARM: dts: stm32: Fix SPI controller node names
@ 2018-09-13 18:12 Rob Herring
2018-09-14 12:25 ` Alexandre Torgue
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Rob Herring @ 2018-09-13 18:12 UTC (permalink / raw)
To: devicetree, linux-arm-kernel; +Cc: Alexandre Torgue, Maxime Coquelin
SPI controller nodes should be named 'spi' rather than 'ssp'. Fixing the
name enables dtc SPI bus checks.
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Signed-off-by: Rob Herring <robh@kernel.org>
---
Please apply to the sub-arch tree. The dtc changes haven't landed, but
will for 4.20.
arch/arm/boot/dts/stm32mp157c.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi
index 661be948ab74..0e5a2f89f2d9 100644
--- a/arch/arm/boot/dts/stm32mp157c.dtsi
+++ b/arch/arm/boot/dts/stm32mp157c.dtsi
@@ -947,7 +947,7 @@
dma-requests = <48>;
};
- qspi: qspi@58003000 {
+ qspi: spi@58003000 {
compatible = "st,stm32f469-qspi";
reg = <0x58003000 0x1000>, <0x70000000 0x10000000>;
reg-names = "qspi", "qspi_mm";
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: stm32: Fix SPI controller node names
2018-09-13 18:12 [PATCH] ARM: dts: stm32: Fix SPI controller node names Rob Herring
@ 2018-09-14 12:25 ` Alexandre Torgue
2018-09-20 14:56 ` Alexandre Torgue
2018-09-21 12:56 ` Alexandre Torgue
2 siblings, 0 replies; 4+ messages in thread
From: Alexandre Torgue @ 2018-09-14 12:25 UTC (permalink / raw)
To: Rob Herring, devicetree, linux-arm-kernel; +Cc: Maxime Coquelin
On 09/13/2018 08:12 PM, Rob Herring wrote:
> SPI controller nodes should be named 'spi' rather than 'ssp'. Fixing the
> name enables dtc SPI bus checks.
>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Please apply to the sub-arch tree. The dtc changes haven't landed, but
> will for 4.20.
Thanks Rob. I will add it in my next PR for 4.20.
>
> arch/arm/boot/dts/stm32mp157c.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi
> index 661be948ab74..0e5a2f89f2d9 100644
> --- a/arch/arm/boot/dts/stm32mp157c.dtsi
> +++ b/arch/arm/boot/dts/stm32mp157c.dtsi
> @@ -947,7 +947,7 @@
> dma-requests = <48>;
> };
>
> - qspi: qspi@58003000 {
> + qspi: spi@58003000 {
> compatible = "st,stm32f469-qspi";
> reg = <0x58003000 0x1000>, <0x70000000 0x10000000>;
> reg-names = "qspi", "qspi_mm";
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: stm32: Fix SPI controller node names
2018-09-13 18:12 [PATCH] ARM: dts: stm32: Fix SPI controller node names Rob Herring
2018-09-14 12:25 ` Alexandre Torgue
@ 2018-09-20 14:56 ` Alexandre Torgue
2018-09-21 12:56 ` Alexandre Torgue
2 siblings, 0 replies; 4+ messages in thread
From: Alexandre Torgue @ 2018-09-20 14:56 UTC (permalink / raw)
To: Rob Herring, devicetree, linux-arm-kernel; +Cc: Maxime Coquelin
Hi Rob
On 09/13/2018 08:12 PM, Rob Herring wrote:
> SPI controller nodes should be named 'spi' rather than 'ssp'. Fixing the
I assume that you meant "SPI controller nodes should be named 'spi'
rather than 'qspi'" (not ssp). I'll update commit message when I'll
merge if you confirm.
regards
Alex
> name enables dtc SPI bus checks.
>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Please apply to the sub-arch tree. The dtc changes haven't landed, but
> will for 4.20.
>
> arch/arm/boot/dts/stm32mp157c.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi
> index 661be948ab74..0e5a2f89f2d9 100644
> --- a/arch/arm/boot/dts/stm32mp157c.dtsi
> +++ b/arch/arm/boot/dts/stm32mp157c.dtsi
> @@ -947,7 +947,7 @@
> dma-requests = <48>;
> };
>
> - qspi: qspi@58003000 {
> + qspi: spi@58003000 {
> compatible = "st,stm32f469-qspi";
> reg = <0x58003000 0x1000>, <0x70000000 0x10000000>;
> reg-names = "qspi", "qspi_mm";
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: stm32: Fix SPI controller node names
2018-09-13 18:12 [PATCH] ARM: dts: stm32: Fix SPI controller node names Rob Herring
2018-09-14 12:25 ` Alexandre Torgue
2018-09-20 14:56 ` Alexandre Torgue
@ 2018-09-21 12:56 ` Alexandre Torgue
2 siblings, 0 replies; 4+ messages in thread
From: Alexandre Torgue @ 2018-09-21 12:56 UTC (permalink / raw)
To: Rob Herring, devicetree, linux-arm-kernel; +Cc: Maxime Coquelin
Hi Rob
On 09/13/2018 08:12 PM, Rob Herring wrote:
> SPI controller nodes should be named 'spi' rather than 'ssp'. Fixing the
> name enables dtc SPI bus checks.
>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Please apply to the sub-arch tree. The dtc changes haven't landed, but
> will for 4.20.
>
> arch/arm/boot/dts/stm32mp157c.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi
> index 661be948ab74..0e5a2f89f2d9 100644
> --- a/arch/arm/boot/dts/stm32mp157c.dtsi
> +++ b/arch/arm/boot/dts/stm32mp157c.dtsi
> @@ -947,7 +947,7 @@
> dma-requests = <48>;
> };
>
> - qspi: qspi@58003000 {
> + qspi: spi@58003000 {
> compatible = "st,stm32f469-qspi";
> reg = <0x58003000 0x1000>, <0x70000000 0x10000000>;
> reg-names = "qspi", "qspi_mm";
>
After fixup commmit message:
Applied on stm32-next.
Thanks.
Alex
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-21 12:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-13 18:12 [PATCH] ARM: dts: stm32: Fix SPI controller node names Rob Herring
2018-09-14 12:25 ` Alexandre Torgue
2018-09-20 14:56 ` Alexandre Torgue
2018-09-21 12:56 ` Alexandre Torgue
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).