From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add basic support for orion-r68 Date: Fri, 15 Jan 2016 15:03:52 +0100 Message-ID: <2174023.jkjdoEECkq@phil> References: <1452863192-29231-1-git-send-email-matthias.bgg@gmail.com> <1452863192-29231-2-git-send-email-matthias.bgg@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Javier Martinez Canillas Cc: Matthias Brugger , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Catalin Marinas , Will Deacon , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Thierry Reding , Alexandru Stan , Arnd Bergmann , Brian Norris , Douglas Anderson , naobsd-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Linux Kernel , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Sjoerd Simons , mbrugger-IBi9RG/b67k@public.gmane.org, Dmitry Torokhov , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, Olof List-Id: devicetree@vger.kernel.org Hi Javier, Am Freitag, 15. Januar 2016, 10:28:44 schrieb Javier Martinez Canillas: > This is not a complete review but I just wanted to comment on two > things that I noticed: same for me for now :-) > On Fri, Jan 15, 2016 at 10:06 AM, Matthias Brugger > wrote: > > [snip] > > > + }; > > + > > + vcc_18: vcc18-regulator { > > + compatible = "regulator-fixed"; > > + regulator-name = "vcc_18"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-always-on; > > + regulator-boot-on; > > + vin-supply = <&vcc_sys>; > > + }; > > + > > + /* supplies both host and otg */ > > + vcc_host: vcc-host-regulator { > > + compatible = "regulator-fixed"; > > + gpio = <&gpio0 4 GPIO_ACTIVE_LOW>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&host_vbus_drv>; > > + regulator-name = "vcc_host"; > > + regulator-always-on; > > + regulator-boot-on; > > + vin-supply = <&vcc_sys>; > > + }; > > + > > + vccio_sd: vcc-io-sd-regulator { > > + regulator-name= "vccio_sd"; > > + gpio = <&gpio0 9 GPIO_ACTIVE_LOW>; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + }; > > + > > + vcc_sd: vcc-sd-regulator { > > + compatible = "regulator-fixed"; > > + regulator-name = "vcc_sd"; > > + gpio = <&gpio3 11 GPIO_ACTIVE_LOW>; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-always-on; > > + regulator-boot-on; > > + vin-supply = <&vcc_io>; > > + }; > > + > > + vcc_io: vcc-io-regulator { > > + compatible = "regulator-fixed"; > > + regulator-name = "vcc_io"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-always-on; > > + regulator-boot-on; > > + vin-supply = <&vcc_sys>; > > + }; > > + > > + vcc_lan: vcc-lan-regulator { > > + compatible = "regulator-fixed"; > > + regulator-name = "vcc_lan"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-always-on; > > + regulator-boot-on; > > + vin-supply = <&vcc_io>; > > + }; > > + > > + vcc_sys: vcc-sys-regulator { > > + compatible = "regulator-fixed"; > > + regulator-name = "vcc_sys"; > > + regulator-min-microvolt = <5000000>; > > + regulator-max-microvolt = <5000000>; > > + regulator-always-on; > > + regulator-boot-on; > > + }; > > + > > + vccio_wl: vccio-wl-regulator { > > + compatible = "regulator-fixed"; > > + regulator-name = "vccio_wl"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-always-on; > > + regulator-boot-on; > > + vin-supply = <&vcc_io>; > > + }; > > + > > + vdd_10: vdd-10-regulator { > > + compatible = "regulator-fixed"; > > + regulator-name = "vdd_10"; > > + regulator-min-microvolt = <1000000>; > > + regulator-max-microvolt = <1000000>; > > + regulator-always-on; > > + regulator-boot-on; > > + vin-supply = <&vcc_sys>; > > + }; > > +}; > > There is only one regulator that is not marked as always-on. This will > prevent the regulator subsystem to disable unused regulators. Do you > really need all of them to be always-on? I do believe the regulators should be more or less correct. Sadly there are no real schematics for that specific device available, but the reference design for rk3368-based tv-boxes uses a hirarchy of hard-wired individual regulators without any ability to control for most of them [aka always on]. And due to the r68 not sporting any different real pmic, I'd believe the Orion will most likely also follow that scheme. Heiko -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html