From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: Jon Mason <jonmason-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
Florian Fainelli
<f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Hauke Mehrtens <hauke-5/S+JYg5SzeELgA04lAiVw@public.gmane.org>,
bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 3/3] arm: dts: bcm5301x: Add syscon based reboot in DT
Date: Fri, 18 Dec 2015 22:44:28 +0100 [thread overview]
Message-ID: <2180042.V6T2Tnxp6B@wuerfel> (raw)
In-Reply-To: <1450474676-10210-3-git-send-email-jonmason-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
On Friday 18 December 2015 16:37:56 Jon Mason wrote:
> + cru: cru@1800c184 {
> + compatible = "syscon";
> + reg = <0x1800c184 0xc>;
> + };
It's unusual for a device to start at such an odd address. Are you sure
it's not a larger device starting at 0x1800c000 or 0x18000000?
Also, please provide a more specific compatible string based on the
name of the device in the data sheet. The node name in contrast should
be more generic, e.g.
cru: system-controller@1800c000 {
compatible = "brcm,bcm53010-cru", "syscon";
reg = <0x1800c000 0x400>; /* whatever the data sheet says */
};
Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-12-18 21:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 21:37 [PATCH 1/3] ARM: dts: bcm5301x: Add TWD WD Support to DT Jon Mason
[not found] ` <1450474676-10210-1-git-send-email-jonmason-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2015-12-18 21:37 ` [PATCH 2/3] ARM: dts: bcm5301x: Add I2C support to the DT Jon Mason
2015-12-18 21:37 ` [PATCH 3/3] arm: dts: bcm5301x: Add syscon based reboot in DT Jon Mason
[not found] ` <1450474676-10210-3-git-send-email-jonmason-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2015-12-18 21:44 ` Arnd Bergmann [this message]
2016-01-05 22:26 ` Jon Mason
[not found] ` <20160105222605.GL31867-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-01-07 14:45 ` Arnd Bergmann
2015-12-18 21:51 ` [PATCH 1/3] ARM: dts: bcm5301x: Add TWD WD Support to DT Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2180042.V6T2Tnxp6B@wuerfel \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=hauke-5/S+JYg5SzeELgA04lAiVw@public.gmane.org \
--cc=jonmason-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).