public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Akhila YS <akhilayalmati@gmail.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: mtd: st,spear600-smi: convert to DT schema
Date: Tue, 10 Mar 2026 20:39:33 +0530	[thread overview]
Message-ID: <218070f6-4876-45dc-adae-53400519d6de@gmail.com> (raw)
In-Reply-To: <87bjgxoy2p.fsf@bootlin.com>


On 09-03-2026 20:21, Miquel Raynal wrote:
> Hello Akhila,
>
> On 25/02/2026 at 15:02:50 GMT, Akhila YS <akhilayalmati@gmail.com> wrote:
>
>> Convert STMicroelectronics SPEAr600 Serial Memory Interface (SMI)
>> Controller binding to YAML format.
>>
>> Signed-off-by: Akhila YS <akhilayalmati@gmail.com>
> Gasp :-) Good to see that you actually did fix the issues. Thanks for
> doing that. But you've been sending a v2 for a patch that has already
> landed in Torvalds' tree. In this case, there are only 2 possibilities:
> - sending a revert of the former patch and then this one
> - sending fixes like I did
> In no case we can just apply this one as-is.
>
> As it's been reviewed already by Rob, I'll take the 3 fixes that I
> proposed.


Okay, sure not an issue miquel.

>
> [...]
>
>> +  clock-rate:
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    description: Functional clock rate of the SMI controller in Hz.
> This clock property (which I did not address in my series) is apparently
> not used anywhere upstream. This is a very legacy property, and my
> feeling is that it has not been useful for quite some time already (due
> to the CCF being able to provide a proper clock tree now). Hence we have
> two choices: considering that it does not need to be described at all in
> the yaml bindings because it is (very) deprecated property, we might
> want to just drop it off. Otherwise you may send a patch specifically
> for this addition, however in this case you need to flag it deprecated,
> I believe.


Okay.

>
> Thanks,
> Miquèl

-- 
Best Regards,
Akhila.


      reply	other threads:[~2026-03-10 15:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25 15:02 [PATCH v2] dt-bindings: mtd: st,spear600-smi: convert to DT schema Akhila YS
2026-03-09 14:51 ` Miquel Raynal
2026-03-10 15:09   ` Akhila YS [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=218070f6-4876-45dc-adae-53400519d6de@gmail.com \
    --to=akhilayalmati@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=robh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox