Re: [PATCH v4 45/49] adv7604: Add DT support

Laurent Pinchart
2014-04-17T14:43:29Z

Hi Sylwester,

On Thursday 17 April 2014 16:39:29 Sylwester Nawrocki wrote:
> On 17/04/14 16:13, Laurent Pinchart wrote:
> > Parse the device tree node to populate platform data. Only the ADV7611
> > is currently support with DT.
> >
> > Cc: devicetree@vger.kernel.org
> > Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
>
> The patch looks good to me.
>
> Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

Thank you.

> Just one comment below...

[snip]

> > diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c
> > index 342d73d..061794e 100644
> > --- a/drivers/media/i2c/adv7604.c
> > +++ b/drivers/media/i2c/adv7604.c
> > @@ -2663,13 +2663,58 @@ static const struct adv7604_chip_info
> > adv7604_chip_info[] = {>
> > },
> >
> > };
> >
> > +static struct i2c_device_id adv7604_i2c_id[] = {
> > + { "adv7604", (kernel_ulong_t)&adv7604_chip_info[ADV7604] },
> > + { "adv7611", (kernel_ulong_t)&adv7604_chip_info[ADV7611] },
> > + { }
> > +};
> > +MODULE_DEVICE_TABLE(i2c, adv7604_i2c_id);
> > +
> > +static struct of_device_id adv7604_of_id[] = {
>
> Not adding __maybe_unused attribute to this one ?

Sure, of course. I'll squash patch 49/49 into this one.

> > + { .compatible = "adi,adv7611", .data = &adv7604_chip_info[ADV7611] },
> > + { }
> > +};
> > +MODULE_DEVICE_TABLE(of, adv7604_of_id);

--
Regards,

Laurent Pinchart